Merge pull request #12 from cstavitsky/release_version_parity

Release version parity

Author: cstavitsky

README.md

@@ -158,10 +158,101 @@ Could also be a problem with the backend container/app you're requesting the too
 
 When developing locally, must point React Native to http://127.0.0.1:8080/products backend instead of https://localhost:8080/products backend.
 
+# How To Create a Release
 
-## Creating release with APK + .app.zip for [Test-Data Automation](https://github.com/sentry-demos/application-monitoring/tree/master/tests)
+You must complete all of the following steps when setting a new release version:
 
-First generate the apps using `npx react-native run-ios --configuration Release` for iOS, and `npx react-native run-android --variant Release` for Andriod
+## 1. Tick the release version forward.
 
+There is only one command needed here:
 
-`gh releaase create <VERSION>  <PATH_TO_ANDROID_APK> <PATH_TO_ZIPPED_IOS_APP>`
+```
+$ npm version patch
+```
+
+This:
+- Increments version by 0.0.1, i.e. `2.0.1` -> `2.0.2`.
+- Automatically keeps versioning consistent across package.json and associated android and ios files
+- Automatically creates a commit for the newly created release, i.e. `2.0.2`
+
+You should see:
+
+![Screen Shot 2021-12-08 at 12 42 36 PM](https://user-images.githubusercontent.com/12092849/145281424-5900b190-4369-4607-ac2d-b4a317e28eea.png)
+
+We can run `git log` to confirm that the release commit for `2.0.2` was created:
+
+![Screen Shot 2021-12-08 at 12 59 35 PM](https://user-images.githubusercontent.com/12092849/145283580-5b6186c7-4861-46b9-a6f0-0dfa8d20db58.png)
+
+Be careful about which project you are pointing to when you start ticking releases forward or triggering them. Note that once you tick the release version forward locally (i.e. to `2.0.2`), if you locally trigger an error, the Sentry project you're pointing to will start reporting that error as associated with release `2.0.2` (even though your code is being run locally and is technically not deployed). Such are the dangers of having a demo app's release process not occur during a typical release pipeline.
+
+The `npm version patch` command automatically keeps releases consistent across `package.json`, `Info.plist`, and `build.gradle` thanks to [react-native-version](https://github.com/stovmascript/react-native-version).
+
+## 2. Create a Github Release
+
+It's also crucial that we create a Github release so that our automated test jobs (located in the [application-monitoring repo](https://github.com/sentry-demos/application-monitoring/tree/master/tests)) can create data in Sentry based on the latest react native code.
+
+What’s the purpose of this? 
+
+Basically in the Github releases, we want to make sure certain artifacts are uploaded. For example in this release I did, 1.9, we have .apk and .app.zip artifacts uploaded. The generated artifacts will be uploaded to the Github Release we create. Then, our automated ‘TDA’ (test data automation) tests will use these builds of the app to generate data and populate our Sentry demo projects.
+
+This is a guide of how to build those artifacts and create a Github Release, while uploading the relevant artifacts along with the release.
+
+### Generate Release/Debug Artifacts
+
+(:pencil2: I'm hoping to make this a less manual process in the future so that you can just run one or two scripts. Unfortunately some things I haven't figured out about Xcode are preventing that. -Chris)
+
+First: ensure your local repo is up to date with the Github `master` branch via `git pull origin master`.
+
+#### iOS
+
+1. Generate the Release build
+- `cd` into the root repository directory - `sentry_react_native`
+- Run `npx react-native run-ios --configuration Release`. This will start the iPhone simulator and launch the app but we don’t care about that -- this command also creates the release build. 
+- This will result in a directory being populated under /Users/cstavitsky/Library/Developer/Xcode/DerivedData (replace cstavitsky with your local username). There will be a sentry-react-native-<bunch of random chars> directory.
+- Copy the newly created release artifact into the current directory: `cp -r /Users/cstavitsky/Library/Developer/Xcode/DerivedData/sentry_react_native-dgoblbkgunhkxscqaagaqprvjqus/Build/Products/Release-iphonesimulator/sentry_react_native.app sentry_react_native.app` [your hash sentry_react_native-<....> will probably be different]
+- Zip the copied directory so that the .zip can be uploaded along with the Github release: `zip -r sentry_react_native.app.zip sentry_react_native.app`
+- If you do a `git status` you should see that `sentry_react_native.app.zip` was `modified`.
+- Run `git add sentry_react_native.app.zip`
+
+2. Generate the Debug build
+- Run `npx react-native run-ios --configuration Debug`. This will start the iPhone simulator and launch the app but we don’t care about that -- this command also creates the debug build. 
+- This will result in a directory being populated under /Users/cstavitsky/Library/Developer/Xcode/DerivedData (replace cstavitsky with your local username). There will be a sentry-react-native-<bunch of random chars> directory.
+- Copy the newly created release artifact into the current directory: `cp -r /Users/cstavitsky/Library/Developer/Xcode/DerivedData/sentry_react_native-dgoblbkgunhkxscqaagaqprvjqus/Build/Products/Debug-iphonesimulator/sentry_react_native.app sentry_react_native_debug.app` [your hash sentry_react_native-<....> will probably be different]
+- Zip the copied directory `zip -r sentry_react_native_debug.app.zip sentry_react_native_debug.app`
+- Run `git add sentry_react_native_debug.app.zip`
+
+### Android
+  
+1. Generate the Release build
+- Run `npx react-native run-android --variant Release`. This will generate the Android release build. Ignore the emulator.
+- Copy the release build to the root directory of the project: `cp android/app/build/outputs/apk/release/app-release.apk ./`
+- Run `git add app-release.apk`
+  
+2. Generate the Debug build
+- Run `npx react-native run-android --variant Debug`. This will generate the Android debug build. Ignore the emulator.
+- Copy the debug build to the root directory of the project: `cp android/app/build/outputs/apk/debug/app-debug.apk ./`
+- Run `git add app-debug.apk`
+
+Create a Github Release:
+
+Note: do not proceed with this until you have done all the previous steps.
+
+1. (If this is your first time doing this, run `brew install gh` to install the Github CLI tool. Once you install it, you can skip this step in the future)
+2. Commit the four files `git commit -m “Add release artifacts”`
+3. Run the release script `./github_release.sh`, and select yes when prompted.
+
+Your new release should be [visible on Github](https://github.com/sentry-demos/sentry_react_native/releases).
+
+### [Troubleshooting - Locally undoing an accidental increment of the release version]
+
+If you accidentally tick the version forward by running `npm version patch`, and did not intend to do so, you can undo this.
+
+Let's say we were previously on `2.0.1` and accidentally ran the command twice, ticking the release to `2.0.2` and `2.0.3`, but we only wanted to go to `2.0.2`.
+
+- First, run `git log`.
+- Copy the commit hash associated with the previous commit that you want to reset to.
+
+![Screen Shot 2021-12-08 at 12 55 09 PM](https://user-images.githubusercontent.com/12092849/145283369-2130cae7-fe0c-42ff-b826-0015c3cd565b.png)
+
+- run `git reset <the commit hash>`.
+- Check out any unwanted files that are no longer staged for commit.

android/app/build.gradle

@@ -138,8 +138,8 @@ android {
         applicationId "com.sentry_react_native"
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
-        versionCode 2
-        versionName "1.7"
+        versionCode 3
+        versionName "2.0.3"
     }
     splits {
         abi {

app-debug.apk

@@ -0,0 +1,14 @@
+PACKAGE_VERSION=$(node -p -e "require('./package.json').version")
+REPO=sentry-demos/sentry_react_native
+
+while true; do
+    read -p "Do you wish to create Github Release $PACKAGE_VERSION for $REPO? Answer y/n: " yn
+    case $yn in
+        [Yy]* ) make install; break;;
+        [Nn]* ) exit;;
+        * ) echo "Please answer y or n.";;
+    esac
+done
+
+gh release create $PACKAGE_VERSION app-debug.apk app-release.apk sentry_react_native.app.zip sentry_react_native_debug.app.zip
+

app-release.apk

@@ -15,26 +15,26 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.0</string>
+	<string>2.0.3</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>1</string>
+	<string>3</string>
 	<key>LSRequiresIPhoneOS</key>
-	<true/>
+	<true />
 	<key>NSAppTransportSecurity</key>
 	<dict>
 		<key>NSExceptionDomains</key>
 		<dict>
 			<key>localhost</key>
 			<dict>
 				<key>NSExceptionAllowsInsecureHTTPLoads</key>
-				<true/>
+				<true />
 			</dict>
 		</dict>
 	</dict>
 	<key>NSLocationWhenInUseUsageDescription</key>
-	<string></string>
+	<string />
 	<key>UILaunchStoryboardName</key>
 	<string>LaunchScreen</string>
 	<key>UIRequiredDeviceCapabilities</key>
@@ -48,6 +48,6 @@
 		<string>UIInterfaceOrientationLandscapeRight</string>
 	</array>
 	<key>UIViewControllerBasedStatusBarAppearance</key>
-	<false/>
+	<false />
 </dict>
 </plist>

github_release.sh

@@ -15,10 +15,10 @@
 	<key>CFBundlePackageType</key>
 	<string>BNDL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.0</string>
+	<string>2.0.3</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>1</string>
+	<string>3</string>
 </dict>
 </plist>

ios/sentry_react_native-tvOS/Info.plist

@@ -670,7 +670,7 @@
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CLANG_ENABLE_MODULES = YES;
-				CURRENT_PROJECT_VERSION = 1;
+				CURRENT_PROJECT_VERSION = 2;
 				ENABLE_BITCODE = NO;
 				INFOPLIST_FILE = sentry_react_native/Info.plist;
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
@@ -693,7 +693,7 @@
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CLANG_ENABLE_MODULES = YES;
-				CURRENT_PROJECT_VERSION = 1;
+				CURRENT_PROJECT_VERSION = 2;
 				INFOPLIST_FILE = sentry_react_native/Info.plist;
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
 				OTHER_LDFLAGS = (

ios/sentry_react_native-tvOSTests/Info.plist

@@ -17,28 +17,28 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.8</string>
+	<string>2.0.3</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>1</string>
+	<string>3</string>
 	<key>LSRequiresIPhoneOS</key>
-	<true/>
+	<true />
 	<key>NSAppTransportSecurity</key>
 	<dict>
 		<key>NSAllowsArbitraryLoads</key>
-		<true/>
+		<true />
 		<key>NSExceptionDomains</key>
 		<dict>
 			<key>localhost</key>
 			<dict>
 				<key>NSExceptionAllowsInsecureHTTPLoads</key>
-				<true/>
+				<true />
 			</dict>
 		</dict>
 	</dict>
 	<key>NSLocationWhenInUseUsageDescription</key>
-	<string></string>
+	<string />
 	<key>UILaunchStoryboardName</key>
 	<string>LaunchScreen</string>
 	<key>UIRequiredDeviceCapabilities</key>
@@ -52,6 +52,6 @@
 		<string>UIInterfaceOrientationLandscapeRight</string>
 	</array>
 	<key>UIViewControllerBasedStatusBarAppearance</key>
-	<false/>
+	<false />
 </dict>
 </plist>

ios/sentry_react_native.xcodeproj/project.pbxproj

@@ -15,10 +15,10 @@
 	<key>CFBundlePackageType</key>
 	<string>BNDL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.0</string>
+	<string>2.0.3</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>1</string>
+	<string>3</string>
 </dict>
 </plist>