#2803: don't handle exceptions in UfedXmlReader.isSupported()

aberenguel · aberenguel · commit 2ce36bda88bc · 2026-02-24T15:39:08.000-03:00
diff --git a/iped-engine/src/main/java/iped/engine/datasource/UfedXmlReader.java b/iped-engine/src/main/java/iped/engine/datasource/UfedXmlReader.java
@@ -164,11 +164,9 @@ public boolean isSupported(File datasource) {
         }
 
         // supports any folder with valid XML report inside
-        try (InputStream xmlReport = lookUpXmlReportInputStream(datasource)) {
-            return xmlReport != null;
-        } catch (Exception e) {
-            return false;
-        }
+        InputStream xmlReport = lookUpXmlReportInputStream(datasource);
+        IOUtil.closeQuietly(xmlReport);
+        return xmlReport != null;
     }
 
     private InputStream getXmlInputStream(File file) {

Original file line number	Diff line number	Diff line change
`@@ -164,11 +164,9 @@ public boolean isSupported(File datasource) {`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`// supports any folder with valid XML report inside`
`167`		`- try (InputStream xmlReport = lookUpXmlReportInputStream(datasource)) {`
`168`		`- return xmlReport != null;`
`169`		`- } catch (Exception e) {`
`170`		`- return false;`
`171`		`- }`
	`167`	`+ InputStream xmlReport = lookUpXmlReportInputStream(datasource);`
	`168`	`+ IOUtil.closeQuietly(xmlReport);`
	`169`	`+ return xmlReport != null;`
`172`	`170`	`}`
`173`	`171`
`174`	`172`	`private InputStream getXmlInputStream(File file) {`