Skip to content

Commit 67f2dc5

Browse files
authored
Merge pull request #2796 from sepinf-inc/#2795_FixHashSetStatus
Fix hashDb set/status property name used in some parsers
2 parents 714eb71 + ecfece2 commit 67f2dc5

File tree

21 files changed

+46
-39
lines changed

21 files changed

+46
-39
lines changed

iped-api/src/main/java/iped/properties/ExtraProperties.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,12 @@ public class ExtraProperties {
188188

189189
public static final String FACE_AGE_LABELS = "faceAge:labels";
190190

191+
public static final String HASHDB_PREFIX = "hashDb:";
192+
public static final String STATUS_PROPERTY = "status";
193+
public static final String SET_PROPERTY = "set";
194+
public static final String HASHDB_STATUS = HASHDB_PREFIX + STATUS_PROPERTY;
195+
public static final String HASHDB_SET = HASHDB_PREFIX + SET_PROPERTY;
196+
191197
/**
192198
* Property to be set if the evidence is a animated image (i.e. contain multiple
193199
* frames). Only set if the number of frames is greater than one.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
# Excludes from the rest of processing (and from the case) known files according to hashes database (hash:status = known).
1+
# Excludes from the rest of processing (and from the case) known files according to hashes database (hashDb:status = known).
22
excludeKnown = false

iped-app/resources/config/conf/metadataTypes.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1811,8 +1811,8 @@ fileFragment = java.lang.Boolean
18111811
fileSystemId = java.lang.String
18121812
format-detection = java.lang.String
18131813
googlebot = java.lang.String
1814-
hash:set = java.lang.String
1815-
hash:status = java.lang.String
1814+
hashDb:set = java.lang.String
1815+
hashDb:status = java.lang.String
18161816
hasSubitem = java.lang.String
18171817
hasThumb = java.lang.Boolean
18181818
html:"Content-Type" = java.lang.String
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
excludeKnown = true

iped-app/resources/config/profiles/blind/conf/HashDBLooupConfig.txt

Lines changed: 0 additions & 2 deletions
This file was deleted.

iped-app/src/main/java/iped/app/ui/columns/ColumnsManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ void updateDinamicFields() {
305305
regexFields.add(f);
306306
else if (f.startsWith(LanguageDetectTask.LANGUAGE_PREFIX))
307307
languageFields.add(f);
308-
else if (f.startsWith(HashDBLookupTask.ATTRIBUTES_PREFIX)
308+
else if (f.startsWith(ExtraProperties.HASHDB_PREFIX)
309309
|| f.startsWith(PhotoDNALookup.PHOTO_DNA_HIT_PREFIX))
310310
hashDbFields.add(f);
311311
else

iped-engine/src/main/java/iped/engine/hashdb/HashDBDataSource.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import org.sqlite.SQLiteConfig.JournalMode;
2323
import org.sqlite.SQLiteConfig.SynchronousMode;
2424

25+
import iped.properties.ExtraProperties;
2526
import iped.utils.HashValue;
2627

2728
public class HashDBDataSource {
@@ -40,8 +41,8 @@ public class HashDBDataSource {
4041
public static final String photoDna = "photoDna";
4142
private static final int photoDnaBase64Len = 192;
4243

43-
private static final String propertySet = "set";
44-
private static final String propertyStatus = "status";
44+
private static final String propertySet = ExtraProperties.SET_PROPERTY;
45+
private static final String propertyStatus = ExtraProperties.STATUS_PROPERTY;
4546
private static final String pedoStatus = "pedo";
4647

4748
public HashDBDataSource(File dbFile) throws Exception {

iped-engine/src/main/java/iped/engine/task/AbstractTask.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ private void processMonitorTimeout(IItem evidence) throws Exception {
302302
}
303303

304304
/**
305-
* Indica se itens ignorados (hash:status = ignore), devem ser processados pela
305+
* Indica se itens ignorados (hashDb:status = known), devem ser processados pela
306306
* tarefa ou não. O valor padrão é false, assim itens ignorados não são
307307
* processados pelas tarefas seguintes. Tarefas específicas podem sobrescrever
308308
* esse comportamento.

iped-engine/src/main/java/iped/engine/task/HashDBLookupTask.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,10 @@
2727
import iped.engine.hashdb.HashDBDataSource;
2828
import iped.parsers.util.ChildPornHashLookup;
2929
import iped.parsers.util.ChildPornHashLookup.LookupProvider;
30+
import iped.properties.ExtraProperties;
3031

3132
public class HashDBLookupTask extends AbstractTask {
3233

33-
public static final String ATTRIBUTES_PREFIX = "hashDb:";
34-
private static final String STATUS_PROPERTY = "status";
35-
public static final String STATUS_ATTRIBUTE = ATTRIBUTES_PREFIX + STATUS_PROPERTY;
3634
public static final String KNOWN_VALUE = "known";
3735
private static final String NSRL_PRODUCT_NAME_PROPERTY = "nsrlProductName";
3836

@@ -226,8 +224,8 @@ protected void process(IItem evidence) throws Exception {
226224
}
227225
}
228226
if (!list.isEmpty()) {
229-
evidence.setExtraAttribute(ATTRIBUTES_PREFIX + key, list);
230-
if (key.equalsIgnoreCase(STATUS_PROPERTY)) {
227+
evidence.setExtraAttribute(ExtraProperties.HASHDB_PREFIX + key, list);
228+
if (key.equalsIgnoreCase(ExtraProperties.STATUS_PROPERTY)) {
231229
status = list;
232230
} else if (key.equalsIgnoreCase(NSRL_PRODUCT_NAME_PROPERTY)) {
233231
nsrlProductName = value;
@@ -268,7 +266,7 @@ protected void process(IItem evidence) throws Exception {
268266
}
269267
if (modified) {
270268
Collections.sort(status);
271-
evidence.setExtraAttribute(STATUS_ATTRIBUTE, status);
269+
evidence.setExtraAttribute(ExtraProperties.HASHDB_STATUS, status);
272270
}
273271
}
274272
//Ignore only if there is a single status = "known"

iped-engine/src/main/java/iped/engine/task/PhotoDNATask.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import iped.engine.config.PhotoDNAConfig;
2828
import iped.engine.preview.PreviewRepositoryManager;
2929
import iped.parsers.util.MetadataUtil;
30+
import iped.properties.ExtraProperties;
3031
import iped.utils.IOUtil;
3132
import iped.utils.ImageUtil;
3233

@@ -86,7 +87,7 @@ protected void process(IItem evidence) throws Exception {
8687
if (!evidence.isToAddToCase())
8788
return;
8889

89-
if (pdnaConfig.isSkipHashDBFiles() && evidence.getExtraAttribute(HashDBLookupTask.STATUS_ATTRIBUTE) != null)
90+
if (pdnaConfig.isSkipHashDBFiles() && evidence.getExtraAttribute(ExtraProperties.HASHDB_STATUS) != null)
9091
return;
9192

9293
if (evidence.getLength() != null && evidence.getLength() < pdnaConfig.getMinFileSize())

0 commit comments

Comments
 (0)