Compiler fixes

Author: eseiler

.clang-format

@@ -246,4 +246,6 @@ TabWidth:        4
 UseTab:          Never
 VerilogBreakBetweenInstancePorts: true
 WhitespaceSensitiveMacros:
+  - SEQAN3_WORKAROUND_GCC_BOGUS_MEMCPY_START
+  - SEQAN3_WORKAROUND_GCC_BOGUS_MEMCPY_STOP
 ...

.github/workflows/ci_linux.yml

@@ -29,10 +29,14 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        compiler: ["clang-latest", "clang-second-latest", "clang-third-latest", "gcc-latest", "gcc-second-latest", "gcc-third-latest", "intel"]
+        compiler: ["clang-latest", "clang-second-latest", "gcc-latest", "gcc-second-latest", "gcc-third-latest", "intel"]
         include:
           - compiler: "intel"
             cxx_flags: "-fp-model=strict -Wno-overriding-option"
+          - compiler: "gcc-latest"
+            cxx_flags: "-Wno-stringop-overflow"
+          - compiler: "gcc-second-latest"
+            cxx_flags: "-Wno-stringop-overflow"
     container:
       image: ghcr.io/seqan/${{ matrix.compiler }}
     steps:

.github/workflows/ci_macos.yml

@@ -29,7 +29,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        compiler: ["clang-latest", "clang-second-latest", "clang-third-latest", "gcc-latest", "gcc-second-latest", "gcc-third-latest"]
+        compiler: ["clang-latest", "clang-second-latest", "gcc-latest", "gcc-second-latest", "gcc-third-latest"]
     steps:
       - name: Checkout
         uses: actions/checkout@v4

include/fpgalign/argument_parsing.hpp

@@ -17,8 +17,8 @@ enum class subcommand : uint8_t
 
 struct parse_result
 {
-    subcommand subcommand;
-    config config;
+    subcommand subcmd;
+    config cfg;
 };
 
 parse_result parse_arguments(std::vector<std::string> command_line);

src/CMakeLists.txt

@@ -42,6 +42,13 @@ if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
     endif ()
 endif ()
 
+if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
+    # std::jthread is experimental in LLVM < 20
+    if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 20)
+        target_compile_definitions (FPGAlign_lib PUBLIC "_LIBCPP_ENABLE_EXPERIMENTAL")
+    endif ()
+endif ()
+
 # Add the application.
 add_executable (FPGAlign fpgalign.cpp)
 target_link_libraries (FPGAlign PRIVATE FPGAlign_lib)

src/argument_parsing.cpp

@@ -140,13 +140,13 @@ parse_result parse_arguments(std::vector<std::string> command_line)
 
     if (sub_parser.info.app_name == std::string_view{"FPGAlign-build"})
     {
-        result.subcommand = subcommand::build;
-        result.config = build::parse_arguments(sub_parser);
+        result.subcmd = subcommand::build;
+        result.cfg = build::parse_arguments(sub_parser);
     }
     if (sub_parser.info.app_name == std::string_view{"FPGAlign-search"})
     {
-        result.subcommand = subcommand::search;
-        result.config = search::parse_arguments(sub_parser);
+        result.subcmd = subcommand::search;
+        result.cfg = search::parse_arguments(sub_parser);
     }
 
     return result;

src/fpgalign.cpp

@@ -16,10 +16,10 @@ int main(int argc, char ** argv)
     {
         parse_result const result = parse_arguments({argv, argv + argc});
 
-        if (result.subcommand == subcommand::build)
-            build::build(result.config);
-        if (result.subcommand == subcommand::search)
-            search::search(result.config);
+        if (result.subcmd == subcommand::build)
+            build::build(result.cfg);
+        if (result.subcmd == subcommand::search)
+            search::search(result.cfg);
     }
     catch (std::exception const & ext)
     {