[FIX] Todos (#213)

* fixed TODOs

* Apply suggestions from code review

* Update src/ibf.cpp

---------

Co-authored-by: Enrico Seiler <eseiler@users.noreply.github.com>

Author: koleoptil

src/ibf.cpp

@@ -418,19 +418,10 @@ void ibf_helper(std::vector<std::filesystem::path> const & minimiser_files,
         for (size_t i = 0; i < num_files; i++)
         {
             // Calculate actual FPR based on IBF parameters
-            // TODO: Why this case?
-            if (counts_per_level[i][j] > 0 && sizes_ibf[j] > 0)
-            {
-                double const exp_arg = (num_hash * counts_per_level[i][j]) / static_cast<double>(sizes_ibf[j]);
-                double const log_arg = 1.0 - std::exp(-exp_arg);
-                // TODO: Why this ternary?
-                double const fpr = (log_arg > 0) ? std::exp(num_hash * std::log(log_arg)) : 1.0;
-                outfile << fpr << " ";
-            }
-            else
-            {
-                outfile << "0.0 ";
-            }
+            double const exp_arg = (num_hash * counts_per_level[i][j]) / static_cast<double>(sizes_ibf[j]);
+            double const log_arg = 1.0 - std::exp(-exp_arg);
+            double const fpr = std::exp(num_hash * std::log(log_arg));
+            outfile << fpr << " ";
         }
         outfile << "\n";
     }