Merge pull request #3161 from eseiler/test/api

[FIX] API

Author: eseiler

test/api_stability/3.2.0/0001-NOAPI-DETAIL-Remove-seqan3-detail-persist.patch

@@ -1,7 +1,7 @@
-From a891b3f97e31ae3692260b0f6bdbdd7d5623e014 Mon Sep 17 00:00:00 2001
+From 10f7fffd7ebd542f88b35eef42e70f4e6cdfa8c7 Mon Sep 17 00:00:00 2001
 From: Enrico Seiler <[email protected]>
 Date: Thu, 20 Oct 2022 14:58:05 +0200
-Subject: [PATCH 1/4] [NOAPI] [DETAIL] Remove seqan3::detail::persist
+Subject: [PATCH 1/6] [NOAPI] [DETAIL] Remove seqan3::detail::persist
 
 ---
  test/snippet/core/detail/persist_view.cpp     |  37 ------

test/api_stability/3.2.0/0002-NOAPI-Fix-wrong-alignment-score.patch

@@ -1,7 +1,7 @@
-From b465f21eb58a9f56e98f8d25f008809bb997cedd Mon Sep 17 00:00:00 2001
+From 3e37b45a4aa12391268dcfe5da5f318a17e80b86 Mon Sep 17 00:00:00 2001
 From: Enrico Seiler <[email protected]>
 Date: Mon, 9 Jan 2023 15:16:43 +0100
-Subject: [PATCH 2/4] [NOAPI] Fix wrong alignment score
+Subject: [PATCH 2/6] [NOAPI] Fix wrong alignment score
 
 ---
  .../matrix/detail/debug_stream_trace_directions_test.cpp      | 4 ++--

test/api_stability/3.2.0/0003-API-BREAKAGE-Remove-field-alignment-offset-and-impro.patch

@@ -1,7 +1,7 @@
-From e186b58707e8c25ae8d6d1301674f45a48ead9fa Mon Sep 17 00:00:00 2001
+From 30a1f9e6b676452fd77ecc0b0dd655968cdeea2b Mon Sep 17 00:00:00 2001
 From: Enrico Seiler <[email protected]>
 Date: Mon, 9 Jan 2023 15:16:55 +0100
-Subject: [PATCH 3/4] [API][BREAKAGE] Remove field::{alignment,offset} and
+Subject: [PATCH 3/6] [API][BREAKAGE] Remove field::{alignment,offset} and
  improve performance
 
 ---

test/api_stability/3.2.0/0004-API-FIX-Use-namespace-seqan2.patch

@@ -1,7 +1,7 @@
-From 03becc43be5398bb3d4572a8adbb0389a07b0f0e Mon Sep 17 00:00:00 2001
+From ea874af70b8e12d88b5c64f4c538c159df0c822b Mon Sep 17 00:00:00 2001
 From: Enrico Seiler <[email protected]>
 Date: Sun, 14 May 2023 15:21:47 +0200
-Subject: [PATCH 4/4] [API][FIX] Use namespace seqan2
+Subject: [PATCH 4/6] [API][FIX] Use namespace seqan2
 
 ---
  .../align_pairwise_edit_distance.hpp          |  8 +--

test/api_stability/3.2.0/0005-API-FIX-views-zip-is-no-range-adaptor.patch

@@ -0,0 +1,25 @@
+From 418f3853e4a62b5cd5997011cfcb429e7bceaef6 Mon Sep 17 00:00:00 2001
+From: Enrico Seiler <[email protected]>
+Date: Sat, 10 Jun 2023 10:28:52 +0200
+Subject: [PATCH 5/6] [API][FIX] views::zip is no range adaptor
+
+---
+ test/unit/utility/views/zip_test.cpp | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/test/unit/utility/views/zip_test.cpp b/test/unit/utility/views/zip_test.cpp
+index a92e78651..3dd4d65f3 100644
+--- a/test/unit/utility/views/zip_test.cpp
++++ b/test/unit/utility/views/zip_test.cpp
+@@ -144,7 +144,7 @@ TEST_F(zip_test, basic)
+         EXPECT_EQ(zip_view.size(), 4u);
+     }
+     {
+-        auto zip_view = range | seqan3::views::zip(other_range);
++        auto zip_view = seqan3::views::zip(range, other_range);
+         size_t i{};
+         for (auto && [elem_1, elem_2] : zip_view)
+         {
+-- 
+2.40.1
+

test/api_stability/3.2.0/0006-API-FIX-views-chunk-preserves-common_range.patch

@@ -0,0 +1,51 @@
+From bb4305d06083259b6efb5383331189781362bf82 Mon Sep 17 00:00:00 2001
+From: Enrico Seiler <[email protected]>
+Date: Sat, 10 Jun 2023 11:23:53 +0200
+Subject: [PATCH 6/6] [API][FIX] views::chunk preserves common_range
+
+---
+ test/unit/utility/views/chunk_test.cpp | 14 +++-----------
+ 1 file changed, 3 insertions(+), 11 deletions(-)
+
+diff --git a/test/unit/utility/views/chunk_test.cpp b/test/unit/utility/views/chunk_test.cpp
+index 9b8c12baa..3bb2d8b89 100644
+--- a/test/unit/utility/views/chunk_test.cpp
++++ b/test/unit/utility/views/chunk_test.cpp
+@@ -61,19 +61,19 @@ TYPED_TEST_SUITE(chunk_view_test, underlying_range_types, );
+ 
+ TYPED_TEST(chunk_view_test, concepts)
+ {
+-    // chunk view preserves input / forward / bidirectional / random_access / sized.
++    // chunk view preserves input / forward / bidirectional / random_access / sized / common.
+     EXPECT_EQ((std::ranges::range<TypeParam>), (std::ranges::range<decltype(this->v)>));
+     EXPECT_EQ((std::ranges::input_range<TypeParam>), (std::ranges::input_range<decltype(this->v)>));
+     EXPECT_EQ((std::ranges::forward_range<TypeParam>), (std::ranges::forward_range<decltype(this->v)>));
+     EXPECT_EQ((std::ranges::bidirectional_range<TypeParam>), (std::ranges::bidirectional_range<decltype(this->v)>));
+     EXPECT_EQ((std::ranges::random_access_range<TypeParam>), (std::ranges::random_access_range<decltype(this->v)>));
+     EXPECT_EQ((std::ranges::sized_range<TypeParam>), (std::ranges::sized_range<decltype(this->v)>));
++    EXPECT_EQ((std::ranges::common_range<TypeParam>), (std::ranges::common_range<decltype(this->v)>));
+ 
+     // it always ensures view
+     EXPECT_TRUE((std::ranges::view<decltype(this->v)>));
+ 
+-    // it loses contiguous range, common_range and output range
+-    EXPECT_FALSE((std::ranges::common_range<decltype(this->v)>));
++    // it loses contiguous range and output range
+     EXPECT_FALSE((std::ranges::contiguous_range<decltype(this->v)>));
+     EXPECT_FALSE((std::ranges::output_range<decltype(this->v), std::ranges::range_value_t<TypeParam> &>));
+ }
+@@ -184,11 +184,3 @@ TYPED_TEST(chunk_view_test, use_on_temporaries)
+         EXPECT_EQ(i, 4u);
+     }
+ }
+-
+-TYPED_TEST(chunk_view_test, big_chunk)
+-{
+-    // Check that a very big number (1ULL<<42) can be stored as chunk_size inside the chunk_view.
+-    // error: conversion from ‘long long unsigned int’ to ‘uint16_t’ {aka ‘short unsigned int’} changes value
+-    // from ‘4398046511104’ to ‘0’ [-Werror=overflow]
+-    [[maybe_unused]] auto v = this->text | seqan3::views::chunk(1ULL << 42);
+-}
+-- 
+2.40.1
+