Merge pull request #268 from eseiler/fix/codechecker

[FIX] some codechecker reports

Author: eseiler

.github/config/codechecker.yml

@@ -7,6 +7,7 @@ analyze:
   - --enable=bugprone
   - --enable=clang-diagnostic-shadow
   - --disable=bugprone-easily-swappable-parameters
+  - --disable=cert-dcl58-cpp
   - --disable=clang-diagnostic-implicit-int-float-conversion
   - --disable=clang-diagnostic-float-conversion
   - --disable=clang-diagnostic-implicit-int-conversion

doc/tutorial/parser/solution3.cpp

@@ -19,7 +19,7 @@ number_type to_number(range_type && range)
         return s;
     }();
     number_type num;
-    auto res = std::from_chars(&str[0], &str[0] + str.size(), num);
+    auto res = std::from_chars(str.data(), str.data() + str.size(), num);
 
     if (res.ec != std::errc{})
     {

doc/tutorial/parser/solution4.cpp

@@ -18,7 +18,7 @@ number_type to_number(range_type && range)
         return s;
     }();
     number_type num;
-    auto res = std::from_chars(&str[0], &str[0] + str.size(), num);
+    auto res = std::from_chars(str.data(), str.data() + str.size(), num);
 
     if (res.ec != std::errc{})
     {

doc/tutorial/parser/solution5.cpp

@@ -18,7 +18,7 @@ number_type to_number(range_type && range)
         return s;
     }();
     number_type num;
-    auto res = std::from_chars(&str[0], &str[0] + str.size(), num);
+    auto res = std::from_chars(str.data(), str.data() + str.size(), num);
 
     if (res.ec != std::errc{})
     {

doc/tutorial/parser/solution6.cpp

@@ -18,7 +18,7 @@ number_type to_number(range_type && range)
         return s;
     }();
     number_type num;
-    auto res = std::from_chars(&str[0], &str[0] + str.size(), num);
+    auto res = std::from_chars(str.data(), str.data() + str.size(), num);
 
     if (res.ec != std::errc{})
     {

include/sharg/detail/format_base.hpp

@@ -373,7 +373,7 @@ class format_help_base : public format_base
         if (!meta.description.empty())
         {
             derived_t().print_section("Description");
-            for (auto desc : meta.description)
+            for (auto && desc : meta.description)
                 print_line(desc);
         }
 
@@ -397,14 +397,14 @@ class format_help_base : public format_base
             derived_t().print_section("Positional Arguments");
 
         // each call will evaluate the function derived_t().print_list_item()
-        for (auto f : positional_option_calls)
+        for (auto && f : positional_option_calls)
             f();
 
         // There are always options because of the common options
         derived_t().print_section("Options");
 
         // each call will evaluate the function derived_t().print_list_item()
-        for (auto f : parser_set_up_calls)
+        for (auto && f : parser_set_up_calls)
             f();
 
         // print Common options after developer options
@@ -424,7 +424,7 @@ class format_help_base : public format_base
         if (!meta.examples.empty())
         {
             derived_t().print_section("Examples");
-            for (auto example : meta.examples)
+            for (auto && example : meta.examples)
                 print_line(example);
         }
 

include/sharg/detail/format_html.hpp

@@ -172,7 +172,8 @@ class format_html : public format_help_base<format_html>
      */
     std::string to_html(std::string const & input)
     {
-        std::string buffer = escape_special_xml_chars(input);
+        // Todo: Input is escaped, but then not used. Same in SeqAn2. Why?
+        // std::string buffer = escape_special_xml_chars(input);
         std::string result;
         std::vector<std::string> open_tags; // acts as a stack of html tags
 

include/sharg/detail/format_man.hpp

@@ -79,7 +79,7 @@ class format_man : public format_help_base<format_man>
         std::cout << " " << meta.version << "\" \"" << meta.man_page_title << "\"\n";
 
         // Print NAME section.
-        std::cout << ".SH NAME\n" << meta.app_name << " \\- " << meta.short_description << std::endl;
+        std::cout << ".SH NAME\n" << meta.app_name << " \\- " << meta.short_description << '\n';
     }
 
     /*!\brief Prints a section title in man page format to std::cout.

include/sharg/detail/format_parse.hpp

@@ -331,7 +331,7 @@ class format_parse : public format_base
 
                 std::string result{'['};
                 for (auto const & [key, value] : key_value_pairs)
-                    result += std::string{key.data()} + ", ";
+                    result += std::string{key} + ", ";
                 result.replace(result.size() - 2, 2, "]"); // replace last ", " by "]"
                 return result;
             }();
@@ -402,11 +402,11 @@ class format_parse : public format_base
         requires std::is_arithmetic_v<option_t> && istreamable<option_t>
     option_parse_result parse_option_value(option_t & value, std::string const & in)
     {
-        auto res = std::from_chars(&in[0], &in[in.size()], value);
+        auto res = std::from_chars(in.data(), in.data() + in.size(), value);
 
         if (res.ec == std::errc::result_out_of_range)
             return option_parse_result::overflow_error;
-        else if (res.ec == std::errc::invalid_argument || res.ptr != &in[in.size()])
+        else if (res.ec == std::errc::invalid_argument || res.ptr != in.data() + in.size())
             return option_parse_result::error;
 
         return option_parse_result::success;
@@ -424,14 +424,10 @@ class format_parse : public format_base
      */
     option_parse_result parse_option_value(bool & value, std::string const & in)
     {
-        if (in == "0")
+        if (in == "0" || in == "false")
             value = false;
-        else if (in == "1")
+        else if (in == "1" || in == "true")
             value = true;
-        else if (in == "true")
-            value = true;
-        else if (in == "false")
-            value = false;
         else
             return option_parse_result::error;
 

include/sharg/detail/format_tdl.hpp

@@ -79,7 +79,7 @@ auto to_tdl(std::integral auto v)
 //!\copydetails sharg::detail::to_tdl
 auto to_tdl(std::floating_point auto v)
 {
-    return tdl::DoubleValue(v);
+    return tdl::DoubleValue(static_cast<double>(v));
 }
 
 //!\copydetails sharg::detail::to_tdl
@@ -339,7 +339,7 @@ class format_tdl : format_base
             .description = std::accumulate(begin(meta.description),
                                            end(meta.description),
                                            std::string{},
-                                           [](auto a, auto v)
+                                           [](auto const & a, auto const & v)
                                            {
                                                return a + v + '\n';
                                            }),