fix: show actual API message for 403 errors

- Update ResponseHelper to display the actual API error message for 403 responses
- Remove misleading 403->NotFoundException conversions across commands:
  - credentials (delete, update)
  - runs (delete, cancel, view)
  - computeenvs (view, delete, update)
  - studios (view, list, checkpoints, templates, stop, delete, start, add, add-as-new)
- Update tests to expect the new 403 error behavior

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Signed-off-by: Rob Syme <rob.syme@gmail.com>

Author: robsyme

src/main/java/io/seqera/tower/cli/commands/computeenvs/DeleteCmd.java

@@ -19,7 +19,6 @@
 
 import io.seqera.tower.ApiException;
 import io.seqera.tower.cli.commands.global.WorkspaceOptionalOptions;
-import io.seqera.tower.cli.exceptions.ComputeEnvNotFoundException;
 import io.seqera.tower.cli.responses.Response;
 import io.seqera.tower.cli.responses.computeenvs.ComputeEnvDeleted;
 import io.seqera.tower.model.ComputeEnvResponseDto;
@@ -50,15 +49,7 @@ protected Response exec() throws ApiException {
             id = computeEnv.getId();
         }
 
-        try {
-            computeEnvsApi().deleteComputeEnv(id, wspId);
-            return new ComputeEnvDeleted(id, workspaceRef(wspId));
-        } catch (ApiException e) {
-            if (e.getCode() == 403) {
-                // Customize the forbidden message
-                throw new ComputeEnvNotFoundException(id, workspaceRef(wspId));
-            }
-            throw e;
-        }
+        computeEnvsApi().deleteComputeEnv(id, wspId);
+        return new ComputeEnvDeleted(id, workspaceRef(wspId));
     }
 }

src/main/java/io/seqera/tower/cli/commands/computeenvs/UpdateCmd.java

@@ -19,7 +19,6 @@
 
 import io.seqera.tower.ApiException;
 import io.seqera.tower.cli.commands.global.WorkspaceOptionalOptions;
-import io.seqera.tower.cli.exceptions.ComputeEnvNotFoundException;
 import io.seqera.tower.cli.exceptions.InvalidResponseException;
 import io.seqera.tower.cli.responses.Response;
 import io.seqera.tower.cli.responses.computeenvs.ComputeEnvUpdated;
@@ -70,20 +69,7 @@ protected Response exec() throws ApiException, IOException {
 
     }
 
-    private ComputeEnvResponseDto describeCE(ComputeEnvRefOptions computeEnvRefOptions, Long wspId) throws ComputeEnvNotFoundException, ApiException {
-        try {
-            return fetchComputeEnv(computeEnvRefOptions, wspId);
-
-        } catch (ApiException e) {
-            if (e.getCode() == 403) {
-                String ref = computeEnvRefOptions.computeEnv.computeEnvId != null
-                        ? computeEnvRefOptions.computeEnv.computeEnvId
-                        : computeEnvRefOptions.computeEnv.computeEnvName;
-                // Customize the forbidden message
-                throw new ComputeEnvNotFoundException(ref, workspaceRef(wspId));
-            }
-
-            throw e;
-        }
+    private ComputeEnvResponseDto describeCE(ComputeEnvRefOptions computeEnvRefOptions, Long wspId) throws ApiException {
+        return fetchComputeEnv(computeEnvRefOptions, wspId);
     }
 }

src/main/java/io/seqera/tower/cli/commands/computeenvs/ViewCmd.java

@@ -19,7 +19,6 @@
 
 import io.seqera.tower.ApiException;
 import io.seqera.tower.cli.commands.global.WorkspaceOptionalOptions;
-import io.seqera.tower.cli.exceptions.ComputeEnvNotFoundException;
 import io.seqera.tower.cli.responses.Response;
 import io.seqera.tower.cli.responses.computeenvs.ComputeEnvView;
 import io.seqera.tower.model.ComputeEnvResponseDto;
@@ -42,19 +41,8 @@ public class ViewCmd extends AbstractComputeEnvCmd {
     protected Response exec() throws ApiException {
         Long wspId = workspaceId(workspace.workspace);
 
-        try {
-            ComputeEnvResponseDto computeEnv = fetchComputeEnv(computeEnvRefOptions, wspId);
-
-            return new ComputeEnvView(computeEnv.getId(), workspaceRef(wspId), computeEnv, baseWorkspaceUrl(wspId));
-        } catch (ApiException e) {
-            if (e.getCode() == 403) {
-                String ref = computeEnvRefOptions.computeEnv.computeEnvId != null ? computeEnvRefOptions.computeEnv.computeEnvId : computeEnvRefOptions.computeEnv.computeEnvName;
-
-                // Customize the forbidden message
-                throw new ComputeEnvNotFoundException(ref, workspaceRef(wspId));
-            }
-            throw e;
-        }
+        ComputeEnvResponseDto computeEnv = fetchComputeEnv(computeEnvRefOptions, wspId);
+        return new ComputeEnvView(computeEnv.getId(), workspaceRef(wspId), computeEnv, baseWorkspaceUrl(wspId));
     }
 
 }

src/main/java/io/seqera/tower/cli/commands/credentials/DeleteCmd.java

@@ -19,7 +19,6 @@
 
 import io.seqera.tower.ApiException;
 import io.seqera.tower.cli.commands.global.WorkspaceOptionalOptions;
-import io.seqera.tower.cli.exceptions.CredentialsNotFoundException;
 import io.seqera.tower.cli.responses.CredentialsDeleted;
 import io.seqera.tower.cli.responses.Response;
 import io.seqera.tower.model.Credentials;
@@ -50,15 +49,7 @@ protected Response exec() throws ApiException {
             id = credentials.getId();
         }
 
-        try {
-            deleteCredentialsById(id, wspId);
-            return new CredentialsDeleted(id, workspaceRef(wspId));
-        } catch (ApiException e) {
-            if (e.getCode() == 403) {
-                // Customize the forbidden message
-                throw new CredentialsNotFoundException(id, workspaceRef(wspId));
-            }
-            throw e;
-        }
+        deleteCredentialsById(id, wspId);
+        return new CredentialsDeleted(id, workspaceRef(wspId));
     }
 }

src/main/java/io/seqera/tower/cli/commands/credentials/update/AbstractUpdateCmd.java

@@ -22,7 +22,6 @@
 import io.seqera.tower.cli.commands.credentials.CredentialsRefOptions;
 import io.seqera.tower.cli.commands.credentials.providers.CredentialsProvider;
 import io.seqera.tower.cli.commands.global.WorkspaceOptionalOptions;
-import io.seqera.tower.cli.exceptions.CredentialsNotFoundException;
 import io.seqera.tower.cli.responses.CredentialsUpdated;
 import io.seqera.tower.cli.responses.Response;
 import io.seqera.tower.model.Credentials;
@@ -48,20 +47,8 @@ public AbstractUpdateCmd() {
     protected Response exec() throws ApiException, IOException {
         Long wspId = workspaceId(workspace.workspace);
 
-        // Check that exists
-        try {
-//            DescribeCredentialsResponse response = api().describeCredentials(credentials, wspId);
-            Credentials credentials = fetchCredentials(credentialsRefOptions, wspId);
-            return update(credentials, wspId);
-        } catch (ApiException e) {
-            if (e.getCode() == 403) {
-                String ref = credentialsRefOptions.credentialsRef.credentialsId != null ? credentialsRefOptions.credentialsRef.credentialsId : credentialsRefOptions.credentialsRef.credentialsName;
-
-                // Customize the forbidden message
-                throw new CredentialsNotFoundException(ref, workspaceRef(wspId));
-            }
-            throw e;
-        }
+        Credentials credentials = fetchCredentials(credentialsRefOptions, wspId);
+        return update(credentials, wspId);
     }
 
     protected Response update(Credentials creds, Long wspId) throws ApiException, IOException {

src/main/java/io/seqera/tower/cli/commands/runs/CancelCmd.java

@@ -19,7 +19,6 @@
 
 import io.seqera.tower.ApiException;
 import io.seqera.tower.cli.commands.global.WorkspaceOptionalOptions;
-import io.seqera.tower.cli.exceptions.RunNotFoundException;
 import io.seqera.tower.cli.responses.Response;
 import io.seqera.tower.cli.responses.runs.RunCanceled;
 import picocli.CommandLine;
@@ -42,15 +41,7 @@ public class CancelCmd extends AbstractRunsCmd {
     protected Response exec() throws ApiException, IOException {
         Long wspId = workspaceId(workspace.workspace);
 
-        try {
-            workflowsApi().cancelWorkflow(id, wspId, null, null);
-
-            return new RunCanceled(id, workspaceRef(wspId));
-        } catch (ApiException e) {
-            if (e.getCode() == 403) {
-                throw new RunNotFoundException(id, workspaceRef(wspId));
-            }
-            throw e;
-        }
+        workflowsApi().cancelWorkflow(id, wspId, null, null);
+        return new RunCanceled(id, workspaceRef(wspId));
     }
 }

src/main/java/io/seqera/tower/cli/commands/runs/DeleteCmd.java

@@ -19,7 +19,6 @@
 
 import io.seqera.tower.ApiException;
 import io.seqera.tower.cli.commands.global.WorkspaceOptionalOptions;
-import io.seqera.tower.cli.exceptions.RunNotFoundException;
 import io.seqera.tower.cli.responses.Response;
 import io.seqera.tower.cli.responses.runs.RunDeleted;
 import picocli.CommandLine;
@@ -45,15 +44,7 @@ public class DeleteCmd extends AbstractRunsCmd {
     protected Response exec() throws ApiException, IOException {
         Long wspId = workspaceId(workspace.workspace);
 
-        try {
-            workflowsApi().deleteWorkflow(id, wspId, force);
-
-            return new RunDeleted(id, workspaceRef(wspId));
-        } catch (ApiException e) {
-            if (e.getCode() == 403) {
-                throw new RunNotFoundException(id, workspaceRef(wspId));
-            }
-            throw e;
-        }
+        workflowsApi().deleteWorkflow(id, wspId, force);
+        return new RunDeleted(id, workspaceRef(wspId));
     }
 }