Skip to content

Improving our review process #33

@ephys

Description

@ephys

Just opening a thread to let you know that I'm currently working on our review process.

My main goal is to be able to use filter is:open is:pr review-requested:@me sort:created-asc -is:draft -author:@me -status:failure as a definitive work list

### Progress
- [x] Force all branch names to follow the `<author>/<description>` scheme, as this helps figuring out who the owner of a branch is
- [x] Replace our branch protections with rulesets, so we can allow renovate to bypass the reviewer requirement (but _only_ the reviewer requirement). Removed renovate-approve. See https://github.com/sequelize/sequelize/pull/17094
- [ ] https://github.com/sequelize/sequelize/pull/17096
- [x] Create the @sequelize/code-reviewers team, to automatically assign the members of the team as new reviewers
- [ ] https://github.com/sequelize/sequelize/pull/17095
- [x] Disable merge groups, as it's currently causing more headache than not having it.
- [ ] https://github.com/sequelize/sequelize/pull/17097
- [ ] The first time a PR is put in draft, or has merge conflicts, have a bot print a message explaining that the PR won't appear in the list of reviewable PRs until these issues are fixed, but that the maintainers can still be pinged if help is required.
- [ ] After the first "change request" of a PR, have a bot post a message saying to request a re-review from the user after implementing the changes

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions