Remove dialect canAliasPK check for generating fieldnames. (#571)

This was a workaround to a sequelize bug that has been fixed.

Author: steveschmitt

src/auto-generator.ts

@@ -426,11 +426,7 @@ export class AutoGenerator {
     }
 
     if (field !== fieldName) {
-      // write the original fieldname, unless it is a key and the column names are case-insensitive
-      // because Sequelize may request the same column twice in a join condition otherwise.
-      if (!fieldObj.primaryKey || this.dialect.canAliasPK || field.toUpperCase() !== fieldName.toUpperCase()) {
-        str += space[3] + "field: '" + field + "',\n";
-      }
+      str += space[3] + "field: '" + field + "',\n";
     }
 
     // removes the last `,` within the attribute options

src/dialects/dialect-options.ts

@@ -4,8 +4,7 @@ import { Utils } from "sequelize";
 export interface DialectOptions {
   name: string;
   hasSchema: boolean;
-  /** whether to write the db field name for primaryKey fields ('id').  Can cause errors in some dialects because field name is included twice in queries. */
-  canAliasPK: boolean;
+  
   getForeignKeysQuery: (tableName: string, schemaName: string) => string;
   remapForeignKeysRow?: (tableName: string, row: FKRow) => FKRelation;
   countTriggerQuery: (tableName: string, schemaName: string) => string;

src/dialects/mssql.ts

@@ -4,7 +4,6 @@ import { addTicks, DialectOptions, FKRow, makeCondition } from "./dialect-option
 export const mssqlOptions: DialectOptions = {
   name: 'mssql',
   hasSchema: true,
-  canAliasPK: false,
   /**
    * Generates an SQL query that returns all foreign keys of a table.
    *

src/dialects/mysql.ts

@@ -4,7 +4,6 @@ import { addTicks, DialectOptions, FKRow, makeCondition } from "./dialect-option
 export const mysqlOptions: DialectOptions = {
   name: 'mysql',
   hasSchema: false,
-  canAliasPK: false,
   /**
    * Generates an SQL query that returns all foreign keys of a table.
    *

src/dialects/postgres.ts

@@ -4,7 +4,6 @@ import { addTicks, DialectOptions, FKRow, makeCondition } from "./dialect-option
 export const postgresOptions: DialectOptions = {
   name: 'postgres',
   hasSchema: true,
-  canAliasPK: true,
   /**
    * Generates an SQL query that returns all foreign keys of a table.
    *

src/dialects/sqlite.ts

@@ -4,7 +4,6 @@ import { addTicks, DialectOptions, FKRow } from "./dialect-options";
 export const sqliteOptions: DialectOptions = {
   name: 'sqlite',
   hasSchema: false,
-  canAliasPK: true,
   /**
    * Generates an SQL query that returns all foreign keys of a table.
    *