fix: correctly defaults configuration options (#50)

Author: sushantdhiman

package.json

@@ -40,7 +40,7 @@
     "build": "tsc",
     "test": "npm run lint && npm run test:raw",
     "lint": "eslint --ext .js,.ts src/**/* test/**/*",
-    "pretty": "prettier src/**/*.ts test/**/*.js --write",
+    "pretty": "prettier src test --write",
     "docs": "typedoc",
     "test:raw": "tap test/**/*-test.js"
   },

src/Pool.ts

@@ -1,5 +1,6 @@
 import { Deferred } from './Deferred';
 import { AggregateError } from './AggregateError';
+import { defaultTo } from './helpers/defaultTo';
 
 export type LogLevel = 'verbose' | 'info' | 'error';
 export type FactoryLogger = (message: string, level: LogLevel) => void;
@@ -164,11 +165,11 @@ export class Pool<RawResource> {
     }
 
     // defaults
-    this.idleTimeoutMillis = factory.idleTimeoutMillis || 30000;
-    this.acquireTimeoutMillis = factory.acquireTimeoutMillis || 30000;
-    this.reapIntervalMillis = factory.reapIntervalMillis || 1000;
-    this.maxUsesPerResource = factory.maxUses || Infinity;
-    this.log = factory.log || false;
+    this.idleTimeoutMillis = defaultTo(factory.idleTimeoutMillis, 30000);
+    this.acquireTimeoutMillis = defaultTo(factory.acquireTimeoutMillis, 30000);
+    this.reapIntervalMillis = defaultTo(factory.reapIntervalMillis, 1000);
+    this.maxUsesPerResource = defaultTo(factory.maxUses, Infinity);
+    this.log = defaultTo(factory.log, false);
 
     this._factory = factory;
     this._count = 0;

src/helpers/defaultTo.ts

@@ -0,0 +1,3 @@
+export function defaultTo<T>(value: T | null | undefined, defaultValue: T): T {
+  return value == null || value !== value ? defaultValue : value;
+}

test/integration/config-test.js

@@ -61,3 +61,25 @@ tap.test('fail without factory.validate', (t) => {
   }, 'validate function is required');
   t.end();
 });
+
+tap.test('correctly defaults', (t) => {
+  const factory = {
+    name: 'test-config-defaults',
+    create: () => {},
+    destroy: () => {},
+    validate: () => true,
+    max: 1,
+    min: 0,
+    idleTimeoutMillis: 0,
+    acquireTimeoutMillis: undefined,
+    reapIntervalMillis: null,
+  };
+
+  const pool = new Pool(factory);
+
+  t.equal(pool.idleTimeoutMillis, 0);
+  t.equal(pool.acquireTimeoutMillis, 30000);
+  t.equal(pool.reapIntervalMillis, 1000);
+
+  t.end();
+});