fix: acquire not resolving after destroying available resources (#44)

Author: kurayama

src/Pool.ts

@@ -538,6 +538,14 @@ export class Pool<RawResource> {
       await this._factory.destroy(resource);
     } finally {
       this._ensureMinimum();
+      // Since we are removing the resource, we need to go ahead and
+      // call _dispense() in order to ensure the resource is replaced (if appropriate)
+      // and any pending resource requests are fulfilled.
+      if (!this._draining) {
+        process.nextTick(() => {
+          this._dispense();
+        });
+      }
     }
   }
 

test/integration/pool-test.js

@@ -598,3 +598,29 @@ tap.test('pool does not leak expired resources to pending requests', (t) => {
     pool.release(clientA);
   });
 });
+
+tap.test('acquire resolves after destroying the available resources', (t) => {
+  const resourceFactory = new ResourceFactory();
+
+  const factory = {
+    name: 'test22',
+    create: resourceFactory.create.bind(resourceFactory),
+    destroy: resourceFactory.destroy.bind(resourceFactory),
+    validate: resourceFactory.validate.bind(resourceFactory),
+    max: 1,
+    min: 0,
+    idleTimeoutMillis: 100,
+    acquireTimeoutMillis: 100,
+  };
+
+  const pool = new Pool(factory);
+
+  pool.acquire().then((resource1) => {
+    pool.acquire().then((resource2) => {
+      pool.release(resource2);
+
+      t.end();
+    });
+    pool.destroy(resource1);
+  });
+});