test lower node versions properly (#661)

previous CI setup wasn't actually running, it was throwing an uncaught
rejection and somehow exiting with code 0 anyway

getting vitest to work on node 12 was miles away from working, so moving
the node version tests to the `test_tgz` job, which is a simpler test
that ensures the basics work.

Also adds some small fixes to the library itself to get it _closer_ to
working, but the `glob` dependency is the sticking point for node 12.
14, 16, 18 are now fine.

`glob` dependency will be replaced in #660 

If getting node 12 to work proves impossible, we might need to just go
to a v4 release but hopefully not.

Author: mmkal

.github/workflows/ci.yml

@@ -7,26 +7,11 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - run: corepack enable
-    # rather than use strategy.matrix, install once and run multiple times. Some of the devDependencies refuse to install on lower node versions, but we still want to test on them
     - run: pnpm install
     - run: pnpm lint
     - run: pnpm test -- --coverage
     - name: Coverage
       uses: codecov/codecov-action@v3
-    - name: Setup node 14
-      uses: actions/setup-node@v4
-      with:
-        node-version: 14.x
-    - run: npm test
-
-    # pretest depends on del-cli which doesn't support node 12, so run manually
-    # todo: drop node 12 in next major
-    - run: npm run pretest
-    - name: Setup node 12
-      uses: actions/setup-node@v4
-      with:
-        node-version: 12.x
-    - run: npm test --ignore-scripts
   create_tgz:
     runs-on: ubuntu-latest
     steps:
@@ -44,7 +29,13 @@ jobs:
   test_tgz:
     runs-on: ubuntu-latest
     needs: [create_tgz]
+    strategy:
+      matrix:
+        node: [20, 18, 16, 14, 12]
     steps:
+      - uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node }}
       - uses: actions/checkout@v4
       - uses: actions/download-artifact@v3
         with:

eslint.config.js

@@ -1,4 +1,11 @@
 module.exports = [
   ...require('eslint-plugin-mmkal').recommendedFlatConfigs,
   {ignores: ['lib/**', 'examples/**', 'test/generated/**']}, //
+  {
+    rules: {
+      // todo[>=4.0.0] drop lower node version support and remove these
+      'unicorn/prefer-string-replace-all': 'off',
+      'unicorn/prefer-at': 'off',
+    },
+  },
 ]

package.json

@@ -29,7 +29,6 @@
 		"@vitest/coverage-v8": "^0.34.6",
 		"@vitest/ui": "^0.34.6",
 		"del": "^5.0.0",
-		"del-cli": "5.1.0",
 		"eslint": "8.57.0",
 		"eslint-plugin-mmkal": "0.5.1",
 		"execa": "^5.1.1",
@@ -49,13 +48,13 @@
 		"vitest": "^0.34.6"
 	},
 	"scripts": {
-		"clean": "del-cli lib",
+		"clean": "rm -rf lib",
 		"compile": "tsc -p tsconfig.lib.json",
 		"build": "pnpm clean && pnpm compile",
 		"eslint": "eslint . --max-warnings 0",
 		"lint": "pnpm type-check && pnpm eslint",
 		"prepare": "pnpm build",
-		"pretest": "del-cli test/generated",
+		"pretest": "rm -rf test/generated",
 		"test": "vitest run",
 		"type-check": "tsc -p ."
 	},