runAsCLI doesn't seem to exit

[cesarvarela]

Hi, I need to add the following to have umzug finish the process when running from the cli. Otherwise, it keeps running, and the command never completes.

if (require.main === module) {
    umzug.runAsCLI().finally(process.exit);
}

Is this necessary, or am I missing something?

[mmkal]

That isn’t supposed to happen (and doesn’t for me). Do you have a minimal repro?

[imack]

I have same issue. Thanks @cesarvarela for showing at least how to exit it. I think I'm using a pretty standard version of umzug. Sequelize 4 though.

[jgonera]

Happening for me too. I'm pretty much using a modified raw SQL example with mysql2 instead of sequelize. My project uses TypeScript (strict) with ESM.

import { readFileSync } from 'node:fs'
import { basename, dirname, join } from 'node:path'
import { fileURLToPath } from 'node:url'

import mysql, { type Pool, type RowDataPacket } from 'mysql2/promise'
import { Umzug } from 'umzug'

function getMigrator({
  migrationsPath,
  pool
}: {
  migrationsPath: string
  pool: Pool
}): Umzug<Pool> {
  return new Umzug({
    migrations: {
      glob: join(migrationsPath, '*.sql'),
      resolve(params) {
        if (params.path === undefined) {
          throw new Error('Missing migration path!')
        }

        const upPath = params.path

        const downPath = join(
          dirname(params.path),
          'down',
          basename(params.path)
        )

        return {
          name: params.name,
          path: params.path,
          up: async () =>
            await params.context.query(readFileSync(upPath).toString()),
          down: async () =>
            await params.context.query(readFileSync(downPath).toString())
        }
      }
    },
    context: pool,
    storage: {
      async executed({ context: client }) {
        await client.query(
          `create table if not exists schema_migrations(name text)`
        )

        const [rows] = await client.query<RowDataPacket[]>(
          `select name from schema_migrations`
        )

        return rows.map((r) => r['name'])
      },

      async logMigration({ name, context: client }) {
        await client.query(`insert into schema_migrations(name) values (?)`, [
          name
        ])
      },

      async unlogMigration({ name, context: client }) {
        await client.query(`delete from schema_migrations where name = ?`, [
          name
        ])
      }
    },
    logger: console,
    create: {
      folder: migrationsPath
    }
  })
}

const pool = mysql.createPool({
  database: 'test',
  host: '127.0.0.1',
  password: '',
  user: 'root'
})

const migrator = getMigrator({
  migrationsPath: join(
    dirname(fileURLToPath(import.meta.url)),
    '..',
    '..',
    'src',
    'db',
    'migrations'
  ),
  pool
})

// Also tried `void` instead of `await`
await migrator.runAsCLI()

[louwers]

For me it exits before it's complete!

Edit: nevermind, forgot to call .connect(). Good morning.