Skip to content

Commit 2e33b2c

Browse files
committed
simplify
1 parent e473ff5 commit 2e33b2c

File tree

2 files changed

+6
-19
lines changed

2 files changed

+6
-19
lines changed

lib/sequin/transforms/minielixir.ex

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -243,19 +243,12 @@ defmodule Sequin.Transforms.MiniElixir do
243243
defp format_error(id, error, stacktrace) do
244244
msg = Exception.message(error)
245245

246-
id
247-
|> try_extract_linenum(stacktrace)
248-
|> Enum.map_join(",", fn {k, v} -> "#{k}: #{v}" end)
249-
|> case do
250-
"" -> msg
251-
ds -> "#{msg} (#{ds})"
252-
end
253-
end
254-
255-
defp try_extract_linenum(id, stacktrace) do
256246
with {:ok, mod} <- module_name_from_id(id),
257-
[info | _] <- for({^mod, _f, _a, info} <- stacktrace, do: info) do
258-
Keyword.delete(info, :file)
247+
[info | _] <- for({^mod, _f, _a, info} <- stacktrace, do: info),
248+
line when is_integer(line) <- info[:line] do
249+
"#{msg} (line: #{line})"
250+
else
251+
_ -> msg
259252
end
260253
end
261254
end

lib/sequin/transforms/minielixir/validator.ex

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,12 @@ defmodule Sequin.Transforms.MiniElixir.Validator do
2828
# this is important to propagate the stacktrace
2929
rescue
3030
ex ->
31-
reraise ex, unquote(__MODULE__).format_stacktrace(__MODULE__, __STACKTRACE__)
31+
reraise ex, __STACKTRACE__
3232
end
3333
end
3434
end
3535
end
3636

37-
def format_stacktrace(myself, stk) do
38-
for {^myself, _f, _a, _info} = ste <- stk do
39-
ste
40-
end
41-
end
42-
4337
def unwrap({:def, _, [{fnname, _, params}, [{:do, body}]]}) do
4438
with :ok <- unwrap_fnname(fnname),
4539
:ok <- unwrap_params(params) do

0 commit comments

Comments
 (0)