Conversation
dosubot
bot
added
the
size:M
acco
changed the title
We let you set a max memory for Sequin (defaults to ~80% of avail memory) or for individual slot message stores. Prior behavior was to do min( max_memory/count_sms , sms_max ). This change removes that - we'll let an SMS fill up to his max, so long as the system can support it.
acco
force-pushed
the
acco/05-12-don_t_factor_in_system_max_memory_in_individual_sms_sizes
branch
from
8f0efea to
d0ad929
Compare
acco
deleted the
acco/05-12-don_t_factor_in_system_max_memory_in_individual_sms_sizes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We let you set a max memory for Sequin (defaults to ~80% of avail memory) or for individual slot message stores.
Prior behavior was to do min( max_memory/count_sms , sms_max ). This change removes that - we'll let an SMS fill up to his max, so long as the system can support it.