Skip to content

Commit 9a75f92

Browse files
committed
Thoroughly update versions and methodology
For hash-pinned dependencies, adds comments documenting the associated versions. Adds a pin to `slither-analyzer` which was prior missing. Updates to Monero 0.18.4.4. `mimalloc` now has the correct option set when building for `musl`. A C++ compiler is no longer required in its Docker image. The runtime's `Dockerfile` now symlinks a `libc.so` already present on the image instead of creating one itself. It also builds the runtime within the image to ensure it only happens once. The test to ensure the methodology is reproducible has been updated to not simply create containers from the image, yet rebuild the image entirely, accordingly. This also is more robust and arguably should have already been done. The pin to the exact hash of the `patch-polkadot-sdk` repo in every `Cargo.toml` has been removed. The lockfile already serves that role, simplifying updating in the future. The latest Rust nightly is adopted as well (superseding #697). The `librocksdb-sys` patch is replaced with a `kvdb-rocksdb` patch, removing a git dependency, thanks to paritytech/parity-common#950.
1 parent 30ea9d9 commit 9a75f92

File tree

59 files changed

+527
-557
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+527
-557
lines changed

.github/actions/bitcoin/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ runs:
1212
steps:
1313
- name: Bitcoin Daemon Cache
1414
id: cache-bitcoind
15-
uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809
15+
uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809 # 4.2.4
1616
with:
1717
path: bitcoin.tar.gz
1818
key: bitcoind-${{ runner.os }}-${{ runner.arch }}-${{ inputs.version }}

.github/actions/build-dependencies/action.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ runs:
5252
- name: Install solc
5353
shell: bash
5454
run: |
55-
cargo +1.91 install svm-rs --version =0.5.19
55+
cargo +1.91.1 install svm-rs --version =0.5.21
5656
svm install 0.8.29
5757
svm use 0.8.29
5858
@@ -75,11 +75,8 @@ runs:
7575
if: runner.os == 'Linux'
7676

7777
- name: Install rootless Docker
78-
uses: docker/setup-docker-action@b60f85385d03ac8acfca6d9996982511d8620a19
78+
uses: docker/setup-docker-action@e61617a16c407a86262fb923c35a616ddbe070b3 # 4.6.0
7979
with:
8080
rootless: true
8181
set-host: true
8282
if: runner.os == 'Linux'
83-
84-
# - name: Cache Rust
85-
# uses: Swatinem/rust-cache@a95ba195448af2da9b00fb742d14ffaaf3c21f43

.github/actions/monero-wallet-rpc/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@ inputs:
55
version:
66
description: "Version to download and run"
77
required: false
8-
default: v0.18.4.3
8+
default: v0.18.4.4
99

1010
runs:
1111
using: "composite"
1212
steps:
1313
- name: Monero Wallet RPC Cache
1414
id: cache-monero-wallet-rpc
15-
uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809
15+
uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809 # 4.2.4
1616
with:
1717
path: monero-wallet-rpc
1818
key: monero-wallet-rpc-${{ runner.os }}-${{ runner.arch }}-${{ inputs.version }}

.github/actions/monero/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@ inputs:
55
version:
66
description: "Version to download and run"
77
required: false
8-
default: v0.18.4.3
8+
default: v0.18.4.4
99

1010
runs:
1111
using: "composite"
1212
steps:
1313
- name: Monero Daemon Cache
1414
id: cache-monerod
15-
uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809
15+
uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809 # 4.2.4
1616
with:
1717
path: /usr/bin/monerod
1818
key: monerod-${{ runner.os }}-${{ runner.arch }}-${{ inputs.version }}

.github/actions/test-dependencies/action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ inputs:
55
monero-version:
66
description: "Monero version to download and run as a regtest node"
77
required: false
8-
default: v0.18.4.3
8+
default: v0.18.4.4
99

1010
bitcoin-version:
1111
description: "Bitcoin version to download and run as a regtest node"
@@ -19,9 +19,9 @@ runs:
1919
uses: ./.github/actions/build-dependencies
2020

2121
- name: Install Foundry
22-
uses: foundry-rs/foundry-toolchain@8f1998e9878d786675189ef566a2e4bf24869773
22+
uses: foundry-rs/foundry-toolchain@50d5a8956f2e319df19e6b57539d7e2acb9f8c1e # 1.5.0
2323
with:
24-
version: nightly-f625d0fa7c51e65b4bf1e8f7931cd1c6e2e285e9
24+
version: v1.5.0
2525
cache: false
2626

2727
- name: Run a Monero Regtest Node

.github/nightly-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
nightly-2025-11-11
1+
nightly-2025-12-01

.github/workflows/common-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
test-common:
1818
runs-on: ubuntu-latest
1919
steps:
20-
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
20+
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # 6.0.0
2121

2222
- name: Build Dependencies
2323
uses: ./.github/actions/build-dependencies

.github/workflows/coordinator-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
build:
3232
runs-on: ubuntu-latest
3333
steps:
34-
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
34+
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # 6.0.0
3535

3636
- name: Install Build Dependencies
3737
uses: ./.github/actions/build-dependencies

.github/workflows/crypto-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
test-crypto:
2020
runs-on: ubuntu-latest
2121
steps:
22-
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
22+
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # 6.0.0
2323

2424
- name: Build Dependencies
2525
uses: ./.github/actions/build-dependencies

.github/workflows/daily-deny.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,10 @@ jobs:
99
name: Run cargo deny
1010
runs-on: ubuntu-latest
1111
steps:
12-
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
13-
14-
- name: Advisory Cache
15-
uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809
16-
with:
17-
path: ~/.cargo/advisory-db
18-
key: rust-advisory-db
12+
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # 6.0.0
1913

2014
- name: Install cargo deny
21-
run: cargo +1.91 install cargo-deny --version =0.18.5
15+
run: cargo +1.91.1 install cargo-deny --version =0.18.6
2216

2317
- name: Run cargo deny
2418
run: cargo deny -L error --all-features check --hide-inclusion-graph

0 commit comments

Comments
 (0)