Skip to content

Implement FromStr for Map<String, Value> #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

Implement FromStr for Map<String, Value> #1271

merged 1 commit into from
Aug 19, 2025

Conversation

mickvangelderen
Copy link
Contributor

My use case is to enable:

    #[cfg_attr(feature = "clap", arg(long))] // <- clap requires one of From<OsString>, ... , FromStr
    #[cfg_attr(feature = "serde", serde(default))]
    pub whatever: Option<serde_json::Map<String, serde_json::Value>>,

I could write a value_parser for clap:

fn parse_json_object(s: &str) -> Result< serde_json::Map<String, serde_json::Value>, String> {
    serde_json::from_str(s).map_err(|error| error.to_string())
}

But that probably isn't doing the best job with respect to error formatting.

dtolnay
dtolnay approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

dtolnay
dtolnay reviewed Aug 19, 2025
View reviewed changes
src/value/de.rs
Comment on lines 274 to +275


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@dtolnay dtolnay merged commit 447170b into serde-rs:master Aug 19, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickvangelderen @dtolnay