Bump Verify.SourceGenerators from 2.2.0 to 2.5.0 (#304)

- [x] Investigate CI build failures (17 snapshot mismatches in
Serde.Generation.Test)
- [x] Understand the snapshot format change in Verify.SourceGenerators
2.5.0 (diagnostic format now includes source context in Location and
nested Descriptor object)
- [x] Run tests locally to generate new snapshots
- [x] Update all 17 failing verified snapshot files
- [x] Validate all 155 tests pass (77 generation + 78 serde)
- [x] Run final validation (code review and CodeQL both passed)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: agocke <515774+agocke@users.noreply.github.com>
Co-authored-by: Andy Gocke <andy@commentout.net>

Author: 3 people

Directory.Packages.props

@@ -18,7 +18,7 @@
     <PackageVersion Include="System.Net.Http" Version="4.3.4" />
     <PackageVersion Include="System.Security.Cryptography.X509Certificates" Version="4.3.2" />
     <PackageVersion Include="PolyKit.Embedded" Version="3.0.9" />
-    <PackageVersion Include="Verify.SourceGenerators" Version="2.2.0" />
+    <PackageVersion Include="Verify.SourceGenerators" Version="2.5.0" />
     <PackageVersion Include="Verify.XunitV3" Version="31.15.0" />
     <PackageVersion Include="xunit.v3" Version="3.2.2" />
   </ItemGroup>

test/Serde.Generation.Test/test_output/DeserializeTests.AbstractClass/target.verified.txt

@@ -1,24 +1,32 @@
 {
   Diagnostics: [
     {
-      Id: ERR_CantImplementAbstract,
-      Title: ,
-      Severity: Error,
-      WarningLevel: 0,
-      Location: : (3,23)-(3,27),
-      MessageFormat:
+      Location: /*
+[GenerateDeserialize]
+abstract partial class Base { }
+                       ^^^^
+*/
+ : (3,23)-(3,27),
+      Message:
 Can't generate serialize or deserialize implementations for 'Base' because it is abstract but is not a discriminated union. Implementations can only be generated for abstract types if they are discriminated unions. Discriminated unions are:
 - Abstract
 - Records
 - With only private constructors
 - With one or more nested records that inherit from the parent record,
-      Message:
+      Severity: Error,
+      Descriptor: {
+        Id: ERR_CantImplementAbstract,
+        Title: ,
+        MessageFormat:
 Can't generate serialize or deserialize implementations for 'Base' because it is abstract but is not a discriminated union. Implementations can only be generated for abstract types if they are discriminated unions. Discriminated unions are:
 - Abstract
 - Records
 - With only private constructors
 - With one or more nested records that inherit from the parent record,
-      Category: Serde
+        Category: Serde,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }

test/Serde.Generation.Test/test_output/DeserializeTests.AbstractRecordPublicCtor/target.verified.txt

@@ -1,24 +1,32 @@
 {
   Diagnostics: [
     {
-      Id: ERR_CantImplementAbstract,
-      Title: ,
-      Severity: Error,
-      WarningLevel: 0,
-      Location: : (3,24)-(3,28),
-      MessageFormat:
+      Location: /*
+[GenerateDeserialize]
+abstract partial record Base { }
+                        ^^^^
+*/
+ : (3,24)-(3,28),
+      Message:
 Can't generate serialize or deserialize implementations for 'Base' because it is abstract but is not a discriminated union. Implementations can only be generated for abstract types if they are discriminated unions. Discriminated unions are:
 - Abstract
 - Records
 - With only private constructors
 - With one or more nested records that inherit from the parent record,
-      Message:
+      Severity: Error,
+      Descriptor: {
+        Id: ERR_CantImplementAbstract,
+        Title: ,
+        MessageFormat:
 Can't generate serialize or deserialize implementations for 'Base' because it is abstract but is not a discriminated union. Implementations can only be generated for abstract types if they are discriminated unions. Discriminated unions are:
 - Abstract
 - Records
 - With only private constructors
 - With one or more nested records that inherit from the parent record,
-      Category: Serde
+        Category: Serde,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }

test/Serde.Generation.Test/test_output/DeserializeTests/EmptyDU.verified.txt

@@ -1,24 +1,33 @@
 {
   Diagnostics: [
     {
-      Id: ERR_CantImplementAbstract,
-      Title: ,
-      Severity: Error,
-      WarningLevel: 0,
-      Location: : (3,24)-(3,28),
-      MessageFormat:
+      Location: /*
+[GenerateDeserialize]
+abstract partial record Base
+                        ^^^^
+{
+*/
+ : (3,24)-(3,28),
+      Message:
 Can't generate serialize or deserialize implementations for 'Base' because it is abstract but is not a discriminated union. Implementations can only be generated for abstract types if they are discriminated unions. Discriminated unions are:
 - Abstract
 - Records
 - With only private constructors
 - With one or more nested records that inherit from the parent record,
-      Message:
+      Severity: Error,
+      Descriptor: {
+        Id: ERR_CantImplementAbstract,
+        Title: ,
+        MessageFormat:
 Can't generate serialize or deserialize implementations for 'Base' because it is abstract but is not a discriminated union. Implementations can only be generated for abstract types if they are discriminated unions. Discriminated unions are:
 - Abstract
 - Records
 - With only private constructors
 - With one or more nested records that inherit from the parent record,
-      Category: Serde
+        Category: Serde,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }

test/Serde.Generation.Test/test_output/DeserializeTests/NoParameterlessOrPrimaryCtor.verified.txt

@@ -1,14 +1,23 @@
 {
   Diagnostics: [
     {
-      Id: ERR_MissingPrimaryCtor,
-      Title: ,
-      Severity: Error,
-      WarningLevel: 0,
-      Location: : (2,14)-(2,15),
-      MessageFormat: Type must have either a primary constructor or a parameterless constructor.,
+      Location: /*
+[GenerateDeserialize]
+partial class C
+              ^
+{
+*/
+ : (2,14)-(2,15),
       Message: Type must have either a primary constructor or a parameterless constructor.,
-      Category: Serde
+      Severity: Error,
+      Descriptor: {
+        Id: ERR_MissingPrimaryCtor,
+        Title: ,
+        MessageFormat: Type must have either a primary constructor or a parameterless constructor.,
+        Category: Serde,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }

test/Serde.Generation.Test/test_output/ProxyTests.ExplicitInvalidGenericWrapper/target.verified.txt

@@ -1,14 +1,23 @@
 {
   Diagnostics: [
     {
-      Id: ERR_WrapperDoesntImplementInterface,
-      Title: ,
-      Severity: Error,
-      WarningLevel: 0,
-      Location: : (37,21)-(37,27),
-      MessageFormat: The proxy type 'Proxy' doesn't implement the interface 'IDeserializeProvider<Original?>'.,
+      Location: /*
+    [SerdeMemberOptions(DeserializeProxy = typeof(Proxy))]
+    public Original? SdkDir { get; init; } = null;
+                     ^^^^^^
+}
+*/
+ : (37,21)-(37,27),
       Message: The proxy type 'Proxy' doesn't implement the interface 'IDeserializeProvider<Original?>'.,
-      Category: Serde
+      Severity: Error,
+      Descriptor: {
+        Id: ERR_WrapperDoesntImplementInterface,
+        Title: ,
+        MessageFormat: The proxy type 'Proxy' doesn't implement the interface 'IDeserializeProvider<Original?>'.,
+        Category: Serde,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }

test/Serde.Generation.Test/test_output/ProxyTests.InvalidNestedWrapper/target.verified.txt

@@ -1,14 +1,23 @@
 {
   Diagnostics: [
     {
-      Id: ERR_WrapperDoesntImplementInterface,
-      Title: ,
-      Severity: Error,
-      WarningLevel: 0,
-      Location: : (16,21)-(16,29),
-      MessageFormat: The proxy type 'Serde.ArrayProxy.Ser<System.Collections.Specialized.BitVector32.Section, Outer.SectionWrap>' doesn't implement the interface 'ISerializeProvider<System.Collections.Generic.List<int>>'.,
+      Location: /*
+        SerializeProxy = typeof(ArrayProxy.Ser<BitVector32.Section, Outer.SectionWrap>))]
+    public List<int> Sections;
+                     ^^^^^^^^
+}
+*/
+ : (16,21)-(16,29),
       Message: The proxy type 'Serde.ArrayProxy.Ser<System.Collections.Specialized.BitVector32.Section, Outer.SectionWrap>' doesn't implement the interface 'ISerializeProvider<System.Collections.Generic.List<int>>'.,
-      Category: Serde
+      Severity: Error,
+      Descriptor: {
+        Id: ERR_WrapperDoesntImplementInterface,
+        Title: ,
+        MessageFormat: The proxy type 'Serde.ArrayProxy.Ser<System.Collections.Specialized.BitVector32.Section, Outer.SectionWrap>' doesn't implement the interface 'ISerializeProvider<System.Collections.Generic.List<int>>'.,
+        Category: Serde,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }

test/Serde.Generation.Test/test_output/ProxyTests.RecordStringWrap/target.verified.txt

@@ -1,14 +1,23 @@
 {
   Diagnostics: [
     {
-      Id: ERR_CantWrapSpecialType,
-      Title: ,
-      Severity: Error,
-      WarningLevel: 0,
-      Location: : (2,1)-(2,40),
-      MessageFormat: The type 'string' can't be automatically wrapped because it is a built-in type.,
+      Location: /*
+using Serde;
+[GenerateSerde(ForType = typeof(string))]
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+partial record struct StringWrap(string Wrapped);
+*/
+ : (2,1)-(2,40),
       Message: The type 'string' can't be automatically wrapped because it is a built-in type.,
-      Category: Serde
+      Severity: Error,
+      Descriptor: {
+        Id: ERR_CantWrapSpecialType,
+        Title: ,
+        MessageFormat: The type 'string' can't be automatically wrapped because it is a built-in type.,
+        Category: Serde,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }

test/Serde.Generation.Test/test_output/ProxyTests.StringWrap/target.verified.txt

@@ -1,14 +1,23 @@
 {
   Diagnostics: [
     {
-      Id: ERR_CantWrapSpecialType,
-      Title: ,
-      Severity: Error,
-      WarningLevel: 0,
-      Location: : (2,1)-(2,40),
-      MessageFormat: The type 'string' can't be automatically wrapped because it is a built-in type.,
+      Location: /*
+using Serde;
+[GenerateSerde(ForType = typeof(string))]
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+readonly partial struct StringWrap
+*/
+ : (2,1)-(2,40),
       Message: The type 'string' can't be automatically wrapped because it is a built-in type.,
-      Category: Serde
+      Severity: Error,
+      Descriptor: {
+        Id: ERR_CantWrapSpecialType,
+        Title: ,
+        MessageFormat: The type 'string' can't be automatically wrapped because it is a built-in type.,
+        Category: Serde,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }