Small readability improvement for Target assertions. #3680
john-phillips-uspto
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
When using net.serenitybdd.screenplay.ensure.Ensure to test the state of a net.serenitybdd.screenplay.targets.Target, I've notice that the wording is a little odd.
When testing if a Target is displayed it is recorded in the report as "she sees target that is displayed".
Would there be any utility in changing this to read as "she sees that target is displayed"?
I haven't leapt down the rabbit hole just yet to determine if this is even feasible as I would like to get feedback on if this is something that would even be helpful before taking that time. I imagine that it might be a consequence of how Ensure's assertions are structured in general and would require more involved changes than it's worth, but I'm willing to take a look.
Beta Was this translation helpful? Give feedback.
All reactions