Minor refactoring

Author: wakaleo

pom.xml

@@ -12,7 +12,7 @@
         <maven.compiler.source>17</maven.compiler.source>
         <maven.compiler.target>17</maven.compiler.target>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <allure.version>2.25.0</allure.version>
+        <allure.version>2.29.0</allure.version>
         <aspectj.version>1.9.21</aspectj.version>
     </properties>
 
@@ -59,6 +59,16 @@
     </dependencies>
     <build>
         <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-compiler-plugin</artifactId>
+                <version>3.8.1</version>
+                <configuration>
+                    <compilerArgs>
+                        <arg>-parameters</arg>
+                    </compilerArgs>
+                </configuration>
+            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-surefire-plugin</artifactId>

src/test/java/com/serenitydojo/playwright/toolshop/catalog/AddToCartTest.java

@@ -2,6 +2,8 @@
 
 import com.serenitydojo.playwright.toolshop.catalog.pageobjects.*;
 import com.serenitydojo.playwright.toolshop.fixtures.PlaywrightTestCase;
+import io.qameta.allure.Feature;
+import io.qameta.allure.Story;
 import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayName;
@@ -10,6 +12,7 @@
 import java.util.List;
 
 @DisplayName("Shopping Cart")
+@Feature("Shopping Cart")
 public class AddToCartTest extends PlaywrightTestCase {
 
     SearchComponent searchComponent;
@@ -33,6 +36,7 @@ void setUp() {
     }
 
     @Test
+    @Story("Check out")
     @DisplayName("Checking out a single item")
     void whenCheckingOutASingleItem() {
         searchComponent.searchBy("pliers");
@@ -56,6 +60,7 @@ void whenCheckingOutASingleItem() {
     }
 
     @Test
+    @Story("Check out")
     @DisplayName("Checking out multiple items")
     void whenCheckingOutMultipleItems() {
         navBar.openHomePage();

src/test/java/com/serenitydojo/playwright/toolshop/catalog/SearchForProductsTest.java

@@ -3,13 +3,16 @@
 import com.serenitydojo.playwright.toolshop.catalog.pageobjects.ProductList;
 import com.serenitydojo.playwright.toolshop.catalog.pageobjects.SearchComponent;
 import com.serenitydojo.playwright.toolshop.fixtures.PlaywrightTestCase;
+import io.qameta.allure.Feature;
+import io.qameta.allure.Story;
 import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 
 @DisplayName("Searching for products")
+@Feature("Searching for products")
 public class SearchForProductsTest extends PlaywrightTestCase {
 
     @BeforeEach
@@ -19,6 +22,7 @@ void openHomePage() {
 
     @Nested
     @DisplayName("Searching by keyword")
+    @Story("Searching by keyword")
     class SearchingByKeyword {
 
         @Test
@@ -62,5 +66,6 @@ void clearingTheSearchResults() {
             var matchingProducts = productList.getProductNames();
             Assertions.assertThat(matchingProducts).hasSize(9);
         }
+
     }
 }

src/test/java/com/serenitydojo/playwright/toolshop/contact/ContactFormTest.java

@@ -4,6 +4,8 @@
 import com.serenitydojo.playwright.toolshop.catalog.pageobjects.NavBar;
 import com.serenitydojo.playwright.toolshop.fixtures.PlaywrightTestCase;
 import io.qameta.allure.Allure;
+import io.qameta.allure.Feature;
+import io.qameta.allure.Story;
 import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayName;
@@ -18,19 +20,20 @@
 import static com.microsoft.playwright.assertions.PlaywrightAssertions.assertThat;
 
 @DisplayName("Contact form")
+@Feature("Contact form")
 public class ContactFormTest extends PlaywrightTestCase {
 
     ContactForm contactForm;
     NavBar navigate;
 
-    @DisplayName("When submitting a request")
     @BeforeEach
     void openContactPage() {
         contactForm = new ContactForm(page);
         navigate = new NavBar(page);
         navigate.toTheContactPage();
     }
 
+    @Story("Submitting a request")
     @DisplayName("Customers can use the contact form to contact us")
     @Test
     void completeForm() throws URISyntaxException {
@@ -49,12 +52,11 @@ void completeForm() throws URISyntaxException {
                 .contains("Thanks for your message! We will contact you shortly.");
     }
 
+    @Story("Submitting a request")
     @DisplayName("First name, last name, email and message are mandatory")
-    @ParameterizedTest
+    @ParameterizedTest(name = "{arguments} is a mandatory field")
     @ValueSource(strings = {"First name", "Last name", "Email", "Message"})
     void mandatoryFields(String fieldName) {
-        Allure.parameter("fieldName", fieldName);
-
         // Fill in the field values
         contactForm.setFirstName("Sarah-Jane");
         contactForm.setLastName("Smith");
@@ -73,6 +75,7 @@ void mandatoryFields(String fieldName) {
         assertThat(errorMessage).isVisible();
     }
 
+    @Story("Submitting a request")
     @DisplayName("The message must be at least 50 characters long")
     @Test
     void messageTooShort() {
@@ -88,12 +91,11 @@ void messageTooShort() {
         assertThat(page.getByRole(AriaRole.ALERT)).hasText("Message must be minimal 50 characters");
     }
 
+    @Story("Submitting a request")
     @DisplayName("The email address must be correctly formatted")
-    @ParameterizedTest
+    @ParameterizedTest(name = "'{arguments}' should be rejected")
     @ValueSource(strings = {"not-an-email", "not-an.email.com", "notanemail"})
     void invalidEmailField(String invalidEmail) {
-        Allure.parameter("invalidEmail", invalidEmail);
-
         contactForm.setFirstName("Sarah-Jane");
         contactForm.setLastName("Smith");
         contactForm.setEmail(invalidEmail);
@@ -104,6 +106,4 @@ void invalidEmailField(String invalidEmail) {
 
         assertThat(page.getByRole(AriaRole.ALERT)).hasText("Email format is invalid");
     }
-
-
 }

src/test/java/com/serenitydojo/playwright/toolshop/fixtures/PlaywrightTestCase.java

@@ -19,7 +19,8 @@ public abstract class PlaywrightTestCase {
 
     protected static ThreadLocal<Browser> browser = ThreadLocal.withInitial(() ->
         playwright.get().chromium().launch(
-                new BrowserType.LaunchOptions().setHeadless(true)
+                new BrowserType.LaunchOptions()
+                        .setHeadless(true)
                         .setArgs(Arrays.asList("--no-sandbox", "--disable-extensions", "--disable-gpu"))
         )
     );