Remove Command::type_setter, replace with Command::type_#321
Draft
GnomedDev wants to merge 11 commits intoserenity-rs:nextfrom
Draft
Remove Command::type_setter, replace with Command::type_#321GnomedDev wants to merge 11 commits intoserenity-rs:nextfrom
Command::type_setter, replace with Command::type_#321GnomedDev wants to merge 11 commits intoserenity-rs:nextfrom
Conversation
GnomedDev
force-pushed
the
next
branch
3 times, most recently
from
6d2ae48 to
b0253b0
Compare
arqunis
force-pushed
the
next
branch
2 times, most recently
from
7b6dd00 to
38ded9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is draft as based on #320 and #319.
This significantly simplifies the
Command->CreateCommandconversion and cleans up some jank.