Improve edit tracking by adding options for old, uncached or suppression toggled messages#355
Open
jamesbt365 wants to merge 12 commits intoserenity-rs:nextfrom
Open
Improve edit tracking by adding options for old, uncached or suppression toggled messages#355jamesbt365 wants to merge 12 commits intoserenity-rs:nextfrom
jamesbt365 wants to merge 12 commits intoserenity-rs:nextfrom
Conversation
Co-authored-by: jamesbt365 <jamesbt365@gmail.com>
* Remove help commands from built-ins * Fix up docs and remove help_text_fn
…ion toggled messages
arqunis
force-pushed
the
next
branch
2 times, most recently
from
7b6dd00 to
38ded9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #309.
Currently untested at time of posting, but I want this looked at ASAP as currently untracked edits that receive message edits from discord (old message is reloaded with embeds) can cause commands to be executed again, these additional controls added by this PR should prevent this by using sane defaults.
But this is a big problem depending on the bot as this could cause roles to be added/removed from users, bans from being done/undone and other dangerous actions, this has been a problem since 2 criteria have been met:
Added an additional control unrelated to this PR about message embed suppression though, as i thought about this when fixing this and i can see how this could be annoying to some.