Fix unused warnings when compiling without certain features (#2970)

This is mostly just clean up, moving things around and gating things
behind features so that unused warnings in CI go away.

Author: mkrasnitski

src/builder/create_attachment.rs

@@ -250,6 +250,7 @@ impl<'a> EditAttachments<'a> {
     /// Clones all new attachments into a new Vec, keeping only data and filename, because those
     /// are needed for the multipart form data. The data is taken out of `self` in the process, so
     /// this method can only be called once.
+    #[cfg(feature = "http")]
     pub(crate) fn take_files(&mut self) -> Vec<CreateAttachment<'a>> {
         let mut files = Vec::new();
         for attachment in &mut self.new_and_existing_attachments {

src/builder/create_command.rs

@@ -1,4 +1,5 @@
 use std::borrow::Cow;
+use std::collections::HashMap;
 
 #[cfg(feature = "http")]
 use crate::http::Http;

src/builder/create_interaction_response.rs

@@ -1,4 +1,5 @@
 use std::borrow::Cow;
+use std::collections::HashMap;
 
 use serde_json::json;
 

src/builder/edit_message.rs

@@ -201,6 +201,7 @@ impl<'a> EditMessage<'a> {
         self
     }
 
+    #[cfg(feature = "cache")]
     fn is_only_suppress_embeds(&self) -> bool {
         self.flags == Some(MessageFlags::SUPPRESS_EMBEDS)
             && self.content.is_none()
@@ -234,6 +235,7 @@ impl<'a> EditMessage<'a> {
     /// [Manage Messages]: Permissions::MANAGE_MESSAGES
     /// [`From<Embed>`]: CreateEmbed#impl-From<Embed>
     #[cfg(feature = "http")]
+    #[cfg_attr(not(feature = "cache"), allow(unused_variables))]
     pub async fn execute(
         mut self,
         cache_http: impl CacheHttp,

src/builder/edit_role.rs

@@ -3,7 +3,6 @@ use std::borrow::Cow;
 use super::CreateAttachment;
 #[cfg(feature = "http")]
 use crate::http::Http;
-use crate::internal::prelude::*;
 use crate::model::prelude::*;
 
 /// A builder to create or edit a [`Role`] for use via a number of model methods.

src/builder/get_messages.rs

@@ -121,6 +121,7 @@ impl GetMessages {
     }
 }
 
+#[cfg_attr(not(feature = "http"), allow(dead_code))]
 #[derive(Clone, Copy, Debug)]
 enum SearchFilter {
     After(MessageId),

src/cache/event.rs

@@ -1,5 +1,4 @@
 use std::collections::{HashSet, VecDeque};
-use std::num::NonZeroU16;
 
 use super::{Cache, CacheUpdate};
 use crate::internal::prelude::*;
@@ -32,9 +31,8 @@ use crate::model::event::{
     VoiceChannelStatusUpdateEvent,
     VoiceStateUpdateEvent,
 };
-use crate::model::gateway::{Presence, ShardInfo};
+use crate::model::gateway::Presence;
 use crate::model::guild::{Guild, GuildMemberFlags, Member, MemberGeneratedFlags, Role};
-use crate::model::id::ShardId;
 use crate::model::user::{CurrentUser, OnlineStatus};
 use crate::model::voice::VoiceState;
 
@@ -449,8 +447,7 @@ impl CacheUpdate for ReadyEvent {
         let mut guilds_to_remove = vec![];
         let ready_guilds_hashset =
             self.ready.guilds.iter().map(|status| status.id).collect::<HashSet<_>>();
-        let shard_data =
-            self.ready.shard.unwrap_or_else(|| ShardInfo::new(ShardId(1), NonZeroU16::MIN));
+        let shard_data = self.ready.shard.unwrap_or_default();
 
         for guild_entry in cache.guilds.iter() {
             let guild = guild_entry.key();

src/gateway/client/mod.rs

@@ -35,7 +35,7 @@ use std::sync::OnceLock;
 use futures::channel::mpsc::UnboundedReceiver as Receiver;
 use futures::future::BoxFuture;
 use futures::StreamExt as _;
-use tracing::debug;
+use tracing::{debug, warn};
 
 pub use self::context::Context;
 pub use self::event_handler::{EventHandler, FullEvent, RawEventHandler};
@@ -55,7 +55,6 @@ use crate::model::gateway::GatewayIntents;
 #[cfg(feature = "voice")]
 use crate::model::id::UserId;
 use crate::model::user::OnlineStatus;
-use crate::utils::check_shard_total;
 
 /// A builder implementing [`IntoFuture`] building a [`Client`] to interact with Discord.
 #[must_use = "Builders do nothing unless they are awaited"]
@@ -762,3 +761,10 @@ impl Client {
         Ok(())
     }
 }
+
+fn check_shard_total(total_shards: u16) -> NonZeroU16 {
+    NonZeroU16::new(total_shards).unwrap_or_else(|| {
+        warn!("Invalid shard total provided ({total_shards}), defaulting to 1");
+        NonZeroU16::MIN
+    })
+}

src/gateway/sharding/mod.rs

@@ -42,6 +42,7 @@ use std::fmt;
 use std::sync::Arc;
 use std::time::{Duration as StdDuration, Instant};
 
+use aformat::{aformat, CapStr};
 use secrecy::{ExposeSecret as _, Secret};
 use tokio_tungstenite::tungstenite::error::Error as TungsteniteError;
 use tokio_tungstenite::tungstenite::protocol::frame::CloseFrame;

src/gateway/sharding/shard_queuer.rs

@@ -207,10 +207,14 @@ impl ShardQueuer {
 
     #[cfg_attr(feature = "tracing_instrument", instrument(skip(self)))]
     async fn start(&mut self, shard_id: ShardId) -> Result<()> {
+        let shard_info = ShardInfo {
+            id: shard_id,
+            total: self.shard_total,
+        };
         let mut shard = Shard::new(
             Arc::clone(&self.ws_url),
             Arc::clone(self.http.token()),
-            ShardInfo::new(shard_id, self.shard_total),
+            shard_info,
             self.intents,
             self.presence.clone(),
         )