Fix clippy and remove CI hacks

Author: mkrasnitski

.github/workflows/lint.yml

@@ -26,9 +26,7 @@ jobs:
         uses: Swatinem/rust-cache@v2
 
       - name: Run clippy
-        #!! Remove `-A clippy::result_large_err` once this is on `next`. This is to
-        #!! temporarily allow Clippy CI to run on `current`
-        run: cargo clippy --workspace --tests --features full -- -A clippy::result_large_err -D warnings --cfg ignore_serenity_deprecated
+        run: cargo clippy --workspace --tests --features full -- -D warnings --cfg ignore_serenity_deprecated
 
   rustfmt:
     name: Format

Cargo.toml

@@ -27,11 +27,6 @@ edition = "2024"
 rust-version = "1.85"
 
 [dependencies]
-#!! Downgrade to versions still supporting v1.74.0
-#!! Make sure to remove on `next`
-litemap = "=0.7.4"
-zerofrom = "=0.1.5"
-
 # Required dependencies
 bitflags = "2.4.2"
 serde_json = { version = "1.0.108", features = ["raw_value"] }

src/cache/event.rs

@@ -40,12 +40,10 @@ impl CacheUpdate for ChannelCreateEvent {
     type Output = GuildChannel;
 
     fn update(&mut self, cache: &Cache) -> Option<Self::Output> {
-        let old_channel = cache
+        cache
             .guilds
             .get_mut(&self.channel.guild_id)
-            .and_then(|mut g| g.channels.insert(self.channel.clone()));
-
-        old_channel
+            .and_then(|mut g| g.channels.insert(self.channel.clone()))
     }
 }
 

src/gateway/sharding/mod.rs

@@ -442,7 +442,9 @@ impl Shard {
             Ok(GatewayEvent::Dispatch {
                 seq,
                 event,
-            }) => self.handle_gateway_dispatch(seq, &event).map(|e| Some(ShardAction::Dispatch(e))),
+            }) => self
+                .handle_gateway_dispatch(seq, &event)
+                .map(|e| Some(ShardAction::Dispatch(Box::new(e)))),
             Ok(GatewayEvent::Heartbeat) => {
                 info!("[{:?}] Received shard heartbeat", self.shard_info);
 
@@ -762,7 +764,7 @@ pub enum ShardAction {
     Heartbeat,
     Identify,
     Reconnect,
-    Dispatch(Event),
+    Dispatch(Box<Event>),
 }
 
 /// Information about a [`ShardRunner`].

src/gateway/sharding/shard_runner.rs

@@ -215,7 +215,7 @@ impl ShardRunner {
                             spawn_named(
                                 "shard_runner::dispatch",
                                 dispatch_model(
-                                    event,
+                                    *event,
                                     context,
                                     #[cfg(feature = "framework")]
                                     self.framework.clone(),

src/http/client.rs

@@ -2235,7 +2235,7 @@ impl Http {
         self.execute_webhook_(webhook_id, thread_id, token, wait, files, map, true).await
     }
 
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     async fn execute_webhook_(
         &self,
         webhook_id: WebhookId,