-
Notifications
You must be signed in to change notification settings - Fork 660
Open
Description
The chrono maintainer has soft-deprecated chrono in favor of jiff.
It seems like it would be pretty straightforward to add jiff::Timestamp as an underlying type for serenity::…::Timestamp.
The only thing that might require discussion is what to do about the feature flags. I can see two possible approaches:
- add a
jifffeature flag, and use#[cfg(not(any(feature = "chrono", feature = "jiff"))]for thetimebackend. - add both
jiffandtimefeature flags; sincechronois one of the default features anyway, this shouldn't be a huge hassle for users.
Although jiff isn't yet included in typesize, so maybe that would be an issue? I don't really understand what that is used for yet. But it should be pretty simple to add it if needed. I'll check with @GnomedDev on that.
I'd be happy to send a PR for this, if it'd be welcomed.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels