Skip to content

Commit 6e1f317

Browse files
committed
[lldb/DWARF] Remove DWARFDebugRangesBase abstract class
now that we use llvm to parse debug_rnglists, this abstraction is not useful.
1 parent fac4e3c commit 6e1f317

File tree

2 files changed

+4
-13
lines changed

2 files changed

+4
-13
lines changed

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.h

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,13 @@ namespace lldb_private {
1717
class DWARFContext;
1818
}
1919

20-
class DWARFDebugRangesBase {
21-
public:
22-
virtual ~DWARFDebugRangesBase(){};
23-
24-
virtual void Extract(lldb_private::DWARFContext &context) = 0;
25-
virtual bool FindRanges(const DWARFUnit *cu, dw_offset_t debug_ranges_offset,
26-
DWARFRangeList &range_list) const = 0;
27-
};
28-
29-
class DWARFDebugRanges final : public DWARFDebugRangesBase {
20+
class DWARFDebugRanges {
3021
public:
3122
DWARFDebugRanges();
3223

33-
void Extract(lldb_private::DWARFContext &context) override;
24+
void Extract(lldb_private::DWARFContext &context);
3425
bool FindRanges(const DWARFUnit *cu, dw_offset_t debug_ranges_offset,
35-
DWARFRangeList &range_list) const override;
26+
DWARFRangeList &range_list) const;
3627

3728
static void Dump(lldb_private::Stream &s,
3829
const lldb_private::DWARFDataExtractor &debug_ranges_data,

lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -883,7 +883,7 @@ uint32_t DWARFUnit::GetHeaderByteSize() const {
883883
llvm::Expected<DWARFRangeList>
884884
DWARFUnit::FindRnglistFromOffset(dw_offset_t offset) {
885885
if (GetVersion() <= 4) {
886-
const DWARFDebugRangesBase *debug_ranges = m_dwarf.GetDebugRanges();
886+
const DWARFDebugRanges *debug_ranges = m_dwarf.GetDebugRanges();
887887
if (!debug_ranges)
888888
return llvm::make_error<llvm::object::GenericBinaryError>(
889889
"No debug_ranges section");

0 commit comments

Comments
 (0)