Skip to content

Commit b5fef6d

Browse files
committed
[OpenCL] Allow optional __generic in __remove_address_space utility
1 parent 7c3cf4c commit b5fef6d

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

clang/lib/Headers/opencl-c-base.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -600,9 +600,11 @@ typedef struct {
600600
// C++ for OpenCL - __remove_address_space
601601
#if defined(__OPENCL_CPP_VERSION__)
602602
template <typename _Tp> struct __remove_address_space { using type = _Tp; };
603+
#if defined(__opencl_c_generic_address_space)
603604
template <typename _Tp> struct __remove_address_space<__generic _Tp> {
604605
using type = _Tp;
605606
};
607+
#endif
606608
template <typename _Tp> struct __remove_address_space<__global _Tp> {
607609
using type = _Tp;
608610
};

clang/test/CodeGenOpenCLCXX/remove-address-space.clcpp renamed to clang/test/SemaOpenCLCXX/remove-address-space.clcpp

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
// RUN: %clang_cc1 %s -cl-std=clc++ -fdeclare-opencl-builtins -finclude-default-header
1+
// RUN: %clang_cc1 %s -cl-std=clc++1.0 -triple spir-unknown-unknown -fdeclare-opencl-builtins -finclude-default-header -verify
2+
// RUN: %clang_cc1 %s -cl-std=clc++2021 -triple spir-unknown-unknown -fdeclare-opencl-builtins -finclude-default-header -verify
3+
// RUN: %clang_cc1 %s -cl-std=clc++2021 -cl-ext=-__opencl_c_generic_address_space,-__opencl_c_pipes -triple spir-unknown-unknown -fdeclare-opencl-builtins -finclude-default-header -verify
4+
5+
// expected-no-diagnostics
26

37
template<typename T, typename U>
48
struct is_same {
@@ -19,8 +23,10 @@ void test_is_same() {
1923
void test_remove_address_space() {
2024
static_assert(is_same<__remove_address_space<int>::type, int>::value,
2125
"type without an address space unexpectedly modified by __remove_address_space");
26+
#if defined(__opencl_c_generic_address_space)
2227
static_assert(is_same<__remove_address_space<__generic int>::type, int>::value,
2328
"__generic address space not removed by __remove_address_space");
29+
#endif
2430
static_assert(is_same<__remove_address_space<__global char>::type, char>::value,
2531
"__global address space not removed by __remove_address_space");
2632
static_assert(is_same<__remove_address_space<__private ulong>::type, ulong>::value,

0 commit comments

Comments
 (0)