Merge pull request #187 from sergey-dryabzhinsky/Issue-186-fix-unused-parameter-warning

UPW

Author: sergey-dryabzhinsky

README.rst

@@ -256,7 +256,7 @@ If paths to header file ``zstd.h`` and libraries is uncommon - use common ``buil
 
    >>> $ python setup.py build_ext --external --include-dirs /opt/zstd/usr/include --libraries zstd --library-dirs /opt/zstd/lib clean
 
-But If you want to build with bundled distribution of libzstd just add ``--
+But If you want to force build with bundled distribution of libzstd just add ``--
 libzstd-bundled`` option
 
    >>> $ python setup.py build_ext --libzstd-bundled clean
@@ -265,6 +265,15 @@ When using a PEP 517 builder you can use ``ZSTD_BUNDLED`` environment variable i
 
    >>> $ ZSTD_BUNDLED=1 python -m build -w
 
+If you want to check if build w/o any warnings just add ``--
+all-warnings`` option
+
+   >>> $ python setup.py build_ext --all-warnings clean
+
+When using a PEP 517 builder you can use ``ZSTD_WARNINGS`` environment variable instead:
+
+   >>> $ ZSTD_WARNINGS=1 python -m build -w
+
 Install from pypi
 -----------------
 

src/python-zstd.c

@@ -53,7 +53,8 @@
  */
 static PyObject *py_zstd_compress_mt(PyObject* self, PyObject *args)
 {
-
+    UNUSED(self);
+    
     PyObject *result;
     const char *source;
     Py_ssize_t source_size;
@@ -147,6 +148,7 @@ static PyObject *py_zstd_compress_mt(PyObject* self, PyObject *args)
  */
 static PyObject *py_zstd_uncompress(PyObject* self, PyObject *args)
 {
+    UNUSED(self); 
 
     PyObject    *result;
     const char  *source, *src;
@@ -204,7 +206,7 @@ static PyObject *py_zstd_uncompress(PyObject* self, PyObject *args)
             	error = 1;
 //			}
         } else if (cSize != dest_size) {
-            PyErr_Format(ZstdError, "Decompression error: length mismatch -> decomp %lu != %lu [header]", (uint64_t)cSize, dest_size);
+            PyErr_Format(ZstdError, "Decompression error: length mismatch -> decomp %llu != %llu [header]", (uint64_t)cSize, dest_size);
             error = 1;
         }
     } else {
@@ -230,10 +232,11 @@ static PyObject *py_zstd_uncompress(PyObject* self, PyObject *args)
  */
 static PyObject *py_zstd_check(PyObject* self, PyObject *args)
 {
+    UNUSED(self);
     //PyObject    *result;
     const char  *source, *src;
     Py_ssize_t  source_size, ss, seek_frame;
-    int64_t    dest_size, frame_size, error=0;
+    uint64_t    dest_size, frame_size, error=0;
     //char        error = 0;
     //size_t      cSize;
 
@@ -277,6 +280,9 @@ static PyObject *py_zstd_check(PyObject* self, PyObject *args)
  */
 static PyObject *py_zstd_module_version(PyObject* self, PyObject *args)
 {
+    UNUSED(self);
+    UNUSED(args);
+
 #if PY_MAJOR_VERSION >= 3
     return PyUnicode_FromFormat("%s", xstr(VERSION));
 #else
@@ -289,6 +295,9 @@ static PyObject *py_zstd_module_version(PyObject* self, PyObject *args)
  */
 static PyObject *py_zstd_library_version(PyObject* self, PyObject *args)
 {
+     UNUSED(self);
+     UNUSED(args);
+	
 #if PY_MAJOR_VERSION >= 3
     return PyUnicode_FromFormat("%s", ZSTD_versionString());
 #else
@@ -301,6 +310,9 @@ static PyObject *py_zstd_library_version(PyObject* self, PyObject *args)
  */
 static PyObject *py_zstd_library_version_int(PyObject* self, PyObject *args)
 {
+    UNUSED(self);
+    UNUSED(args);
+
     return Py_BuildValue("i", ZSTD_VERSION_NUMBER);
 }
 
@@ -309,6 +321,9 @@ static PyObject *py_zstd_library_version_int(PyObject* self, PyObject *args)
  */
 static PyObject *py_zstd_library_legacy_format_support(PyObject* self, PyObject *args)
 {
+    UNUSED(self);
+    UNUSED(args);
+
     return Py_BuildValue("i", ZSTD_LEGACY_SUPPORT);
 }
 
@@ -317,6 +332,9 @@ static PyObject *py_zstd_library_legacy_format_support(PyObject* self, PyObject
  */
 static PyObject *py_zstd_library_external(PyObject* self, PyObject *args)
 {
+    UNUSED(self);
+    UNUSED(args);
+
     return Py_BuildValue("i", LIBZSTD_EXTERNAL);
 }
 
@@ -326,6 +344,9 @@ static PyObject *py_zstd_library_external(PyObject* self, PyObject *args)
  */
 static PyObject *py_zstd_with_threads(PyObject* self, PyObject *args)
 {
+    UNUSED(self);
+    UNUSED(args);
+
     return Py_BuildValue("i", ZSTD_MULTITHREAD);
 }
 
@@ -335,6 +356,9 @@ static PyObject *py_zstd_with_threads(PyObject* self, PyObject *args)
  */
 static PyObject *py_zstd_with_asm(PyObject* self, PyObject *args)
 {
+    UNUSED(self);
+    UNUSED(args);
+
     return Py_BuildValue("i", ! ZSTD_DISABLE_ASM);
 }
 
@@ -345,6 +369,9 @@ static PyObject *py_zstd_with_asm(PyObject* self, PyObject *args)
  */
 static PyObject *py_zstd_threads_count(PyObject* self, PyObject *args)
 {
+    UNUSED(self);
+    UNUSED(args);
+
     int32_t threads = UTIL_countPhysicalCores();
 
     return Py_BuildValue("i", threads);
@@ -355,6 +382,9 @@ static PyObject *py_zstd_threads_count(PyObject* self, PyObject *args)
  */
 static PyObject *py_zstd_max_threads_count(PyObject* self, PyObject *args)
 {
+    UNUSED(self);
+    UNUSED(args);
+
     return Py_BuildValue("i", ZSTDMT_NBWORKERS_MAX);
 }
 
@@ -363,6 +393,9 @@ static PyObject *py_zstd_max_threads_count(PyObject* self, PyObject *args)
  */
 static PyObject *py_zstd_min_compression_level(PyObject* self, PyObject *args)
 {
+    UNUSED(self);
+    UNUSED(args);
+
     return Py_BuildValue("i", ZSTD_MIN_CLEVEL);
 }
 
@@ -371,6 +404,9 @@ static PyObject *py_zstd_min_compression_level(PyObject* self, PyObject *args)
  */
 static PyObject *py_zstd_max_compression_level(PyObject* self, PyObject *args)
 {
+    UNUSED(self);
+    UNUSED(args);
+
     return Py_BuildValue("i", ZSTD_MAX_CLEVEL);
 }