Items are correctly sorted and avoid duplicated API calls

Author: sergioteula

amazon_paapi/api.py

@@ -13,7 +13,7 @@
 from .helpers import arguments
 from .helpers import requests
 from .helpers.generators import get_list_chunks
-from .helpers.items import get_items_including_unavailable
+from .helpers.items import sort_items
 
 
 class AmazonApi:
@@ -97,16 +97,13 @@ def get_items(
         items_ids = arguments.get_items_ids(items)
         results = []
 
-        for asin_chunk in get_list_chunks(items_ids, chunk_size=10):
+        for asin_chunk in get_list_chunks(list(set(items_ids)), chunk_size=10):
             request = requests.get_items_request(self, asin_chunk, **kwargs)
             self._throttle()
             items_response = requests.get_items_response(self, request)
             results.extend(items_response)
 
-        if include_unavailable:
-            results = get_items_including_unavailable(results, items_ids)
-
-        return results
+        return sort_items(results, items_ids, include_unavailable)
 
 
     def search_items(

amazon_paapi/helpers/arguments.py

@@ -18,7 +18,7 @@ def get_items_ids(items: Union[str, List[str]]) -> List[str]:
         items_ids = [get_asin(x.strip()) for x in items]
 
     if items_ids:
-        return list(set(items_ids))
+        return items_ids
 
     raise AsinNotFoundException('No ASIN codes have been found.')
 

amazon_paapi/helpers/items.py

@@ -4,8 +4,14 @@
 from .. import models
 
 
-def get_items_including_unavailable(items: List[models.Item], items_ids: List[str]) -> List[models.Item]:
-    for index, asin in enumerate(items_ids):
-        if items[index].asin != asin:
-            items.insert(index, models.Item(asin=asin))
-    return items
+def sort_items(items: List[models.Item], items_ids: List[str], include_unavailable: bool) -> List[models.Item]:
+    sorted_items = []
+
+    for asin in items_ids:
+        matches = list(filter(lambda item, asin=asin: item.asin == asin, items))
+        if matches:
+            sorted_items.append(matches[0])
+        elif include_unavailable:
+            sorted_items.append(models.Item(asin=asin))
+
+    return sorted_items