Added a confirmation prompt when deleting items such as port and device

Author: serhmarch

changelog.md

@@ -75,3 +75,5 @@
 
 * When you click `Insert` in the `DataView` window, the new value is added to the list, 
   but taking into account the address and size of the element format above.
+* Added insert/delete hotkeys for port/device/actions elements (copy/paste for actions)
+* Added a confirmation prompt when deleting items such as port and device

src/client/gui/client_ui.cpp

@@ -27,6 +27,7 @@
 #include <QBuffer>
 #include <QClipboard>
 #include <QLabel>
+#include <QMessageBox>
 
 #include <client.h>
 
@@ -273,9 +274,22 @@ void mbClientUi::menuSlotPortDelete()
         if (port)
         {
             if (port->deviceCount())
+            {
+                QMessageBox::information(this,
+                                         QStringLiteral("Delete Port"),
+                                         QString("Can't delete '%1' because it has a device(s)!").arg(port->name()),
+                                         QMessageBox::Ok);
                 return;
-            project->portRemove(port);
-            delete port;
+            }
+            QMessageBox::StandardButton res = QMessageBox::question(this,
+                                                                    QStringLiteral("Delete Port"),
+                                                                    QString("Are you sure you want to delete '%1'?").arg(port->name()),
+                                                                    QMessageBox::Yes|QMessageBox::No);
+            if (res == QMessageBox::Yes)
+            {
+                project->portRemove(port);
+                delete port;
+            }
         }
     }
 }
@@ -309,12 +323,20 @@ void mbClientUi::menuSlotPortClearAllDevice()
         QList<mbClientDevice*> devices = port->devices();
         if (devices.count())
         {
-            Q_FOREACH(mbClientDevice* d, devices)
-                port->deviceRemove(d);
-            mbClientProject* project = core()->project();
-            Q_FOREACH(mbClientDevice* d, devices)
-                project->deviceRemove(d);
-            qDeleteAll(devices);
+            QMessageBox::StandardButton res = QMessageBox::question(this,
+                                                                    QStringLiteral("Clear All Devices"),
+                                                                    QString("Are you sure you want to clear all devices for port '%1'?").arg(port->name()),
+                                                                    QMessageBox::Yes|QMessageBox::No);
+            if (res == QMessageBox::Yes)
+            {
+
+                Q_FOREACH(mbClientDevice* d, devices)
+                    port->deviceRemove(d);
+                mbClientProject* project = core()->project();
+                Q_FOREACH(mbClientDevice* d, devices)
+                    project->deviceRemove(d);
+                qDeleteAll(devices);
+            }
         }
     }
 }
@@ -385,11 +407,18 @@ void mbClientUi::menuSlotDeviceDelete()
         mbClientDevice *d = projectUi()->currentDevice();
         if (d)
         {
-            mbClientPort *port = d->port();
-            if (port)
-                port->deviceRemove(d);
-            prj->deviceRemove(d);
-            delete d;
+            QMessageBox::StandardButton res = QMessageBox::question(this,
+                                                                    QStringLiteral("Delete Device"),
+                                                                    QString("Are you sure you want to delete '%1'?").arg(d->name()),
+                                                                    QMessageBox::Yes|QMessageBox::No);
+            if (res == QMessageBox::Yes)
+            {
+                mbClientPort *port = d->port();
+                if (port)
+                    port->deviceRemove(d);
+                prj->deviceRemove(d);
+                delete d;
+            }
         }
     }
 }

src/server/gui/server_ui.cpp

@@ -30,6 +30,7 @@
 #include <QComboBox>
 #include <QMdiArea>
 #include <QMdiSubWindow>
+#include <QMessageBox>
 
 #include <project/server_project.h>
 #include <project/server_port.h>
@@ -49,7 +50,6 @@
 #include "device/server_deviceui.h"
 
 #include "dataview/server_dataviewmanager.h"
-#include "dataview/server_dataviewui.h"
 
 #include "actions/server_actionsui.h"
 
@@ -357,7 +357,7 @@ void mbServerUi::menuSlotEditDelete()
         {
             if (m_projectUi->selectedDeviceCore())
             {
-                menuSlotDeviceDelete();
+                menuSlotPortDeviceDelete();
                 return;
             }
             if (m_projectUi->selectedPortCore())
@@ -426,9 +426,22 @@ void mbServerUi::menuSlotPortDelete()
         if (port)
         {
             if (port->deviceCount())
+            {
+                QMessageBox::information(this,
+                                         QStringLiteral("Delete Port"),
+                                         QString("Can't delete '%1' because it has a device(s)!").arg(port->name()),
+                                         QMessageBox::Ok);
                 return;
-            project->portRemove(port);
-            delete port;
+            }
+            QMessageBox::StandardButton res = QMessageBox::question(this,
+                                                                    QStringLiteral("Delete Port"),
+                                                                    QString("Are you sure you want to delete '%1'?").arg(port->name()),
+                                                                    QMessageBox::Yes|QMessageBox::No);
+            if (res == QMessageBox::Yes)
+            {
+                project->portRemove(port);
+                delete port;
+            }
         }
     }
 }
@@ -522,9 +535,16 @@ void mbServerUi::menuSlotPortDeviceDelete()
     mbServerDeviceRef *device = projectUi()->currentDeviceRef();
     if (!device)
         return;
-    mbServerPort *port = device->port();
-    port->deviceRemove(device);
-    delete device;
+    QMessageBox::StandardButton res = QMessageBox::question(this,
+                                                            QStringLiteral("Delete Device"),
+                                                            QString("Are you sure you want to delete '%1' from port?").arg(device->name()),
+                                                            QMessageBox::Yes|QMessageBox::No);
+    if (res == QMessageBox::Yes)
+    {
+        mbServerPort *port = device->port();
+        port->deviceRemove(device);
+        delete device;
+    }
 }
 
 void mbServerUi::menuSlotDeviceNew()
@@ -558,13 +578,20 @@ void mbServerUi::menuSlotDeviceDelete()
     mbServerProject *project = core()->project();
     if (!project)
         return;
-    mbServerDevice *d = m_deviceManager->activeDevice();
-    if (!d)
+    mbServerDevice *device = m_deviceManager->activeDevice();
+    if (!device)
         return;
-    Q_FOREACH(mbServerPort *port, project->ports())
-        port->deviceRemove(d);
-    project->deviceRemove(d);
-    delete d;
+    QMessageBox::StandardButton res = QMessageBox::question(this,
+                                                            QStringLiteral("Delete Device"),
+                                                            QString("Are you sure you want to delete '%1'?").arg(device->name()),
+                                                            QMessageBox::Yes|QMessageBox::No);
+    if (res == QMessageBox::Yes)
+    {
+        Q_FOREACH(mbServerPort *port, project->ports())
+            port->deviceRemove(device);
+        project->deviceRemove(device);
+        delete device;
+    }
 }
 
 void mbServerUi::menuSlotDeviceImport()