Drag'n'Drop is denied when app is running

Author: serhmarch

src/core/gui/dataview/core_dataviewmodel.cpp

@@ -58,7 +58,7 @@ QVariant mbCoreDataViewModel::headerData(int section, Qt::Orientation orientatio
     return QVariant();
 }
 
-int mbCoreDataViewModel::columnCount(const QModelIndex &parent) const
+int mbCoreDataViewModel::columnCount(const QModelIndex &/*parent*/) const
 {
     return m_dataView->getColumnCount();
 }

src/core/gui/dialogs/core_dialogdataviewitem.cpp

@@ -543,7 +543,7 @@ void mbCoreDialogDataViewItem::fillFormEditInner(const MBSETTINGS &/*settings*/)
     // base implementation do nothing
 }
 
-void mbCoreDialogDataViewItem::fillFormNewInner(const MBSETTINGS &settings)
+void mbCoreDialogDataViewItem::fillFormNewInner(const MBSETTINGS &/*settings*/)
 {
     // base implementation do nothing
 }

src/core/gui/project/core_projecttreeview.cpp

@@ -5,6 +5,8 @@
 #include <QMouseEvent>
 #include <QDrag>
 
+#include <core.h>
+
 mbCoreProjectTreeView::mbCoreProjectTreeView(QWidget *parent) : QTreeView(parent)
 {
 
@@ -19,6 +21,8 @@ void mbCoreProjectTreeView::mousePressEvent(QMouseEvent *event)
 
 void mbCoreProjectTreeView::mouseMoveEvent(QMouseEvent *event)
 {
+    if (mbCore::globalCore()->isRunning())
+        return;
     if (!(event->buttons() & Qt::LeftButton))
         return;
     if ((event->pos() - m_dragStartPosition).manhattanLength() < QApplication::startDragDistance())
@@ -39,6 +43,8 @@ void mbCoreProjectTreeView::mouseMoveEvent(QMouseEvent *event)
 
 void mbCoreProjectTreeView::dropEvent(QDropEvent *event)
 {
+    if (mbCore::globalCore()->isRunning())
+        return;
     QModelIndex index = indexAt(event->pos());
     if (index.isValid())
         model()->dropMimeData(event->mimeData(), event->dropAction(), index.row(), index.column(), index.parent());

src/server/gui/dialogs/settings/server_widgetsettingsscript.cpp

@@ -55,7 +55,7 @@ mbServerWidgetSettingsScript::mbServerWidgetSettingsScript(QWidget *parent) :
     m_modelImportPath = new QStringListModel(this);
     ui->viewImportPath->setModel(m_modelImportPath);
     ui->viewImportPath->setSelectionMode(QAbstractItemView::ExtendedSelection);
-    connect(m_modelImportPath, &QAbstractItemModel::dataChanged, this, [this](const QModelIndex &topLeft, const QModelIndex &bottomRight, const QVector<int> &roles = QVector<int>())
+    connect(m_modelImportPath, &QAbstractItemModel::dataChanged, this, [this](const QModelIndex &topLeft, const QModelIndex &, const QVector<int> &)
     {
         QModelIndex newIndex = topLeft;
         if (m_modelImportPath->data(newIndex).toString().trimmed().isEmpty())

src/server/runtime/server_runscriptthread.cpp

@@ -56,7 +56,7 @@ struct MemWork
 
 QSharedMemory::SharedMemoryError initMem(QSharedMemory &mem, size_t size)
 {
-    mem.create(size);
+    mem.create(static_cast<int>(size));
     QSharedMemory::SharedMemoryError r = mem.error();
     switch (r)
     {