Optimized 'readWriteMultipleRegisters'-func for broadcast

serhmarch · serhmarch · commit d7f09c7b746b · 2025-03-13T23:38:23.000+02:00
diff --git a/src/server/runtime/server_rundevice.cpp b/src/server/runtime/server_rundevice.cpp
@@ -240,8 +240,10 @@ Modbus::StatusCode mbServerRunDevice::readWriteMultipleRegisters(uint8_t unit, u
 {
     if (isBroadcast(unit))
     {
+        // Note: No need to fill read buffer and return it to client in broadcast mode.
+        //       So use `writeMultipleRegisters`-part only.
         Q_FOREACH (mbServerDevice *device, m_devices)
-            device->readWriteMultipleRegisters(readOffset, readCount, readValues, writeOffset, writeCount, writeValues);
+            device->writeMultipleRegisters(writeOffset, writeCount, writeValues);
         return Modbus::Status_Good;
     }
     else

Original file line number	Diff line number	Diff line change
`@@ -240,8 +240,10 @@ Modbus::StatusCode mbServerRunDevice::readWriteMultipleRegisters(uint8_t unit, u`
`240`	`240`	`{`
`241`	`241`	`if (isBroadcast(unit))`
`242`	`242`	`{`
	`243`	`+ // Note: No need to fill read buffer and return it to client in broadcast mode.`
	`244`	+ // So use `writeMultipleRegisters`-part only.
`243`	`245`	`Q_FOREACH (mbServerDevice *device, m_devices)`
`244`		`- device->readWriteMultipleRegisters(readOffset, readCount, readValues, writeOffset, writeCount, writeValues);`
	`246`	`+ device->writeMultipleRegisters(writeOffset, writeCount, writeValues);`
`245`	`247`	`return Modbus::Status_Good;`
`246`	`248`	`}`
`247`	`249`	`else`