Skip to content

Commit 681977d

Browse files
committed
Clean up test
1 parent e5eeac9 commit 681977d

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

Serilog.Sinks.Network.Test/JsonFormatter.cs

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,16 +56,12 @@ public async Task CanStillLogMessagesWithExceptions()
5656
[Fact]
5757
public async Task IncludesCurrentActivityTraceAndSpanIds()
5858
{
59-
// Create an ActivitySource and start an activity.
59+
// Create an ActivitySource, add a listener, and start an activity.
6060
// StartActivity() would return null if there were no listeners.
61-
using var activityListener = new ActivityListener
62-
{
63-
ShouldListenTo = _ => true,
64-
Sample = (ref ActivityCreationOptions<ActivityContext> _) => ActivitySamplingResult.AllData,
65-
};
66-
ActivitySource.AddActivityListener(activityListener);
6761
using var activitySource = new ActivitySource("TestSource");
62+
using var activityListener = CreateAndAddActivityListener(activitySource.Name);
6863
using Activity? activity = activitySource.StartActivity();
64+
Assert.NotNull(activity);
6965

7066
using var fixture = ConfigureTestLogger(new LogstashJsonFormatter());
7167

@@ -89,5 +85,16 @@ public async Task OmitsTraceAndSpanIdsWhenThereIsNoActivity()
8985
receivedData.Should().NotContain("\"traceId\"");
9086
receivedData.Should().NotContain("\"spanId\"");
9187
}
88+
89+
private static ActivityListener CreateAndAddActivityListener(string sourceName)
90+
{
91+
var activityListener = new ActivityListener
92+
{
93+
ShouldListenTo = source => source.Name == sourceName,
94+
Sample = (ref ActivityCreationOptions<ActivityContext> _) => ActivitySamplingResult.AllData,
95+
};
96+
ActivitySource.AddActivityListener(activityListener);
97+
return activityListener;
98+
}
9299
}
93100
}

0 commit comments

Comments
 (0)