Make Log4NetTextFormatterOptionsBuilder constructor internal

Author: 0xced

src/Log4NetTextFormatterOptionsBuilder.cs

@@ -10,6 +10,13 @@ namespace Serilog.Formatting.Log4Net
     /// </summary>
     public class Log4NetTextFormatterOptionsBuilder
     {
+        /// <summary>
+        /// Initialize a new instance of the <see cref="Log4NetTextFormatterOptionsBuilder"/> class.
+        /// </summary>
+        internal Log4NetTextFormatterOptionsBuilder()
+        {
+        }
+
         /// <summary>
         /// The <see cref="IFormatProvider"/> used when formatting message and properties of log4net events.
         /// <para>The default value is <see langref="null"/>, meaning that the default Serilog provider is used, i.e. the <see cref="CultureInfo.InvariantCulture"/>.</para>

tests/Log4NetTextFormatterOptionsBuilderTest.cs

@@ -80,6 +80,30 @@ public void NullOutputThrowsArgumentNullException()
             action.Should().ThrowExactly<ArgumentNullException>().Which.ParamName.Should().Be("output");
         }
 
+        [Fact]
+        public void SettingPropertyFilterToNullThrowsArgumentNullException()
+        {
+            // Act
+            Action action = () => _ = new Log4NetTextFormatter(c => c.UsePropertyFilter(null!));
+
+            // Assert
+            action.Should().ThrowExactly<ArgumentNullException>()
+                .WithMessage("The FilterProperty option can not be null.*")
+                .And.ParamName.Should().Be("filterProperty");
+        }
+
+        [Fact]
+        public void SettingExceptionFormatterToNullThrowsArgumentNullException()
+        {
+            // Act
+            Action action = () => _ = new Log4NetTextFormatter(c => c.UseExceptionFormatter(null!));
+
+            // Assert
+            action.Should().ThrowExactly<ArgumentNullException>()
+                .WithMessage("The FormatException option can not be null.*")
+                .And.ParamName.Should().Be("formatException");
+        }
+
         [Theory]
         [InlineData(Events.LogEventLevel.Verbose)]
         [InlineData(Events.LogEventLevel.Debug)]

tests/Log4NetTextFormatterTest.cs

@@ -39,7 +39,6 @@ namespace Serilog.Formatting.Log4Net
     }
     public class Log4NetTextFormatterOptionsBuilder
     {
-        public Log4NetTextFormatterOptionsBuilder() { }
         public Serilog.Formatting.Log4Net.CDataMode CDataMode { get; }
         public Serilog.Formatting.Log4Net.PropertyFilter FilterProperty { get; }
         public Serilog.Formatting.Log4Net.ExceptionFormatter FormatException { get; }