Use coverlet.collector instead of coverlet.msbuild

Pro: recommended way without [known issues][1]
Con: No more nice summary table like this:
```
+----------------------------+------+--------+--------+
| Module                     | Line | Branch | Method |
+----------------------------+------+--------+--------+
| Serilog.Formatting.Log4Net | 100% | 100%   | 100%   |
+----------------------------+------+--------+--------+

+---------+------+--------+--------+
|         | Line | Branch | Method |
+---------+------+--------+--------+
| Total   | 100% | 100%   | 100%   |
+---------+------+--------+--------+
| Average | 100% | 100%   | 100%   |
+---------+------+--------+--------+
```

[1]: https://github.com/coverlet-coverage/coverlet/blob/d93613826b1a33f894b9c80f6ae893643a8b7254/Documentation/KnownIssues.md#vstest-stops-process-execution-early

Author: 0xced

.github/workflows/continuous-integration.yml

@@ -22,7 +22,6 @@ jobs:
       checks: write
     name: Run tests and create NuGet package
     outputs:
-      coverage-reports: ${{ steps.dotnet-test.outputs.coverage-reports }}
       nupkg-filename: ${{ steps.dotnet-pack.outputs.nupkg-filename }}
     steps:
       - name: Checkout git repository
@@ -41,9 +40,9 @@ jobs:
       - name: Restore NuGet packages
         run: dotnet restore
       - name: Build solution
-        run: dotnet build
+        run: dotnet build --no-restore
       - name: Run tests
-        run: dotnet test --no-build --logger "html;LogFileName=../../TestResults-${{ runner.os }}.html" --logger "trx;LogFileName=../../TestResults-${{ runner.os }}.trx" --logger GitHubActions
+        run: dotnet test --no-build
         id: dotnet-test
       - name: Upload received files from failing tests
         uses: actions/upload-artifact@v3
@@ -55,28 +54,28 @@ jobs:
         uses: actions/upload-artifact@v3
         if: always()
         with:
-          name: TestResults-${{ runner.os }}
-          path: TestResults-${{ runner.os }}.html
+          name: TestResults (${{ runner.os }})
+          path: TestResults-*.html
       - name: Test Report
         uses: dorny/test-reporter@v1
         if: always()
         with:
           name: Test Results (${{ runner.os }})
-          path: TestResults-${{ runner.os }}.trx
+          path: TestResults-*.trx
           reporter: dotnet-trx
       - name: Upload coverage report to Codecov
         if: matrix.os == 'ubuntu-latest'
         uses: codecov/codecov-action@v3
         with:
-          files: ${{ steps.dotnet-test.outputs.coverage-reports }}
+          files: coverage/*/coverage.cobertura.xml
       - name: Upload coverage report to Codacy
         env:
           CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }}
         if: matrix.os == 'ubuntu-latest' && env.CODACY_PROJECT_TOKEN != ''
         uses: codacy/codacy-coverage-reporter-action@v1
         with:
           project-token: ${{ env.CODACY_PROJECT_TOKEN }}
-          coverage-reports: ${{ steps.dotnet-test.outputs.coverage-reports }}
+          coverage-reports: coverage/*/coverage.cobertura.xml
       - name: Create NuGet package
         run: dotnet pack --no-build --output .
         id: dotnet-pack

tests/Serilog.Formatting.Log4Net.Tests.csproj

@@ -7,7 +7,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="coverlet.msbuild" Version="3.2.0" PrivateAssets="all" />
+    <PackageReference Include="coverlet.collector" Version="3.2.0" PrivateAssets="all" />
     <PackageReference Include="FluentAssertions" Version="6.10.0" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.5.0" />
     <PackageReference Include="PublicApiGenerator" Version="11.0.0" />
@@ -24,35 +24,48 @@
     <PackageReference Include="GitHubActionsTestLogger" Version="2.0.1" PrivateAssets="all" />
   </ItemGroup>
 
+  <ItemGroup>
+    <VSTestLogger Include="GitHubActions" Visible="false" Condition="$(ContinuousIntegrationBuild) == 'true'" />
+    <VSTestLogger Include="trx%3BLogFileName=TestResults-$(TargetFramework).trx" Visible="false" Condition="$(ContinuousIntegrationBuild) == 'true'" />
+    <VSTestLogger Include="html%3BLogFileName=TestResults-$(TargetFramework).html" Visible="false" />
+  </ItemGroup>
+
   <PropertyGroup Label="Coverage">
-    <!-- Automatically collect coverage when running `dotnet test` -->
-    <CollectCoverage>true</CollectCoverage>
-    <!-- Tweak the default coverlet output directory to be `coverage` in the repository root directory -->
-    <CoverletOutput>$([MSBuild]::EnsureTrailingSlash($([System.IO.Path]::GetFullPath($([System.IO.Path]::Combine($(MSBuildProjectDirectory),'..','coverage'))))))</CoverletOutput>
-    <!-- The default output format is `json` which is not supported by ReportGenerator -->
-    <CoverletOutputFormat>cobertura</CoverletOutputFormat>
+    <RootDirectory>$([System.IO.Directory]::GetParent($(MSBuildProjectDirectory)))</RootDirectory>
+    <CoverageReportDirectory>$([System.IO.Path]::Combine($(RootDirectory),'coverage',$(TargetFramework)))</CoverageReportDirectory>
+    <VSTestResultsDirectory Condition="$(ContinuousIntegrationBuild) == 'true'">$(RootDirectory)</VSTestResultsDirectory>
+    <VSTestResultsDirectory Condition="$(ContinuousIntegrationBuild) != 'true'">$([System.IO.Path]::Combine($(CoverageReportDirectory),'results'))</VSTestResultsDirectory>
+    <VSTestCollect>XPlat Code Coverage</VSTestCollect>
+    <VSTestLogger>@(VSTestLogger)</VSTestLogger>
   </PropertyGroup>
 
-  <Target Name="GenerateHtmlCoverageReport" AfterTargets="GenerateCoverageResultAfterTest" Condition="$(ContinuousIntegrationBuild) != 'true'">
-    <PropertyGroup>
-      <CoverageReportDirectory>$([MSBuild]::EnsureTrailingSlash('$(CoverletOutput)report'))</CoverageReportDirectory>
-      <OpenCommand Condition="$([MSBuild]::IsOSPlatform('Linux'))">xdg-open</OpenCommand>
-      <OpenCommand Condition="$([MSBuild]::IsOSPlatform('OSX'))">open</OpenCommand>
-      <OpenCommand Condition="$([MSBuild]::IsOSPlatform('Windows'))">explorer</OpenCommand>
-    </PropertyGroup>
+  <Target Name="GenerateHtmlCoverageReport" AfterTargets="VSTest" Condition="$(TargetFramework) != ''">
+    <ItemGroup>
+      <CoverletReport Include="$(VSTestResultsDirectory)/*/coverage.cobertura.xml" />
+    </ItemGroup>
     <ReportGenerator ReportFiles="@(CoverletReport)" TargetDirectory="$(CoverageReportDirectory)" />
-    <!-- executing "explorer path\to\index.html" returns exit code 1, so we ignore it -->
-    <Exec WorkingDirectory="$(CoverageReportDirectory)" Command="$(OpenCommand) index.html" Condition="$(OpenCommand) != ''" IgnoreExitCode="true" />
   </Target>
 
-  <Target Name="WriteCoverageReportPathForGitHubActions" AfterTargets="GenerateCoverageResultAfterTest" Condition="$(GITHUB_OUTPUT) != ''">
+  <!-- Because of https://github.com/microsoft/vstest/issues/2378 -->
+  <Target Name="MoveCoverletReport" AfterTargets="GenerateHtmlCoverageReport">
+    <Move SourceFiles="@(CoverletReport)" DestinationFolder="$(CoverageReportDirectory)" />
     <PropertyGroup>
-      <CoverageReports>@(CoverletReport, ',')</CoverageReports>
+      <CoverletReport>@(CoverletReport)</CoverletReport>
     </PropertyGroup>
     <ItemGroup>
-      <GitHubOutput Include="coverage-reports=$(CoverageReports)" />
+      <CoverletReportParentDirectory Include="$([System.IO.Path]::Combine($(CoverletReport),'..'))" />
     </ItemGroup>
-    <WriteLinesToFile File="$(GITHUB_OUTPUT)" Lines="@(GitHubOutput)" />
+    <RemoveDir Directories="@(CoverletReportParentDirectory)" />
+  </Target>
+
+  <Target Name="OpenHtmlCoverageReport" AfterTargets="MoveCoverletReport" Condition="$(ContinuousIntegrationBuild) != 'true'">
+    <PropertyGroup>
+      <OpenCommand Condition="$([MSBuild]::IsOSPlatform('Linux'))">xdg-open</OpenCommand>
+      <OpenCommand Condition="$([MSBuild]::IsOSPlatform('OSX'))">open</OpenCommand>
+      <OpenCommand Condition="$([MSBuild]::IsOSPlatform('Windows'))">explorer</OpenCommand>
+    </PropertyGroup>
+    <!-- executing "explorer path\to\index.html" returns exit code 1, so we ignore it -->
+    <Exec WorkingDirectory="$(CoverageReportDirectory)" Command="$(OpenCommand) index.html" Condition="$(OpenCommand) != ''" IgnoreExitCode="true" />
   </Target>
 
   <ItemGroup>