Use ordinal string comparison where appropriate

0xced · 0xced · commit c9edd1ad9716 · 2021-08-26T11:15:44.000+02:00
diff --git a/src/Log4NetTextFormatter.cs b/src/Log4NetTextFormatter.cs
@@ -105,7 +105,7 @@ private void WriteEvent(LogEvent logEvent, XmlWriter writer)
             writer.WriteAttributeString("level", LogLevel(logEvent.Level));
             WriteEventAttribute(logEvent, writer, "thread", ThreadIdPropertyName);
             WriteDomainAndUserName(logEvent, writer);
-            var properties = logEvent.Properties.Where(e => !SpecialProperties.Contains(e.Key)).ToList();
+            var properties = logEvent.Properties.Where(e => !SpecialProperties.Contains(e.Key, StringComparer.Ordinal)).ToList();
             var hasMachineNameProperty = logEvent.Properties.TryGetValue(MachineNamePropertyName, out var machineNameProperty) && machineNameProperty is ScalarValue { Value: not null };
             if (properties.Any() || hasMachineNameProperty)
             {

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ private void WriteEvent(LogEvent logEvent, XmlWriter writer)`
`105`	`105`	`writer.WriteAttributeString("level", LogLevel(logEvent.Level));`
`106`	`106`	`WriteEventAttribute(logEvent, writer, "thread", ThreadIdPropertyName);`
`107`	`107`	`WriteDomainAndUserName(logEvent, writer);`
`108`		`- var properties = logEvent.Properties.Where(e => !SpecialProperties.Contains(e.Key)).ToList();`
	`108`	`+ var properties = logEvent.Properties.Where(e => !SpecialProperties.Contains(e.Key, StringComparer.Ordinal)).ToList();`
`109`	`109`	`var hasMachineNameProperty = logEvent.Properties.TryGetValue(MachineNamePropertyName, out var machineNameProperty) && machineNameProperty is ScalarValue { Value: not null };`
`110`	`110`	`if (properties.Any() \|\| hasMachineNameProperty)`
`111`	`111`	`{`