Try to reconnect on SocketException

Author: fred2u

src/Serilog.Sinks.UDP/Sinks/Splunk/UdpSink.cs

@@ -27,8 +27,9 @@ namespace Serilog.Sinks.Splunk
     /// </summary>
     public class UdpSink : ILogEventSink, IDisposable
     {
-        private Socket _socket;
+        private readonly SplunkUdpSinkConnectionInfo _connectionInfo;
         private readonly ITextFormatter _formatter;
+        private Socket _socket;
         private bool disposedValue = false;
 
         /// <summary>
@@ -37,70 +38,85 @@ public class UdpSink : ILogEventSink, IDisposable
         /// <param name="connectionInfo">Connection info used for connecting against Splunk.</param>
         /// <param name="formatProvider">Optional format provider</param>
         /// <param name="renderTemplate">If true, the message template will be rendered</param>
-        public UdpSink(
-            SplunkUdpSinkConnectionInfo connectionInfo,
-            IFormatProvider formatProvider = null,
-            bool renderTemplate = true)
+        public UdpSink(SplunkUdpSinkConnectionInfo connectionInfo, IFormatProvider formatProvider = null, bool renderTemplate = true)
+            : this(connectionInfo, CreateDefaultFormatter(formatProvider, renderTemplate))
         {
-            Connect(connectionInfo);
-            _formatter = CreateDefaultFormatter(formatProvider, renderTemplate);
         }
 
         /// <summary>
         /// Creates an instance of the Splunk UDP Sink.
         /// </summary>
         /// <param name="connectionInfo">Connection info used for connecting against Splunk.</param>
         /// <param name="formatter">Custom formatter to use if you e.g. do not want to use the JsonFormatter.</param>
-        public UdpSink(
-            SplunkUdpSinkConnectionInfo connectionInfo,
-            ITextFormatter formatter)
+        public UdpSink(SplunkUdpSinkConnectionInfo connectionInfo, ITextFormatter formatter)
         {
-            Connect(connectionInfo);
+            _connectionInfo = connectionInfo;
             _formatter = formatter;
+            Connect();
         }
 
-        private void Connect(SplunkUdpSinkConnectionInfo connectionInfo)
+        /// <inheritdoc/>
+        protected virtual void Dispose(bool disposing)
         {
-            _socket = new Socket(SocketType.Dgram, ProtocolType.Udp);
-            _socket.Connect(connectionInfo.Host, connectionInfo.Port);
+            if (!disposedValue)
+            {
+                if (disposing)
+                {
+                    DisposeSocket();
+                }
+
+                disposedValue = true;
+            }
         }
 
-        private static SplunkJsonFormatter CreateDefaultFormatter(IFormatProvider formatProvider, bool renderTemplate)
+        /// <inheritdoc/>
+        public void Dispose()
         {
-            return new SplunkJsonFormatter(renderTemplate, formatProvider);
+            Dispose(true);
         }
 
         /// <inheritdoc/>
         public void Emit(LogEvent logEvent)
         {
-            var sb = new StringBuilder();
+            byte[] data = Convert(logEvent);
 
+            try
+            {
+                _socket.Send(data);
+            }
+            catch (SocketException)
+            {
+                // Try to reconnect and log
+                DisposeSocket();
+                Connect();
+                _socket.Send(data);
+            }
+        }
+
+        private byte[] Convert(LogEvent logEvent)
+        {
+            var sb = new StringBuilder();
             using (var sw = new StringWriter(sb))
                 _formatter.Format(logEvent, sw);
-
-            _socket.Send(Encoding.UTF8.GetBytes(sb.ToString()));
+            return Encoding.UTF8.GetBytes(sb.ToString());
         }
 
-        /// <inheritdoc/>
-        protected virtual void Dispose(bool disposing)
+        private void Connect()
         {
-            if (!disposedValue)
-            {
-                if (disposing)
-                {
-                    _socket?.Close();
-                    _socket?.Dispose();
-                    _socket = null;
-                }
+            _socket = new Socket(SocketType.Dgram, ProtocolType.Udp);
+            _socket.Connect(_connectionInfo.Host, _connectionInfo.Port);
+        }
 
-                disposedValue = true;
-            }
+        private void DisposeSocket()
+        {
+            _socket?.Close();
+            _socket?.Dispose();
+            _socket = null;
         }
 
-        /// <inheritdoc/>
-        public void Dispose()
+        private static SplunkJsonFormatter CreateDefaultFormatter(IFormatProvider formatProvider, bool renderTemplate)
         {
-            Dispose(true);
+            return new SplunkJsonFormatter(renderTemplate, formatProvider);
         }
     }
 }