Skip to content

Commit 4d56716

Browse files
authored
chore(npm): bump, fix js-build sonar step (#78)
1 parent 1b48407 commit 4d56716

File tree

8 files changed

+6652
-7756
lines changed

8 files changed

+6652
-7756
lines changed

.github/workflows/DotNET-reporting-on-build.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@ on:
1111
jobs:
1212
upload:
1313
runs-on: ubuntu-latest
14-
if: >
15-
github.event.workflow_run.event == 'pull_request' &&
16-
github.event.workflow_run.conclusion == 'success'
14+
if: github.event.workflow_run.conclusion == 'success'
1715
steps:
1816
- uses: phoenix-actions/test-reporting@v9
1917
with:

.github/workflows/JS-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949

5050
- name: SonarCloud run
5151
uses: SonarSource/sonarcloud-github-action@master
52-
if: needs.pr-check.outputs.number == 'null'
52+
if: github.event_name != 'pull_request'
5353
env:
5454
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
5555
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN_UI }}

.github/workflows/JS-reporting-on-build.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@ on:
1111
jobs:
1212
upload:
1313
runs-on: ubuntu-latest
14-
if: >
15-
github.event.workflow_run.event == 'pull_request' &&
16-
github.event.workflow_run.conclusion == 'success'
14+
if: github.event.workflow_run.conclusion == 'success'
1715
steps:
1816
- uses: phoenix-actions/test-reporting@v9
1917
with:

.github/workflows/Release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ jobs:
7878

7979
- name: SonarCloud run
8080
uses: SonarSource/sonarcloud-github-action@master
81-
if: needs.pr-check.outputs.number == 'null'
81+
if: github.event_name != 'pull_request'
8282
env:
8383
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
8484
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN_UI }}

build/CustomGithubActionsAttribute.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public override void Write(CustomFileWriter writer)
103103
{
104104
writer.WriteLine("uses: SonarSource/sonarcloud-github-action@master");
105105

106-
writer.WriteLine("if: needs.pr-check.outputs.number == 'null'");
106+
writer.WriteLine("if: github.event_name != 'pull_request'");
107107

108108
writer.WriteLine("env:");
109109
using (writer.Indent())

0 commit comments

Comments
 (0)