code improvments

Author: traien

src/Serilog.Ui.Web/Authorization/BasicAuthenticationFilter.cs

@@ -12,7 +12,7 @@ public class BasicAuthenticationFilter : IUiAuthorizationFilter
     public string Pass { get; set; }
 
     private const string AuthenticationScheme = "Basic";
-    private const string AuthenticationCookieName = "SerilogAuth";
+    internal const string AuthenticationCookieName = "SerilogAuth";
 
     public bool Authorize(HttpContext httpContext)
     {
@@ -25,7 +25,7 @@ public bool Authorize(HttpContext httpContext)
             if (!string.IsNullOrWhiteSpace(authCookie))
             {
                 var hashedCredentials = EncryptCredentials(User, Pass);
-                isAuthenticated = string.Equals(authCookie, hashedCredentials, StringComparison.OrdinalIgnoreCase);
+                isAuthenticated = authCookie.Equals(hashedCredentials, StringComparison.OrdinalIgnoreCase);
             }
         }
         else
@@ -53,9 +53,9 @@ public bool Authorize(HttpContext httpContext)
         return isAuthenticated;
     }
 
-    public string EncryptCredentials(string user, string pass)
+    private string EncryptCredentials(string user, string pass)
     {
-        var sha256 = SHA256.Create();
+        using var sha256 = SHA256.Create();
         var hashBytes = sha256.ComputeHash(Encoding.UTF8.GetBytes($"{user}:{pass}"));
         var hashedCredentials = BitConverter.ToString(hashBytes).Replace("-", "").ToLower();
         return hashedCredentials;
@@ -81,7 +81,7 @@ private bool CredentialsMatch((string Username, string Password) tokens)
     private void SetChallengeResponse(HttpContext httpContext)
     {
         httpContext.Response.StatusCode = 401;
-        httpContext.Response.Headers.Append("WWW-Authenticate", "Basic realm=\"SeriLog Ui\"");
+        httpContext.Response.Headers.Append("WWW-Authenticate", "Basic realm=\"Serilog UI\"");
         httpContext.Response.WriteAsync("Authentication is required.");
     }
 }

tests/Serilog.Ui.Web.Tests/Authorization/BasicAuthenticationFilterTests.cs

@@ -1,3 +1,4 @@
+using System.Linq;
 using FluentAssertions;
 using Microsoft.AspNetCore.Http;
 using Microsoft.Net.Http.Headers;
@@ -23,9 +24,11 @@ public async Task Authorize_WithValidCredentials_ShouldReturnTrue()
 
         // Act
         var result = filter.Authorize(httpContext);
+        var authCookie = httpContext.Response.GetTypedHeaders().SetCookie.FirstOrDefault(sc => sc.Name == BasicAuthenticationFilter.AuthenticationCookieName);
 
         // Assert
         result.Should().BeTrue();
+        authCookie.Should().NotBeNull();
     }
 
     [Fact]
@@ -66,6 +69,6 @@ public async Task Authorize_WithMissingAuthorizationHeader_ShouldSetChallengeRes
         // Assert
         result.Should().BeFalse();
         httpContext.Response.StatusCode.Should().Be(401);
-        httpContext.Response.Headers[HeaderNames.WWWAuthenticate].Should().Contain("Basic realm=\"Hangfire Dashboard\"");
+        httpContext.Response.Headers[HeaderNames.WWWAuthenticate].Should().Contain("Basic realm=\"Serilog UI\"");
     }
 }