fix couple tests

Author: followynne

src/Serilog.Ui.Web/src/__tests__/components/Search/PagingLeftColumn.spec.tsx

@@ -11,7 +11,6 @@ const defaultReturn: SearchResult = {
 };
 const mockQueryLogs = {
   data: defaultReturn,
-  refetch: vi.fn(),
 };
 vi.mock('../../../app/hooks/useQueryLogs', () => {
   return {
@@ -66,7 +65,6 @@ describe('Paging', () => {
 
     expect(mockChangePage).toHaveBeenCalledTimes(1);
     expect(inputEntriesPerPage.value).toBe('25');
-    expect(mockQueryLogs.refetch).toHaveBeenCalledTimes(2);
   });
 
   it('changes sort on value', async () => {
@@ -88,7 +86,6 @@ describe('Paging', () => {
     await userEvent.selectOptions(listBox, selectOption);
 
     expect(sortOn.value).toBe('Level');
-    expect(mockQueryLogs.refetch).toHaveBeenCalledTimes(2);
   });
 
   it('changes sort by value', async () => {
@@ -103,7 +100,6 @@ describe('Paging', () => {
     await userEvent.click(sortBy);
 
     expect(sortBy.innerHTML).toContain('sort-ascending');
-    expect(mockQueryLogs.refetch).toHaveBeenCalledTimes(2);
   });
 
   it('disables the sort on field', async () => {

src/Serilog.Ui.Web/src/__tests__/components/Search/PagingRightColumn.spec.tsx

@@ -12,7 +12,6 @@ const defaultReturn: () => SearchResult = () => ({
 });
 const mockQueryLogs = {
   data: defaultReturn(),
-  refetch: vi.fn(),
 };
 vi.mock('../../../app/hooks/useQueryLogs', async () => {
   return {
@@ -47,7 +46,6 @@ describe('PagingRightColumn', () => {
     expect(screen.getByRole('button', { name: 'pagination-dialog' })).not.toBeDisabled();
 
     field.value = '2';
-    expect(mockQueryLogs.refetch).toHaveBeenCalledTimes(1);
   });
 
   it('calls onChange on pagination button click', async () => {
@@ -75,6 +73,5 @@ describe('PagingRightColumn', () => {
     await userEvent.click(setPage);
 
     expect(field.onChange).toHaveBeenCalledTimes(1);
-    expect(mockQueryLogs.refetch).toHaveBeenCalledTimes(1);
   });
 });

src/Serilog.Ui.Web/src/__tests__/components/ShellStructure/FilterButton.spec.tsx

@@ -44,21 +44,28 @@ describe('FilterButton', () => {
     });
   });
 
-  it('clears search state and refetch data', async () => {
-    render(<FilterButton />);
+  it.each([
+    { resetRes: true, times: 1 },
+    { resetRes: false, times: 0 },
+  ])(
+    'clears search state and refetch data if reset returns $resetRes',
+    async ({ resetRes, times }) => {
+      useMocks.reset.mockImplementationOnce(() => resetRes);
 
-    const filterBtn = screen.getByRole('button');
-    expect(filterBtn).toBeInTheDocument();
+      render(<FilterButton />);
 
-    await userEvent.click(filterBtn);
+      const filterBtn = screen.getByRole('button');
 
-    expect(useMocks.refetch).toHaveBeenCalledOnce();
+      expect(filterBtn).toBeInTheDocument();
 
-    await userEvent.click(screen.getByRole('button', { name: 'reset filters' }));
+      await userEvent.click(filterBtn);
 
-    expect(useMocks.reset).toHaveBeenCalledOnce();
-    expect(useMocks.refetch).toHaveBeenCalledTimes(2);
-  });
+      await userEvent.click(screen.getByRole('button', { name: 'reset filters' }));
+
+      expect(useMocks.reset).toHaveBeenCalledOnce();
+      expect(useMocks.refetch).toHaveBeenCalledTimes(times);
+    },
+  );
 
   it('closes modal on resize', async () => {
     render(<FilterButton />);