Skip to content

Commit 080a1d8

Browse files
committed
Updated SqlClient to 5.0.1
Breaking change: "Encrypt=False" must now be explicitly set in connection string if no encryption should be used. Otherwise an SqlException will occurr. Details: https://github.com/dotnet/SqlClient/blob/main/release-notes/4.0/4.0.0.md#breaking-changes
1 parent cc8c114 commit 080a1d8

File tree

9 files changed

+17
-10
lines changed

9 files changed

+17
-10
lines changed

README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ A Serilog sink that writes events to Microsoft SQL Server. This sink will write
1919
* [External Configuration Syntax](#external-configuration-syntax)
2020
* [Troubleshooting](#troubleshooting)
2121
* [Querying Property Data](#querying-property-data)
22+
* [Breaking Changes](#breaking-changes)
2223
* [Deprecated Features](#deprecated-features)
2324

2425
## Quick Start
@@ -790,6 +791,12 @@ WHERE
790791
[Properties].value('(//property[@key="Controller"]/node())[1]', 'nvarchar(max)') = 'UserController'
791792
```
792793

794+
## Breaking Changes
795+
796+
### Release 6.0.0
797+
798+
Micosoft.Data.SqlClient was upgraded to >4.0.0 which introduces a breaking change regarding the connection strings. If your SQL Server does not use encryption you have to explicitly specify this in the connection string by adding `Encrypt=False`. Otherwise the connection will fail with an SqlException. Refer to the [SqlClient documentation](https://github.com/dotnet/SqlClient/blob/main/release-notes/4.0/4.0.0.md#breaking-changes) for details.
799+
793800
## Deprecated Features
794801

795802
Feature | Notes

sample/AppConfigDemo/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ namespace AppConfigDemo
88
{
99
public static class Program
1010
{
11-
private const string _connectionString = "Server=localhost;Database=LogTest;Integrated Security=SSPI;";
11+
private const string _connectionString = "Server=localhost;Database=LogTest;Integrated Security=SSPI;Encrypt=False;";
1212
private const string _schemaName = "dbo";
1313
private const string _tableName = "LogEvents";
1414

sample/CombinedConfigDemo/appsettings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
}
88
},
99
"ConnectionStrings": {
10-
"LogDatabase": "Server=localhost;Database=LogTest;Integrated Security=SSPI;"
10+
"LogDatabase": "Server=localhost;Database=LogTest;Integrated Security=SSPI;Encrypt=False;"
1111
},
1212
"Serilog": {
1313
"SinkOptions": {

sample/CustomLogEventFormatterDemo/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ namespace CustomLogEventFormatterDemo
77
{
88
public static class Program
99
{
10-
private const string _connectionString = "Server=localhost;Database=LogTest;Integrated Security=SSPI;";
10+
private const string _connectionString = "Server=localhost;Database=LogTest;Integrated Security=SSPI;Encrypt=False;";
1111
private const string _schemaName = "dbo";
1212
private const string _tableName = "LogEvents";
1313

sample/NetStandardDemo/NetStandardDemoLib/Initializer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ namespace NetStandardDemoLib
88
{
99
public static class Initializer
1010
{
11-
private const string _connectionString = "Server=localhost;Database=LogTest;Integrated Security=SSPI;";
11+
private const string _connectionString = "Server=localhost;Database=LogTest;Integrated Security=SSPI;Encrypt=False;";
1212
private const string _tableName = "LogEvents";
1313

1414
public static LoggerConfiguration CreateLoggerConfiguration()

sample/WorkerServiceDemo/appsettings.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
{
1414
"Name": "MSSqlServer",
1515
"Args": {
16-
"connectionString": "Server=localhost;Database=LogTest;Integrated Security=SSPI;",
16+
"connectionString": "Server=localhost;Database=LogTest;Integrated Security=SSPI;Encrypt=False;",
1717
"sinkOptionsSection": {
1818
"tableName": "LogEvents",
1919
"autoCreateSqlTable": true
@@ -42,7 +42,7 @@
4242
{
4343
"Name": "MSSqlServer",
4444
"Args": {
45-
"connectionString": "Server=localhost;Database=LogTest;Integrated Security=SSPI;",
45+
"connectionString": "Server=localhost;Database=LogTest;Integrated Security=SSPI;Encrypt=False;",
4646
"restrictedToMinimumLevel": "Information",
4747
"logEventFormatter": "WorkerServiceDemo.CustomLogEventFormatter::Formatter, WorkerServiceDemo",
4848
"sinkOptionsSection": {

src/Serilog.Sinks.MSSqlServer/Serilog.Sinks.MSSqlServer.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232

3333
<ItemGroup>
3434
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
35-
<PackageReference Include="Microsoft.Data.SqlClient" Version="3.1.1" />
35+
<PackageReference Include="Microsoft.Data.SqlClient" Version="5.0.1" />
3636
<PackageReference Include="Microsoft.Extensions.Configuration" Version="6.0.1" />
3737
<PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="6.0.0" />
3838
<PackageReference Include="Serilog" Version="2.12.0" />

test/Serilog.Sinks.MSSqlServer.Tests/Configuration/Implementations/Microsoft.Extensions.Configuration/MicrosoftExtensionsConnectionStringProviderTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public class MicrosoftExtensionsConnectionStringProviderTests
1313
public void GetConnectionStringCalledWithConnectionStringReturnsSameValue()
1414
{
1515
// Arrange
16-
const string connectionString = "Server=localhost;Database=LogTest;Integrated Security=SSPI;";
16+
const string connectionString = "Server=localhost;Database=LogTest;Integrated Security=SSPI;Encrypt=False;";
1717
var configurationMock = new Mock<IConfiguration>();
1818
var sut = new MicrosoftExtensionsConnectionStringProvider();
1919

@@ -29,7 +29,7 @@ public void GetConnectionStringCalledWithNameItGetsConnectionStringFromConfig()
2929
{
3030
// Arrange
3131
const string connectionStringName = "LogDatabase";
32-
const string connectionString = "Server=localhost;Database=LogTest;Integrated Security=SSPI;";
32+
const string connectionString = "Server=localhost;Database=LogTest;Integrated Security=SSPI;Encrypt=False;";
3333
var configurationMock = new Mock<IConfiguration>();
3434
var configSectionMock = new Mock<IConfigurationSection>();
3535
configurationMock.Setup(c => c.GetSection(It.IsAny<string>())).Returns(configSectionMock.Object);

test/Serilog.Sinks.MSSqlServer.Tests/Sinks/MSSqlServer/Dependencies/SinkDependenciesFactoryTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ namespace Serilog.Sinks.MSSqlServer.Tests.Dependencies
88
[Trait(TestCategory.TraitName, TestCategory.Unit)]
99
public class SinkDependenciesFactoryTests
1010
{
11-
private const string _connectionString = "Server=localhost;Database=LogTest;Integrated Security=SSPI;";
11+
private const string _connectionString = "Server=localhost;Database=LogTest;Integrated Security=SSPI;Encrypt=False;";
1212
private readonly MSSqlServerSinkOptions _sinkOptions;
1313
private readonly Serilog.Sinks.MSSqlServer.ColumnOptions _columnOptions;
1414

0 commit comments

Comments
 (0)