Throw sink init exceptions

Currently exceptions that occurr during automatic db or table creation when the sink is initialized, are not thrown to the caller/client program. This could hide or delay fatal problems from showing and was changed in this commit.

Related: #478

Author: ckadluba

src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/Platform/SqlCommandExecutor.cs

@@ -32,6 +32,7 @@ public void Execute()
             catch (Exception ex)
             {
                 HandleException(ex);
+                throw;
             }
         }
 

test/Serilog.Sinks.MSSqlServer.Tests/Sinks/MSSqlServer/Platform/SqlCommandExecutorTests.cs

@@ -100,7 +100,7 @@ public void HandlesExceptionFromSqlWriter()
             };
 
             // Act
-            _sut.Execute();
+            Assert.Throws<InvalidOperationException>(() => _sut.Execute());
 
             // Assert
             Assert.True(handlerCalled);
@@ -124,7 +124,7 @@ public void HandlesExceptionFromConnectionFactory()
             };
 
             // Act
-            _sut.Execute();
+            Assert.Throws<InvalidOperationException>(() => _sut.Execute());
 
             // Assert
             Assert.True(handlerCalled);
@@ -148,7 +148,7 @@ public void HandlesExceptionFromConnection()
             };
 
             // Act
-            _sut.Execute();
+            Assert.Throws<InvalidOperationException>(() => _sut.Execute());
 
             // Assert
             Assert.True(handlerCalled);
@@ -172,7 +172,7 @@ public void HandlesExceptionFromCommand()
             };
 
             // Act
-            _sut.Execute();
+            Assert.Throws<InvalidOperationException>(() => _sut.Execute());
 
             // Assert
             Assert.True(handlerCalled);