Merge pull request #56 from colin-young/fb-triggers

Trigger support

Author: nblumhardt

src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/ColumnOptions.cs

@@ -63,6 +63,11 @@ public ICollection<StandardColumn> Store
             }
         }
 
+        /// <summary>
+        /// Indicates if triggers should be disabled when inserting log entries.
+        /// </summary>
+        public bool DisableTriggers { get; set; }
+
         /// <summary>
         ///     Additional columns for data storage.
         /// </summary>

src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/MSSqlServerSink.cs

@@ -129,7 +129,10 @@ protected override async Task EmitBatchAsync(IEnumerable<LogEvent> events)
                 using (var cn = new SqlConnection(_connectionString))
                 {
                     await cn.OpenAsync().ConfigureAwait(false);
-                    using (var copy = new SqlBulkCopy(cn))
+                    using (var copy = _columnOptions.DisableTriggers
+                            ? new SqlBulkCopy(cn)
+                            : new SqlBulkCopy(cn, SqlBulkCopyOptions.CheckConstraints | SqlBulkCopyOptions.FireTriggers, null)
+                    )
                     {
                         copy.DestinationTableName = _tableName;
                         foreach (var column in _eventsTable.Columns)

test/Serilog.Sinks.MSSqlServer.Tests/TestTriggersOnLogTable.cs

@@ -0,0 +1,104 @@
+using System;
+using System.Data.SqlClient;
+using System.Diagnostics;
+using Dapper;
+using FluentAssertions;
+using Xunit;
+
+namespace Serilog.Sinks.MSSqlServer.Tests
+{
+    [Collection("LogTest")]
+    public class TestTriggersOnLogTable
+    {
+        [Fact]
+        public void TestTriggerOnLogTableFire()
+        {
+            // arrange
+            var logTriggerTableName = $"Trigger{DatabaseFixture.LogTableName}Trigger";
+            var logTableName = $"{DatabaseFixture.LogTableName}WithTrigger";
+            var loggerConfiguration = new LoggerConfiguration();
+            Log.Logger = loggerConfiguration.WriteTo.MSSqlServer(
+                connectionString: DatabaseFixture.LogEventsConnectionString,
+                tableName: logTableName,
+                autoCreateSqlTable: true,
+                batchPostingLimit: 1,
+                period: TimeSpan.FromSeconds(10),
+                columnOptions: new ColumnOptions())
+                .CreateLogger();
+
+            using (var conn = new SqlConnection(DatabaseFixture.LogEventsConnectionString))
+            {
+                conn.Execute($"CREATE TABLE {logTriggerTableName} ([Id] [UNIQUEIDENTIFIER] NOT NULL, [Data] [NVARCHAR](50) NOT NULL)");
+                conn.Execute($@"CREATE TRIGGER {logTriggerTableName}NoTrigger ON {logTableName} 
+AFTER INSERT 
+AS
+BEGIN 
+INSERT INTO {logTriggerTableName} VALUES (NEWID(), 'Data') 
+END");
+            }
+
+            // act
+            const string loggingInformationMessage = "Logging Information message";
+            Log.Information(loggingInformationMessage);
+
+            Log.CloseAndFlush();
+
+            // assert
+            using (var conn = new SqlConnection(DatabaseFixture.LogEventsConnectionString))
+            {
+                var logTriggerEvents = conn.Query<TestTriggerEntry>($"SELECT * FROM {logTriggerTableName}");
+
+                logTriggerEvents.Should().NotBeNullOrEmpty();
+            }
+        }
+
+        [Fact]
+        public void TestOptionsDisableTriggersOnLogTable()
+        {
+            // arrange
+            var options = new ColumnOptions { DisableTriggers = true };
+            var logTriggerTableName = $"{DatabaseFixture.LogTableName}NoTrigger";
+            var logTableName = $"{DatabaseFixture.LogTableName}WithTrigger";
+            var loggerConfiguration = new LoggerConfiguration();
+            Log.Logger = loggerConfiguration.WriteTo.MSSqlServer(
+                connectionString: DatabaseFixture.LogEventsConnectionString,
+                tableName: logTableName,
+                autoCreateSqlTable: true,
+                batchPostingLimit: 1,
+                period: TimeSpan.FromSeconds(10),
+                columnOptions: options)
+                .CreateLogger();
+
+            using (var conn = new SqlConnection(DatabaseFixture.LogEventsConnectionString))
+            {
+                conn.Execute($"CREATE TABLE {logTriggerTableName} ([Id] [UNIQUEIDENTIFIER] NOT NULL, [Data] [NVARCHAR](50) NOT NULL)");
+                conn.Execute($@"CREATE TRIGGER {logTableName}NoTrigger ON {logTableName} 
+AFTER INSERT 
+AS
+BEGIN
+INSERT INTO {logTriggerTableName} VALUES (NEWID(), 'Data')
+END");
+            }
+
+            // act
+            const string loggingInformationMessage = "Logging Information message";
+            Log.Information(loggingInformationMessage);
+
+            Log.CloseAndFlush();
+
+            // assert
+            using (var conn = new SqlConnection(DatabaseFixture.LogEventsConnectionString))
+            {
+                var logTriggerEvents = conn.Query<TestTriggerEntry>($"SELECT * FROM {logTriggerTableName}");
+
+                logTriggerEvents.Should().BeEmpty();
+            }
+        }
+
+        internal class TestTriggerEntry
+        {
+            public Guid Id { get; set; }
+            public string Data { get; set; }
+        }
+    }
+}