Skip to content

Commit 6685b70

Browse files
committed
Add varbinary data type.
1 parent ee7e348 commit 6685b70

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

src/Serilog.Sinks.MSSqlServer/Configuration/ColumnConfig.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public string ColumnName
5252
/// Type of column as it exists in SQL Server
5353
/// </summary>
5454
[ConfigurationProperty("DataType", IsRequired = true, IsKey = false, DefaultValue ="varchar")]
55-
[RegexStringValidator("(bigint)|(bit)|(binary)|(char)|(date)|(datetime)|(datetime2)|(decimal)|(float)|(int)|(money)|(nchar)|(ntext)|(numeric)|(nvarchar)|(real)|(smalldatetime)|(smallint)|(smallmoney)|(text)|(time)|(uniqueidentifier)|(varchar)")]
55+
[RegexStringValidator("(bigint)|(bit)|(binary)|(varbinary)|(char)|(date)|(datetime)|(datetime2)|(decimal)|(float)|(int)|(money)|(nchar)|(ntext)|(numeric)|(nvarchar)|(real)|(smalldatetime)|(smallint)|(smallmoney)|(text)|(time)|(uniqueidentifier)|(varchar)")]
5656
public string DataType
5757
{
5858
get { return (string)this["DataType"]; }

src/Serilog.Sinks.MSSqlServer/LoggerConfigurationMSSqlServerExtensions.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ private static void GenerateDataColumnsFromConfig(MSSqlServerConfigurationSectio
142142
case "bigint":
143143
dataType = Type.GetType("System.Int64");
144144
break;
145+
case "varbinary":
145146
case "binary":
146147
dataType = Type.GetType("System.Byte[]");
147148
column.ExtendedProperties["DataLength"] = c.DataLength;

src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/SqlTableCreator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ private static string SqlGetType(object type, int columnSize, int numericPrecisi
102102
break;
103103

104104
case "System.Byte[]":
105-
sqlType = columnSize == -1 ? "VARBINARY" : "BINARY(" + columnSize.ToString() + ")";
105+
sqlType = columnSize == -1 ? "VARBINARY(MAX)" : "VARBINARY(" + columnSize.ToString() + ")";
106106
break;
107107

108108
case "System.String":

0 commit comments

Comments
 (0)