Skip to content

Commit 930e900

Browse files
osududemivano
authored andcommitted
Fix dispose ordering bug (#93) (#95)
1 parent b12e44d commit 930e900

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,3 +182,4 @@ UpgradeLog*.htm
182182
# Microsoft Fakes
183183
FakesAssemblies/
184184
/.vs/serilog-sinks-mssqlserver/v15/sqlite3
185+
/.vs/serilog-sinks-mssqlserver/v15/Server/sqlite3

src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/MSSqlServerSink.cs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public class MSSqlServerSink : PeriodicBatchingSink
4545

4646
readonly string _connectionString;
4747

48-
readonly DataTable _eventsTable;
48+
private DataTable _eventsTable;
4949
readonly IFormatProvider _formatProvider;
5050
readonly string _tableName;
5151
readonly string _schemaName;
@@ -411,10 +411,13 @@ private static bool TryChangeType(object obj, Type type, out object conversion)
411411
/// <param name="disposing"></param>
412412
protected override void Dispose(bool disposing)
413413
{
414+
base.Dispose(disposing);
415+
414416
if (_eventsTable != null)
417+
{
415418
_eventsTable.Dispose();
416-
417-
base.Dispose(disposing);
419+
_eventsTable = null;
420+
}
418421
}
419422
}
420423
}

0 commit comments

Comments
 (0)