Removed unnecessary private fields in sink and audit sink classes.

Author: ckadluba

src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/MSSqlServerAuditSink.cs

@@ -28,7 +28,6 @@ namespace Serilog.Sinks.MSSqlServer
     /// </summary>
     public class MSSqlServerAuditSink : ILogEventSink, IDisposable
     {
-        private readonly SinkOptions _sinkOptions;
         private readonly ISqlLogEventWriter _sqlLogEventWriter;
 
         /// <summary>
@@ -84,8 +83,7 @@ internal MSSqlServerAuditSink(
             ColumnOptions columnOptions,
             SinkDependencies sinkDependencies)
         {
-            _sinkOptions = sinkOptions;
-            if (_sinkOptions?.TableName == null)
+            if (sinkOptions?.TableName == null)
             {
                 throw new InvalidOperationException("Table name must be specified!");
             }
@@ -101,16 +99,16 @@ internal MSSqlServerAuditSink(
             }
             _sqlLogEventWriter = sinkDependencies?.SqlLogEventWriter ?? throw new InvalidOperationException($"SqlLogEventWriter is not initialized!");
 
-            if (_sinkOptions.AutoCreateSqlTable)
+            if (sinkOptions.AutoCreateSqlTable)
             {
                 if (sinkDependencies?.DataTableCreator == null)
                 {
                     throw new InvalidOperationException($"DataTableCreator is not initialized!");
                 }
 
-                using (var eventTable = sinkDependencies.DataTableCreator.CreateDataTable(_sinkOptions.TableName, columnOptions))
+                using (var eventTable = sinkDependencies.DataTableCreator.CreateDataTable(sinkOptions.TableName, columnOptions))
                 {
-                    sinkDependencies.SqlTableCreator.CreateTable(_sinkOptions.SchemaName, _sinkOptions.TableName, eventTable, columnOptions);
+                    sinkDependencies.SqlTableCreator.CreateTable(sinkOptions.SchemaName, sinkOptions.TableName, eventTable, columnOptions);
                 }
             }
         }

src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/MSSqlServerSink.cs

@@ -30,8 +30,6 @@ namespace Serilog.Sinks.MSSqlServer
     /// </summary>
     public class MSSqlServerSink : PeriodicBatchingSink
     {
-        private readonly SinkOptions _sinkOptions;
-        private readonly ColumnOptions _columnOptions;
         private readonly ISqlBulkBatchWriter _sqlBulkBatchWriter;
         private readonly DataTable _eventTable;
 
@@ -108,14 +106,13 @@ internal MSSqlServerSink(
             SinkDependencies sinkDependencies)
             : base(sinkOptions?.BatchPostingLimit ?? DefaultBatchPostingLimit, sinkOptions?.BatchPeriod ?? DefaultPeriod)
         {
-            _sinkOptions = sinkOptions;
             if (sinkOptions?.TableName == null)
             {
                 throw new InvalidOperationException("Table name must be specified!");
             }
 
-            _columnOptions = columnOptions ?? new ColumnOptions();
-            _columnOptions.FinalizeConfigurationForSinkConstructor();
+            columnOptions = columnOptions ?? new ColumnOptions();
+            columnOptions.FinalizeConfigurationForSinkConstructor();
 
             if (sinkDependencies == null)
             {
@@ -130,13 +127,13 @@ internal MSSqlServerSink(
             }
             _eventTable = sinkDependencies.DataTableCreator.CreateDataTable(sinkOptions.TableName, columnOptions);
 
-            if (_sinkOptions.AutoCreateSqlTable)
+            if (sinkOptions.AutoCreateSqlTable)
             {
                 if (sinkDependencies?.SqlBulkBatchWriter == null)
                 {
                     throw new InvalidOperationException($"SqlTableCreator is not initialized!");
                 }
-                sinkDependencies.SqlTableCreator.CreateTable(sinkOptions.SchemaName, sinkOptions.TableName, _eventTable, _columnOptions);
+                sinkDependencies.SqlTableCreator.CreateTable(sinkOptions.SchemaName, sinkOptions.TableName, _eventTable, columnOptions);
             }
         }