Removed SelfLog verify from tests. It is static an not deterministic when tests run in parallel.

Author: ckadluba

test/Serilog.Sinks.MSSqlServer.Tests/Sinks/MSSqlServer/Platform/SqlBulkBatchWriterTests.cs

@@ -178,62 +178,50 @@ public async Task WriteBatchClearsDataTable()
         }
 
         [Fact]
-        public void WriteBatchWritesSelfLogAndRethrowsIfSqlConnectionFactoryCreateThrows()
+        public void WriteBatchRethrowsIfSqlConnectionFactoryCreateThrows()
         {
             // Arrange
-            var selfLogWritten = false;
-            SelfLog.Enable(w => selfLogWritten = true);
             _sqlConnectionFactoryMock.Setup(f => f.Create()).Callback(() => throw new Exception());
             var logEvents = CreateLogEvents();
 
             // Act + assert
             Assert.ThrowsAsync<Exception>(() => _sut.WriteBatch(logEvents, _dataTable));
-            Assert.True(selfLogWritten);
         }
 
         [Fact]
-        public void WriteBatchWritesSelfLogAndRethrowsIfSqlConnectionOpenAsyncThrows()
+        public void WriteBatchRethrowsIfSqlConnectionOpenAsyncThrows()
         {
             // Arrange
-            var selfLogWritten = false;
-            SelfLog.Enable(w => selfLogWritten = true);
             _sqlConnectionWrapperMock.Setup(c => c.OpenAsync()).Callback(() => throw new Exception());
             var logEvents = CreateLogEvents();
 
             // Act + assert
             Assert.ThrowsAsync<Exception>(() => _sut.WriteBatch(logEvents, _dataTable));
-            Assert.True(selfLogWritten);
         }
 
         [Fact]
-        public void WriteBatchWritesSelfLogAndRethrowsIfSqlBulkCopyWriterAddSqlBulkCopyColumnMappingThrows()
+        public void WriteBatchRethrowsIfSqlBulkCopyWriterAddSqlBulkCopyColumnMappingThrows()
         {
             // Arrange
-            var selfLogWritten = false;
-            SelfLog.Enable(w => selfLogWritten = true);
             _sqlBulkCopyWrapper.Setup(c => c.AddSqlBulkCopyColumnMapping(It.IsAny<string>(), It.IsAny<string>()))
                 .Callback(() => throw new Exception());
             var logEvents = CreateLogEvents();
             _dataTable.Columns.Add(new DataColumn("ColumnName"));
 
             // Act + assert
             Assert.ThrowsAsync<Exception>(() => _sut.WriteBatch(logEvents, _dataTable));
-            Assert.True(selfLogWritten);
         }
 
         [Fact]
-        public void WriteBatchWritesSelfLogAndRethrowsIfSqlBulkCopyWriterWriteToServerAsyncThrows()
+        public void WriteBatchRethrowsIfSqlBulkCopyWriterWriteToServerAsyncThrows()
         {
             // Arrange
-            var selfLogWritten = false;
-            SelfLog.Enable(w => selfLogWritten = true);
             _sqlBulkCopyWrapper.Setup(c => c.WriteToServerAsync(It.IsAny<DataTable>()))
                 .Callback(() => throw new Exception());
             var logEvents = CreateLogEvents();
 
             // Act + assert
             Assert.ThrowsAsync<Exception>(() => _sut.WriteBatch(logEvents, _dataTable));
-            Assert.True(selfLogWritten);
         }
 
         private static List<LogEvent> CreateLogEvents()

test/Serilog.Sinks.MSSqlServer.Tests/Sinks/MSSqlServer/Platform/SqlLogEventWriterTests.cs

@@ -198,53 +198,42 @@ public void WriteEventCallsLogEventDataGeneratorGetColumnsAndValuesWithLogEvent(
         }
 
         [Fact]
-        public void WriteEventWritesSelfLogAndRethrowsIfSqlConnectionFactoryCreateThrows()
+        public void WriteEventRethrowsIfSqlConnectionFactoryCreateThrows()
         {
             // Arrange
-            var selfLogWritten = false;
-            SelfLog.Enable(w => selfLogWritten = true);
             _sqlConnectionFactoryMock.Setup(f => f.Create()).Callback(() => throw new Exception());
             var logEvent = TestLogEventHelper.CreateLogEvent();
 
             // Act + assert
             Assert.Throws<Exception>(() => _sut.WriteEvent(logEvent));
-            Assert.True(selfLogWritten);
         }
 
         [Fact]
-        public void WriteEventWritesSelfLogAndRethrowsIfSqlConnectionCreateCommandThrows()
+        public void WriteEventRethrowsIfSqlConnectionCreateCommandThrows()
         {
             // Arrange
-            var selfLogWritten = false;
-            SelfLog.Enable(w => selfLogWritten = true);
             _sqlConnectionWrapperMock.Setup(c => c.CreateCommand()).Callback(() => throw new Exception());
             var logEvent = TestLogEventHelper.CreateLogEvent();
 
             // Act + assert
             Assert.Throws<Exception>(() => _sut.WriteEvent(logEvent));
-            Assert.True(selfLogWritten);
         }
 
         [Fact]
-        public void WriteEventWritesSelfLogAndRethrowsIfLogEventDataGeneratorGetColumnsAndValuesThrows()
+        public void WriteEventRethrowsIfLogEventDataGeneratorGetColumnsAndValuesThrows()
         {
             // Arrange
-            var selfLogWritten = false;
-            SelfLog.Enable(w => selfLogWritten = true);
             _logEventDataGeneratorMock.Setup(d => d.GetColumnsAndValues(It.IsAny<LogEvent>())).Callback(() => throw new Exception());
             var logEvent = TestLogEventHelper.CreateLogEvent();
 
             // Act + assert
             Assert.Throws<Exception>(() => _sut.WriteEvent(logEvent));
-            Assert.True(selfLogWritten);
         }
 
         [Fact]
-        public void WriteEventWritesSelfLogAndRethrowsIfSqlCommandAddParameterThrows()
+        public void WriteEventRethrowsIfSqlCommandAddParameterThrows()
         {
             // Arrange
-            var selfLogWritten = false;
-            SelfLog.Enable(w => selfLogWritten = true);
             _sqlCommandWrapperMock.Setup(c => c.AddParameter(It.IsAny<string>(), It.IsAny<object>())).Callback(() => throw new Exception());
             var fieldsAndValues = new List<KeyValuePair<string, object>> { new KeyValuePair<string, object>("FieldName1", "FieldValue1") };
             _logEventDataGeneratorMock.Setup(d => d.GetColumnsAndValues(It.IsAny<LogEvent>()))
@@ -253,21 +242,17 @@ public void WriteEventWritesSelfLogAndRethrowsIfSqlCommandAddParameterThrows()
 
             // Act + assert
             Assert.Throws<Exception>(() => _sut.WriteEvent(logEvent));
-            Assert.True(selfLogWritten);
         }
 
         [Fact]
-        public void WriteEventWritesSelfLogAndRethrowsIfSqlCommandExecuteNonQueryThrows()
+        public void WriteEventRethrowsIfSqlCommandExecuteNonQueryThrows()
         {
             // Arrange
-            var selfLogWritten = false;
-            SelfLog.Enable(w => selfLogWritten = true);
             _sqlCommandWrapperMock.Setup(c => c.ExecuteNonQuery()).Callback(() => throw new Exception());
             var logEvent = TestLogEventHelper.CreateLogEvent();
 
             // Act + assert
             Assert.Throws<Exception>(() => _sut.WriteEvent(logEvent));
-            Assert.True(selfLogWritten);
         }
     }
 }