Removed obsolete .NET Framework 4.5.2 #ifdefs

Author: ckadluba

src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/MSSqlServerSink.cs

@@ -129,11 +129,7 @@ public Task EmitBatchAsync(IEnumerable<LogEvent> events) =>
         /// </summary>
         /// <returns>A completed task</returns>
         public Task OnEmptyBatchAsync() =>
-#if NET452
-            Task.FromResult(false);
-#else
             Task.CompletedTask;
-#endif
 
         /// <summary>
         /// Performs application-defined tasks associated with freeing, releasing, or resetting unmanaged resources.

src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/Platform/SqlClient/SqlBulkCopyWrapper.cs

@@ -1,11 +1,7 @@
 using System;
 using System.Data;
 using System.Threading.Tasks;
-#if NET452
-using System.Data.SqlClient;
-#else
 using Microsoft.Data.SqlClient;
-#endif
 
 namespace Serilog.Sinks.MSSqlServer.Platform.SqlClient
 {

src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/Platform/SqlClient/SqlCommandWrapper.cs

@@ -1,10 +1,6 @@
 using System;
 using System.Data;
-#if NET452
-using System.Data.SqlClient;
-#else
 using Microsoft.Data.SqlClient;
-#endif
 
 namespace Serilog.Sinks.MSSqlServer.Platform.SqlClient
 {

src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/Platform/SqlClient/SqlConnectionStringBuilderWrapper.cs

@@ -1,8 +1,4 @@
-#if NET452
-using System.Data.SqlClient;
-#else
-using Microsoft.Data.SqlClient;
-#endif
+using Microsoft.Data.SqlClient;
 
 namespace Serilog.Sinks.MSSqlServer.Platform.SqlClient
 {

src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/Platform/SqlClient/SqlConnectionWrapper.cs

@@ -1,10 +1,6 @@
 using System;
-#if NET452
-using System.Data.SqlClient;
-#else
-using Microsoft.Data.SqlClient;
-#endif
 using System.Threading.Tasks;
+using Microsoft.Data.SqlClient;
 
 namespace Serilog.Sinks.MSSqlServer.Platform.SqlClient
 {
@@ -16,15 +12,7 @@ internal class SqlConnectionWrapper : ISqlConnectionWrapper
         public SqlConnectionWrapper(string connectionString, string accessToken)
         {
             _sqlConnection = new SqlConnection(connectionString);
-#if NET452
-            if (accessToken != null)
-            {
-                throw new InvalidOperationException(
-                    $"SqlConnection access token is set target framework that does not support it. Refer to MSSQLServer sink documentation for details.");
-            }
-#else
             _sqlConnection.AccessToken = accessToken;
-#endif
         }
 
         public string ConnectionString => _sqlConnection.ConnectionString;

test/Serilog.Sinks.MSSqlServer.Tests/Sinks/MSSqlServer/Platform/SqlClient/SqlBulkCopyWrapperTests.cs

@@ -1,12 +1,8 @@
 using System;
-#if NET452
-using System.Data.SqlClient;
-#else
 using Microsoft.Data.SqlClient;
-#endif
+using Xunit;
 using Serilog.Sinks.MSSqlServer.Platform.SqlClient;
 using Serilog.Sinks.MSSqlServer.Tests.TestUtils;
-using Xunit;
 
 namespace Serilog.Sinks.MSSqlServer.Tests.Platform.SqlClient
 {

test/Serilog.Sinks.MSSqlServer.Tests/Sinks/MSSqlServer/Platform/SqlClient/SqlCommandWrapperTests.cs

@@ -1,9 +1,5 @@
 using System;
-#if NET452
-using System.Data.SqlClient;
-#else
 using Microsoft.Data.SqlClient;
-#endif
 using Xunit;
 using Serilog.Sinks.MSSqlServer.Tests.TestUtils;
 using Serilog.Sinks.MSSqlServer.Platform.SqlClient;

test/Serilog.Sinks.MSSqlServer.Tests/Sinks/MSSqlServer/Platform/SqlClient/SqlConnectionStringBuilderWrapperTests.cs

@@ -1,12 +1,6 @@
-#if NET452
-using System.Data.SqlClient;
-#else
-using Microsoft.Data.SqlClient;
-#endif
-using Xunit;
-using Serilog.Sinks.MSSqlServer.Tests.TestUtils;
+using Xunit;
 using Serilog.Sinks.MSSqlServer.Platform.SqlClient;
-using System;
+using Serilog.Sinks.MSSqlServer.Tests.TestUtils;
 
 namespace Serilog.Sinks.MSSqlServer.Tests.Platform.SqlClient
 {

test/Serilog.Sinks.MSSqlServer.Tests/Sinks/MSSqlServer/Platform/SqlClient/SqlConnectionWrapperTests.cs

@@ -1,30 +1,12 @@
-#if NET452
-using System.Data.SqlClient;
-#else
-using Microsoft.Data.SqlClient;
-#endif
-using Xunit;
+using Xunit;
 using Serilog.Sinks.MSSqlServer.Tests.TestUtils;
 using Serilog.Sinks.MSSqlServer.Platform.SqlClient;
-using System;
 
 namespace Serilog.Sinks.MSSqlServer.Tests.Platform.SqlClient
 {
     [Trait(TestCategory.TraitName, TestCategory.Unit)]
     public class SqlConnectionWrapperTests
     {
-        [Fact]
-        public void InitializeThrowsIfCalledWithAuthenticationTokenOnDotNetFramework452ButNotOnOtherTargets()
-        {
-#if NET452
-            Assert.Throws<InvalidOperationException>(() => new SqlConnectionWrapper(DatabaseFixture.LogEventsConnectionString, "AuthenticationToken"));
-#else
-            // Should not throw
-            using (_ = new SqlConnectionWrapper(@"Data Source=(localdb)\MSSQLLocalDB;Initial Catalog=Master", "AuthenticationToken"))
-            { }
-#endif
-        }
-
         [Fact]
         public void CreateCommandReturnsSqlCommandWrapper()
         {

test/Serilog.Sinks.MSSqlServer.Tests/TestUtils/DatabaseFixture.cs

@@ -1,12 +1,8 @@
 using System;
-#if NET452
-using System.Data.SqlClient;
-#else
-using Microsoft.Data.SqlClient;
-#endif
 using System.Globalization;
 using System.Linq;
 using Dapper;
+using Microsoft.Data.SqlClient;
 
 namespace Serilog.Sinks.MSSqlServer.Tests.TestUtils
 {