Fixed issue #191: Added option EagerlyEmitFirstEvent by implementing new new PeriodicBatchingSink API.

ckadluba · ckadluba · commit bdbd68442047 · 2020-07-30T18:37:04.000+02:00
* Implement new composition based api of PeriodicBatchingSink.
* Added SinkOptions.EagerlyEmitFirstEvent to control if first batch should be written as soon as possible regardless of period and number of events.
* Removed default parameters on internal config extension methods like MSSqlServerInternal(): they can lead to subtle runtime errors and are not useful in this place.
diff --git a/README.md b/README.md
@@ -244,6 +244,7 @@ Basic settings of the sink are configured using the properties in a `SinkOptions
 * `AutoCreateSqlTable`
 * `BatchPostingLimit`
 * `BatchPeriod`
+* `EagerlyEmitFirstEvent`
 * `UseAzureManagedIdentity`
 * `AzureServiceTokenProviderResource`
 
@@ -267,7 +268,12 @@ This setting is not used by the audit sink as it writes each event immediately a
 ### BatchPeriod
 
 Specifies the interval in which the non-audit sink writes a batch of log events to the database. It defaults to 5 seconds.  
-Just like `BatchPostingLimit`, this setting is not used by the audit sink as it is not a batch based sink.
+This setting is not used by the audit sink as it writes each event immediately and not in a batched manner.
+
+### EagerlyEmitFirstEvent
+
+A Flag to eagerly write a batch to the database containing the first received event regardless of `BatchPostingLimit` or `BatchPeriod`. It defaults to ture.  
+This setting is not used by the audit sink as it writes each event immediately and not in a batched manner.
 
 ### UseAzureManagedIdentity
 
diff --git a/sample/AppConfigDemo/App.config b/sample/AppConfigDemo/App.config
@@ -10,6 +10,7 @@
 
     <BatchPostingLimit Value="13" />
     <BatchPeriod Value="00:00:15" />
+    <EagerlyEmitFirstEvent Value="true" />
     
     <AddStandardColumns>
       <add Name="LogEvent" />
diff --git a/sample/CombinedConfigDemo/CombinedConfigDemo.csproj b/sample/CombinedConfigDemo/CombinedConfigDemo.csproj
@@ -13,7 +13,6 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="3.1.4" />
-    <PackageReference Include="Serilog.Sinks.Console" Version="3.1.1" />
   </ItemGroup>
 
   <ItemGroup>
diff --git a/sample/CombinedConfigDemo/Program.cs b/sample/CombinedConfigDemo/Program.cs
@@ -1,4 +1,5 @@
-﻿using System.Diagnostics;
+﻿using System;
+using System.Threading;
 using Microsoft.Extensions.Configuration;
 using Serilog;
 using Serilog.Sinks.MSSqlServer.Sinks.MSSqlServer.Options;
@@ -22,35 +23,37 @@ public static void Main()
             var columnOptionsSection = configuration.GetSection("Serilog:ColumnOptions");
             var sinkOptionsSection = configuration.GetSection("Serilog:SinkOptions");
 
-            Serilog.Debugging.SelfLog.Enable(m => Debug.WriteLine(m));
+            // Legacy interace - do not use this anymore
+            //Log.Logger = new LoggerConfiguration()
+            //    .WriteTo.MSSqlServer(
+            //        connectionString: _connectionStringName,
+            //        tableName: _tableName,
+            //        appConfiguration: configuration,
+            //        autoCreateSqlTable: true,
+            //        columnOptionsSection: columnOptionsSection,
+            //        schemaName: _schemaName)
+            //    .CreateLogger();
 
             // New SinkOptions based interface
-            using (var logger = new LoggerConfiguration()
-                .WriteTo.Console()
+            Log.Logger = new LoggerConfiguration()
                 .WriteTo.MSSqlServer(
                     connectionString: _connectionStringName,
                     sinkOptions: new SinkOptions
                     {
                         TableName = _tableName,
                         SchemaName = _schemaName,
-                        AutoCreateSqlTable = false
+                        AutoCreateSqlTable = true
                     },
                     sinkOptionsSection: sinkOptionsSection,
                     appConfiguration: configuration,
                     columnOptionsSection: columnOptionsSection)
-                .CreateLogger())
-            {
-                logger.Information("Log 1");
-                logger.Information("Log 2");
-                logger.Information("Log 3");
-                logger.Information("Log 4");
-                logger.Information("Log 5");
-                logger.Information("Log 6");
-                logger.Information("Log 7");
-                logger.Information("Log 8");
-                logger.Information("Log 9");
-                logger.Information("Log 10");
-            }
+                .CreateLogger();
+
+            Log.Information("Hello {Name} from thread {ThreadId}", Environment.GetEnvironmentVariable("USERNAME"), Thread.CurrentThread.ManagedThreadId);
+
+            Log.Warning("No coins remain at position {@Position}", new { Lat = 25, Long = 134 });
+
+            Log.CloseAndFlush();
         }
     }
 }
diff --git a/sample/CombinedConfigDemo/appsettings.json b/sample/CombinedConfigDemo/appsettings.json
@@ -11,7 +11,9 @@
   },
   "Serilog": {
     "SinkOptions": {
-      "batchPostingLimit": 500
+      "batchPostingLimit": 5,
+      "batchPeriod": "00:00:15",
+      "eagerlyEmitFirstEvent": true
     },
     "ColumnOptions": {
       "addStandardColumns": [ "LogEvent" ],
diff --git a/src/Serilog.Sinks.MSSqlServer/Configuration/Extensions/Hybrid/LoggerConfigurationMSSqlServerExtensions.cs b/src/Serilog.Sinks.MSSqlServer/Configuration/Extensions/Hybrid/LoggerConfigurationMSSqlServerExtensions.cs
@@ -136,23 +136,25 @@ public static LoggerConfiguration MSSqlServer(
                 logEventFormatter: logEventFormatter,
                 applySystemConfiguration: new ApplySystemConfiguration(),
                 applyMicrosoftExtensionsConfiguration: new ApplyMicrosoftExtensionsConfiguration(),
-                sinkFactory: new MSSqlServerSinkFactory());
+                sinkFactory: new MSSqlServerSinkFactory(),
+                batchingSinkFactory: new PeriodicBatchingSinkFactory());
 
         // Internal overload with parameters used by tests to override the config section and inject mocks
         internal static LoggerConfiguration MSSqlServerInternal(
             this LoggerSinkConfiguration loggerConfiguration,
             string connectionString,
-            SinkOptions sinkOptions = null,
-            IConfigurationSection sinkOptionsSection = null,
-            IConfiguration appConfiguration = null,
-            LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum,
-            IFormatProvider formatProvider = null,
-            ColumnOptions columnOptions = null,
-            IConfigurationSection columnOptionsSection = null,
-            ITextFormatter logEventFormatter = null,
-            IApplySystemConfiguration applySystemConfiguration = null,
-            IApplyMicrosoftExtensionsConfiguration applyMicrosoftExtensionsConfiguration = null,
-            IMSSqlServerSinkFactory sinkFactory = null)
+            SinkOptions sinkOptions,
+            IConfigurationSection sinkOptionsSection,
+            IConfiguration appConfiguration,
+            LogEventLevel restrictedToMinimumLevel,
+            IFormatProvider formatProvider,
+            ColumnOptions columnOptions,
+            IConfigurationSection columnOptionsSection,
+            ITextFormatter logEventFormatter,
+            IApplySystemConfiguration applySystemConfiguration,
+            IApplyMicrosoftExtensionsConfiguration applyMicrosoftExtensionsConfiguration,
+            IMSSqlServerSinkFactory sinkFactory,
+            IPeriodicBatchingSinkFactory batchingSinkFactory)
         {
             if (loggerConfiguration == null)
                 throw new ArgumentNullException(nameof(loggerConfiguration));
@@ -162,7 +164,9 @@ internal static LoggerConfiguration MSSqlServerInternal(
 
             var sink = sinkFactory.Create(connectionString, sinkOptions, formatProvider, columnOptions, logEventFormatter);
 
-            return loggerConfiguration.Sink(sink, restrictedToMinimumLevel);
+            var periodicBatchingSink = batchingSinkFactory.Create(sink, sinkOptions);
+
+            return loggerConfiguration.Sink(periodicBatchingSink, restrictedToMinimumLevel);
         }
 
         /// <summary>
@@ -259,17 +263,17 @@ public static LoggerConfiguration MSSqlServer(
         internal static LoggerConfiguration MSSqlServerInternal(
             this LoggerAuditSinkConfiguration loggerAuditSinkConfiguration,
             string connectionString,
-            SinkOptions sinkOptions = null,
-            IConfigurationSection sinkOptionsSection = null,
-            IConfiguration appConfiguration = null,
-            LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum,
-            IFormatProvider formatProvider = null,
-            ColumnOptions columnOptions = null,
-            IConfigurationSection columnOptionsSection = null,
-            ITextFormatter logEventFormatter = null,
-            IApplySystemConfiguration applySystemConfiguration = null,
-            IApplyMicrosoftExtensionsConfiguration applyMicrosoftExtensionsConfiguration = null,
-            IMSSqlServerAuditSinkFactory auditSinkFactory = null)
+            SinkOptions sinkOptions,
+            IConfigurationSection sinkOptionsSection,
+            IConfiguration appConfiguration,
+            LogEventLevel restrictedToMinimumLevel,
+            IFormatProvider formatProvider,
+            ColumnOptions columnOptions,
+            IConfigurationSection columnOptionsSection,
+            ITextFormatter logEventFormatter,
+            IApplySystemConfiguration applySystemConfiguration,
+            IApplyMicrosoftExtensionsConfiguration applyMicrosoftExtensionsConfiguration,
+            IMSSqlServerAuditSinkFactory auditSinkFactory)
         {
             if (loggerAuditSinkConfiguration == null)
                 throw new ArgumentNullException(nameof(loggerAuditSinkConfiguration));
diff --git a/src/Serilog.Sinks.MSSqlServer/Configuration/Extensions/Microsoft.Extensions.Configuration/LoggerConfigurationMSSqlServerExtensions.cs b/src/Serilog.Sinks.MSSqlServer/Configuration/Extensions/Microsoft.Extensions.Configuration/LoggerConfigurationMSSqlServerExtensions.cs
@@ -126,7 +126,10 @@ public static LoggerConfiguration MSSqlServer(
             IMSSqlServerSinkFactory sinkFactory = new MSSqlServerSinkFactory();
             var sink = sinkFactory.Create(connectionString, sinkOptions, formatProvider, columnOptions, logEventFormatter);
 
-            return loggerConfiguration.Sink(sink, restrictedToMinimumLevel);
+            IPeriodicBatchingSinkFactory periodicBatchingSinkFactory = new PeriodicBatchingSinkFactory();
+            var periodicBatchingSink = periodicBatchingSinkFactory.Create(sink, sinkOptions);
+
+            return loggerConfiguration.Sink(periodicBatchingSink, restrictedToMinimumLevel);
         }
 
         /// <summary>
diff --git a/src/Serilog.Sinks.MSSqlServer/Configuration/Extensions/System.Configuration/LoggerConfigurationMSSqlServerExtensions.cs b/src/Serilog.Sinks.MSSqlServer/Configuration/Extensions/System.Configuration/LoggerConfigurationMSSqlServerExtensions.cs
@@ -116,20 +116,22 @@ public static LoggerConfiguration MSSqlServer(
                 columnOptions: columnOptions,
                 logEventFormatter: logEventFormatter,
                 applySystemConfiguration: new ApplySystemConfiguration(),
-                sinkFactory: new MSSqlServerSinkFactory());
+                sinkFactory: new MSSqlServerSinkFactory(),
+                periodicBatchingSinkFactory: new PeriodicBatchingSinkFactory());
 
         // Internal overload with parameters used by tests to override the config section and inject mocks
         internal static LoggerConfiguration MSSqlServerInternal(
             this LoggerSinkConfiguration loggerConfiguration,
             string configSectionName,
             string connectionString,
-            SinkOptions sinkOptions = null,
-            LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum,
-            IFormatProvider formatProvider = null,
-            ColumnOptions columnOptions = null,
-            ITextFormatter logEventFormatter = null,
-            IApplySystemConfiguration applySystemConfiguration = null,
-            IMSSqlServerSinkFactory sinkFactory = null)
+            SinkOptions sinkOptions,
+            LogEventLevel restrictedToMinimumLevel,
+            IFormatProvider formatProvider,
+            ColumnOptions columnOptions,
+            ITextFormatter logEventFormatter,
+            IApplySystemConfiguration applySystemConfiguration,
+            IMSSqlServerSinkFactory sinkFactory,
+            IPeriodicBatchingSinkFactory periodicBatchingSinkFactory)
         {
             if (loggerConfiguration == null)
                 throw new ArgumentNullException(nameof(loggerConfiguration));
@@ -138,7 +140,9 @@ internal static LoggerConfiguration MSSqlServerInternal(
 
             var sink = sinkFactory.Create(connectionString, sinkOptions, formatProvider, columnOptions, logEventFormatter);
 
-            return loggerConfiguration.Sink(sink, restrictedToMinimumLevel);
+            var periodicBatchingSink = periodicBatchingSinkFactory.Create(sink, sinkOptions);
+
+            return loggerConfiguration.Sink(periodicBatchingSink, restrictedToMinimumLevel);
         }
 
         /// <summary>
@@ -226,13 +230,13 @@ internal static LoggerConfiguration MSSqlServerInternal(
             this LoggerAuditSinkConfiguration loggerAuditSinkConfiguration,
             string configSectionName,
             string connectionString,
-            SinkOptions sinkOptions = null,
-            LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum,
-            IFormatProvider formatProvider = null,
-            ColumnOptions columnOptions = null,
-            ITextFormatter logEventFormatter = null,
-            IApplySystemConfiguration applySystemConfiguration = null,
-            IMSSqlServerAuditSinkFactory auditSinkFactory = null)
+            SinkOptions sinkOptions,
+            LogEventLevel restrictedToMinimumLevel,
+            IFormatProvider formatProvider,
+            ColumnOptions columnOptions,
+            ITextFormatter logEventFormatter,
+            IApplySystemConfiguration applySystemConfiguration,
+            IMSSqlServerAuditSinkFactory auditSinkFactory)
         {
             if (loggerAuditSinkConfiguration == null)
                 throw new ArgumentNullException(nameof(loggerAuditSinkConfiguration));
diff --git a/src/Serilog.Sinks.MSSqlServer/Configuration/Factories/IMSSqlServerAuditSinkFactory.cs b/src/Serilog.Sinks.MSSqlServer/Configuration/Factories/IMSSqlServerAuditSinkFactory.cs
@@ -1,12 +1,13 @@
 ﻿using System;
+using Serilog.Core;
 using Serilog.Formatting;
 using Serilog.Sinks.MSSqlServer.Sinks.MSSqlServer.Options;
 
 namespace Serilog.Sinks.MSSqlServer.Configuration.Factories
 {
     internal interface IMSSqlServerAuditSinkFactory
     {
-        MSSqlServerAuditSink Create(
+        ILogEventSink Create(
             string connectionString,
             SinkOptions sinkOptions,
             IFormatProvider formatProvider,
diff --git a/src/Serilog.Sinks.MSSqlServer/Configuration/Factories/IMSSqlServerSinkFactory.cs b/src/Serilog.Sinks.MSSqlServer/Configuration/Factories/IMSSqlServerSinkFactory.cs
@@ -1,12 +1,13 @@
 ﻿using System;
 using Serilog.Formatting;
 using Serilog.Sinks.MSSqlServer.Sinks.MSSqlServer.Options;
+using Serilog.Sinks.PeriodicBatching;
 
 namespace Serilog.Sinks.MSSqlServer.Configuration.Factories
 {
     internal interface IMSSqlServerSinkFactory
     {
-        MSSqlServerSink Create(
+        IBatchedLogEventSink Create(
             string connectionString,
             SinkOptions sinkOptions,
             IFormatProvider formatProvider,
diff --git a/src/Serilog.Sinks.MSSqlServer/Configuration/Factories/IPeriodicBatchingSinkFactory.cs b/src/Serilog.Sinks.MSSqlServer/Configuration/Factories/IPeriodicBatchingSinkFactory.cs
@@ -0,0 +1,11 @@
+﻿using Serilog.Core;
+using Serilog.Sinks.MSSqlServer.Sinks.MSSqlServer.Options;
+using Serilog.Sinks.PeriodicBatching;
+
+namespace Serilog.Sinks.MSSqlServer.Configuration.Factories
+{
+    internal interface IPeriodicBatchingSinkFactory
+    {
+        ILogEventSink Create(IBatchedLogEventSink sink, SinkOptions sinkOptions);
+    }
+}
diff --git a/src/Serilog.Sinks.MSSqlServer/Configuration/Factories/MSSqlServerAuditSinkFactory.cs b/src/Serilog.Sinks.MSSqlServer/Configuration/Factories/MSSqlServerAuditSinkFactory.cs
@@ -1,12 +1,13 @@
 ﻿using System;
+using Serilog.Core;
 using Serilog.Formatting;
 using Serilog.Sinks.MSSqlServer.Sinks.MSSqlServer.Options;
 
 namespace Serilog.Sinks.MSSqlServer.Configuration.Factories
 {
     internal class MSSqlServerAuditSinkFactory : IMSSqlServerAuditSinkFactory
     {
-        public MSSqlServerAuditSink Create(
+        public ILogEventSink Create(
             string connectionString,
             SinkOptions sinkOptions,
             IFormatProvider formatProvider,
diff --git a/src/Serilog.Sinks.MSSqlServer/Configuration/Factories/MSSqlServerSinkFactory.cs b/src/Serilog.Sinks.MSSqlServer/Configuration/Factories/MSSqlServerSinkFactory.cs
@@ -1,12 +1,13 @@
 ﻿using System;
 using Serilog.Formatting;
 using Serilog.Sinks.MSSqlServer.Sinks.MSSqlServer.Options;
+using Serilog.Sinks.PeriodicBatching;
 
 namespace Serilog.Sinks.MSSqlServer.Configuration.Factories
 {
     internal class MSSqlServerSinkFactory : IMSSqlServerSinkFactory
     {
-        public MSSqlServerSink Create(
+        public IBatchedLogEventSink Create(
             string connectionString,
             SinkOptions sinkOptions,
             IFormatProvider formatProvider,
diff --git a/src/Serilog.Sinks.MSSqlServer/Configuration/Factories/PeriodicBatchingSinkFactory.cs b/src/Serilog.Sinks.MSSqlServer/Configuration/Factories/PeriodicBatchingSinkFactory.cs
@@ -0,0 +1,21 @@
+﻿using Serilog.Core;
+using Serilog.Sinks.MSSqlServer.Sinks.MSSqlServer.Options;
+using Serilog.Sinks.PeriodicBatching;
+
+namespace Serilog.Sinks.MSSqlServer.Configuration.Factories
+{
+    internal class PeriodicBatchingSinkFactory : IPeriodicBatchingSinkFactory
+    {
+        public ILogEventSink Create(IBatchedLogEventSink sink, SinkOptions sinkOptions)
+        {
+            var periodicBatchingSinkOptions = new PeriodicBatchingSinkOptions
+            {
+                BatchSizeLimit = sinkOptions.BatchPostingLimit,
+                Period = sinkOptions.BatchPeriod,
+                EagerlyEmitFirstEvent = sinkOptions.EagerlyEmitFirstEvent
+            };
+
+            return new PeriodicBatchingSink(sink, periodicBatchingSinkOptions);
+        }
+    }
+}
diff --git a/src/Serilog.Sinks.MSSqlServer/Configuration/Implementations/Microsoft.Extensions.Configuration/MicrosoftExtensionsSinkOptionsProvider.cs b/src/Serilog.Sinks.MSSqlServer/Configuration/Implementations/Microsoft.Extensions.Configuration/MicrosoftExtensionsSinkOptionsProvider.cs
@@ -32,6 +32,7 @@ private static void ReadBatchSettings(IConfigurationSection config, SinkOptions
         {
             SetProperty.IfNotNull<int>(config["batchPostingLimit"], val => sinkOptions.BatchPostingLimit = val);
             SetProperty.IfNotNull<string>(config["batchPeriod"], val => sinkOptions.BatchPeriod = TimeSpan.Parse(val, CultureInfo.InvariantCulture));
+            SetProperty.IfNotNull<bool>(config["eagerlyEmitFirstEvent"], val => sinkOptions.EagerlyEmitFirstEvent = val);
         }
 
         private static void ReadAzureManagedIdentitiesOptions(IConfigurationSection config, SinkOptions sinkOptions)
diff --git a/src/Serilog.Sinks.MSSqlServer/Configuration/Implementations/System.Configuration/MSSqlServerConfigurationSection.cs b/src/Serilog.Sinks.MSSqlServer/Configuration/Implementations/System.Configuration/MSSqlServerConfigurationSection.cs
@@ -169,6 +169,12 @@ public ValueConfigElement BatchPeriod
             get => (ValueConfigElement)base[nameof(BatchPeriod)];
         }
 
+        [ConfigurationProperty(nameof(EagerlyEmitFirstEvent))]
+        public ValueConfigElement EagerlyEmitFirstEvent
+        {
+            get => (ValueConfigElement)base[nameof(EagerlyEmitFirstEvent)];
+        }
+
         [ConfigurationProperty(nameof(UseAzureManagedIdentity))]
         public ValueConfigElement UseAzureManagedIdentity
         {
diff --git a/src/Serilog.Sinks.MSSqlServer/Configuration/Implementations/System.Configuration/SystemConfigurationSinkOptionsProvider.cs b/src/Serilog.Sinks.MSSqlServer/Configuration/Implementations/System.Configuration/SystemConfigurationSinkOptionsProvider.cs
@@ -26,8 +26,10 @@ private static void ReadTableOptions(MSSqlServerConfigurationSection config, Sin
 
         private static void ReadBatchSettings(MSSqlServerConfigurationSection config, SinkOptions sinkOptions)
         {
-            SetProperty.IfProvided<int>(config.BatchPostingLimit, nameof(config.BatchPostingLimit.Value), val => sinkOptions.BatchPostingLimit = val);
-            SetProperty.IfProvided<string>(config.BatchPeriod, nameof(config.BatchPeriod.Value), val => sinkOptions.BatchPeriod = TimeSpan.Parse(val, CultureInfo.InvariantCulture));
+            SetProperty.IfProvided<int>(config.BatchPostingLimit, nameof(config.BatchPostingLimit.Value), value => sinkOptions.BatchPostingLimit = value);
+            SetProperty.IfProvided<string>(config.BatchPeriod, nameof(config.BatchPeriod.Value), value => sinkOptions.BatchPeriod = TimeSpan.Parse(value, CultureInfo.InvariantCulture));
+            SetProperty.IfProvided<bool>(config.EagerlyEmitFirstEvent, nameof(config.EagerlyEmitFirstEvent.Value),
+                value => sinkOptions.EagerlyEmitFirstEvent = value);
         }
 
         private static void ReadAzureManagedIdentitiesOptions(MSSqlServerConfigurationSection config, SinkOptions sinkOptions)
diff --git a/src/Serilog.Sinks.MSSqlServer/GlobalSuppressions.cs b/src/Serilog.Sinks.MSSqlServer/GlobalSuppressions.cs
diff --git a/src/Serilog.Sinks.MSSqlServer/Serilog.Sinks.MSSqlServer.csproj b/src/Serilog.Sinks.MSSqlServer/Serilog.Sinks.MSSqlServer.csproj
diff --git a/src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/MSSqlServerSink.cs b/src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/MSSqlServerSink.cs
diff --git a/src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/Options/SinkOptions.cs b/src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/Options/SinkOptions.cs
diff --git a/test/Serilog.Sinks.MSSqlServer.Tests/Configuration/Extensions/Hybrid/LoggerConfigurationMSSqlServerExtensionsTests.cs b/test/Serilog.Sinks.MSSqlServer.Tests/Configuration/Extensions/Hybrid/LoggerConfigurationMSSqlServerExtensionsTests.cs
diff --git a/test/Serilog.Sinks.MSSqlServer.Tests/Configuration/Extensions/System.Configuration/ConfigurationExtensionsTests.cs b/test/Serilog.Sinks.MSSqlServer.Tests/Configuration/Extensions/System.Configuration/ConfigurationExtensionsTests.cs
diff --git a/test/Serilog.Sinks.MSSqlServer.Tests/Configuration/Extensions/System.Configuration/LoggerConfigurationMSSqlServerExtensionsTests.cs b/test/Serilog.Sinks.MSSqlServer.Tests/Configuration/Extensions/System.Configuration/LoggerConfigurationMSSqlServerExtensionsTests.cs
diff --git a/test/Serilog.Sinks.MSSqlServer.Tests/Sinks/MSSqlServer/MSSqlServerSinkTests.cs b/test/Serilog.Sinks.MSSqlServer.Tests/Sinks/MSSqlServer/MSSqlServerSinkTests.cs

Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,13 @@`
`1`	`1`	`using System;`
	`2`	`+using Serilog.Core;`
`2`	`3`	`using Serilog.Formatting;`
`3`	`4`	`using Serilog.Sinks.MSSqlServer.Sinks.MSSqlServer.Options;`
`4`	`5`
`5`	`6`	`namespace Serilog.Sinks.MSSqlServer.Configuration.Factories`
`6`	`7`	`{`
`7`	`8`	`internal interface IMSSqlServerAuditSinkFactory`
`8`	`9`	`{`
`9`		`- MSSqlServerAuditSink Create(`
	`10`	`+ ILogEventSink Create(`
`10`	`11`	`string connectionString,`
`11`	`12`	`SinkOptions sinkOptions,`
`12`	`13`	`IFormatProvider formatProvider,`